* [PATCH] tests/tcg/s390x: Allow specifying extra QEMU options on the command line
@ 2024-05-22 18:38 Ilya Leoshkevich
2024-05-29 11:06 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Ilya Leoshkevich @ 2024-05-22 18:38 UTC (permalink / raw)
To: Richard Henderson, David Hildenbrand, Thomas Huth
Cc: qemu-s390x, qemu-devel, Ilya Leoshkevich
The use case for this is `make check-tcg EXTFLAGS="-accel kvm"`,
which allows validating the system TCG testcases on real hardware.
EXTFLAGS name is borrowed from tests/tcg/xtensa/Makefile.softmmu-target.
While at it, use += instead of = in order to be consistent with the
other architectures.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
tests/tcg/s390x/Makefile.softmmu-target | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tcg/s390x/Makefile.softmmu-target b/tests/tcg/s390x/Makefile.softmmu-target
index 1078655dd31..4ca0dac7257 100644
--- a/tests/tcg/s390x/Makefile.softmmu-target
+++ b/tests/tcg/s390x/Makefile.softmmu-target
@@ -1,6 +1,6 @@
S390X_SRC=$(SRC_PATH)/tests/tcg/s390x
VPATH+=$(S390X_SRC)
-QEMU_OPTS=-action panic=exit-failure -nographic -kernel
+QEMU_OPTS+=-action panic=exit-failure -nographic $(EXTFLAGS) -kernel
LINK_SCRIPT=$(S390X_SRC)/softmmu.ld
CFLAGS+=-ggdb -O0
LDFLAGS=-nostdlib -static
--
2.45.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/tcg/s390x: Allow specifying extra QEMU options on the command line
2024-05-22 18:38 [PATCH] tests/tcg/s390x: Allow specifying extra QEMU options on the command line Ilya Leoshkevich
@ 2024-05-29 11:06 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2024-05-29 11:06 UTC (permalink / raw)
To: Ilya Leoshkevich, Richard Henderson, David Hildenbrand
Cc: qemu-s390x, qemu-devel
On 22/05/2024 20.38, Ilya Leoshkevich wrote:
> The use case for this is `make check-tcg EXTFLAGS="-accel kvm"`,
> which allows validating the system TCG testcases on real hardware.
> EXTFLAGS name is borrowed from tests/tcg/xtensa/Makefile.softmmu-target.
> While at it, use += instead of = in order to be consistent with the
> other architectures.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> tests/tcg/s390x/Makefile.softmmu-target | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/s390x/Makefile.softmmu-target b/tests/tcg/s390x/Makefile.softmmu-target
> index 1078655dd31..4ca0dac7257 100644
> --- a/tests/tcg/s390x/Makefile.softmmu-target
> +++ b/tests/tcg/s390x/Makefile.softmmu-target
> @@ -1,6 +1,6 @@
> S390X_SRC=$(SRC_PATH)/tests/tcg/s390x
> VPATH+=$(S390X_SRC)
> -QEMU_OPTS=-action panic=exit-failure -nographic -kernel
> +QEMU_OPTS+=-action panic=exit-failure -nographic $(EXTFLAGS) -kernel
> LINK_SCRIPT=$(S390X_SRC)/softmmu.ld
> CFLAGS+=-ggdb -O0
> LDFLAGS=-nostdlib -static
Reviewed-by: Thomas Huth <thuth@redhat.com>
(sorry, I missed this for my pull request today ... I'll queue this patch
for my next one)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-29 11:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-22 18:38 [PATCH] tests/tcg/s390x: Allow specifying extra QEMU options on the command line Ilya Leoshkevich
2024-05-29 11:06 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).