* [PATCH] target/i386: disable jmp_opt if EFLAGS.RF is 1
@ 2024-05-24 15:33 Paolo Bonzini
2024-05-24 16:56 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2024-05-24 15:33 UTC (permalink / raw)
To: qemu-devel; +Cc: richard.henderson, qemu-stable
If EFLAGS.RF is 1, special processing in gen_eob_worker() is needed and
therefore goto_tb cannot be used.
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/tcg/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index 76be7425800..ebcff8766cf 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -4660,7 +4660,7 @@ static void i386_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu)
dc->cpuid_7_1_eax_features = env->features[FEAT_7_1_EAX];
dc->cpuid_xsave_features = env->features[FEAT_XSAVE];
dc->jmp_opt = !((cflags & CF_NO_GOTO_TB) ||
- (flags & (HF_TF_MASK | HF_INHIBIT_IRQ_MASK)));
+ (flags & (HF_RF_MASK | HF_TF_MASK | HF_INHIBIT_IRQ_MASK)));
/*
* If jmp_opt, we want to handle each string instruction individually.
* For icount also disable repz optimization so that each iteration
--
2.45.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] target/i386: disable jmp_opt if EFLAGS.RF is 1
2024-05-24 15:33 [PATCH] target/i386: disable jmp_opt if EFLAGS.RF is 1 Paolo Bonzini
@ 2024-05-24 16:56 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2024-05-24 16:56 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-stable
On 5/24/24 08:33, Paolo Bonzini wrote:
> If EFLAGS.RF is 1, special processing in gen_eob_worker() is needed and
> therefore goto_tb cannot be used.
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target/i386/tcg/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
> index 76be7425800..ebcff8766cf 100644
> --- a/target/i386/tcg/translate.c
> +++ b/target/i386/tcg/translate.c
> @@ -4660,7 +4660,7 @@ static void i386_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu)
> dc->cpuid_7_1_eax_features = env->features[FEAT_7_1_EAX];
> dc->cpuid_xsave_features = env->features[FEAT_XSAVE];
> dc->jmp_opt = !((cflags & CF_NO_GOTO_TB) ||
> - (flags & (HF_TF_MASK | HF_INHIBIT_IRQ_MASK)));
> + (flags & (HF_RF_MASK | HF_TF_MASK | HF_INHIBIT_IRQ_MASK)));
> /*
> * If jmp_opt, we want to handle each string instruction individually.
> * For icount also disable repz optimization so that each iteration
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-24 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-24 15:33 [PATCH] target/i386: disable jmp_opt if EFLAGS.RF is 1 Paolo Bonzini
2024-05-24 16:56 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).