From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PATCH 2/5] meson: remove unnecessary dependency
Date: Fri, 24 May 2024 18:20:02 +0200 [thread overview]
Message-ID: <20240524162006.1271778-3-pbonzini@redhat.com> (raw)
In-Reply-To: <20240524162006.1271778-1-pbonzini@redhat.com>
The dbus_display1_dep is not really used since all occurrences also
request gio independently. Just list the generated sources and drop
dbus_display1_dep.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
audio/meson.build | 4 ++--
tests/qtest/meson.build | 2 +-
ui/meson.build | 5 ++---
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/audio/meson.build b/audio/meson.build
index 608f35e6af7..59f0a431d51 100644
--- a/audio/meson.build
+++ b/audio/meson.build
@@ -30,8 +30,8 @@ endforeach
if dbus_display
module_ss = ss.source_set()
- module_ss.add(when: [gio, dbus_display1_dep, pixman],
- if_true: files('dbusaudio.c'))
+ module_ss.add(when: [gio, pixman],
+ if_true: [dbus_display1, files('dbusaudio.c')])
audio_modules += {'dbus': module_ss}
endif
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 86293051dce..b98fae6a6dd 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -354,7 +354,7 @@ if vnc.found()
endif
if dbus_display
- qtests += {'dbus-display-test': [dbus_display1_dep, gio]}
+ qtests += {'dbus-display-test': [dbus_display1, gio]}
endif
qtest_executables = {}
diff --git a/ui/meson.build b/ui/meson.build
index 5d89986b0ee..cfbf29428df 100644
--- a/ui/meson.build
+++ b/ui/meson.build
@@ -91,8 +91,7 @@ if dbus_display
'--interface-prefix', 'org.qemu.',
'--c-namespace', 'QemuDBus',
'--generate-c-code', '@BASENAME@'])
- dbus_display1_dep = declare_dependency(sources: dbus_display1, dependencies: gio)
- dbus_ss.add(when: [gio, dbus_display1_dep],
+ dbus_ss.add(when: gio,
if_true: [files(
'dbus-chardev.c',
'dbus-clipboard.c',
@@ -100,7 +99,7 @@ if dbus_display
'dbus-error.c',
'dbus-listener.c',
'dbus.c',
- ), opengl, gbm, pixman])
+ ), opengl, gbm, pixman, dbus_display1])
ui_modules += {'dbus' : dbus_ss}
endif
--
2.45.1
next prev parent reply other threads:[~2024-05-24 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 16:20 [PATCH 0/5] meson: small cleanups Paolo Bonzini
2024-05-24 16:20 ` [PATCH 1/5] meson: remove unnecessary reference to libm Paolo Bonzini
2024-05-24 16:20 ` Paolo Bonzini [this message]
2024-05-24 16:20 ` [PATCH 3/5] tcg: include dependencies in static_library() Paolo Bonzini
2024-05-24 16:20 ` [PATCH 4/5] meson: do not query modules before they are processed Paolo Bonzini
2024-05-24 16:20 ` [PATCH 5/5] migration: remove unnecessary zlib dependency Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240524162006.1271778-3-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).