From: Zide Chen <zide.chen@intel.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, mst@redhat.com, thuth@redhat.com,
cfontana@suse.de, xiaoyao.li@intel.com, qemu-trivial@nongnu.org,
Zide Chen <zide.chen@intel.com>
Subject: [PATCH V2 1/3] vl: Allow multiple -overcommit commands
Date: Fri, 24 May 2024 13:00:15 -0700 [thread overview]
Message-ID: <20240524200017.150339-2-zide.chen@intel.com> (raw)
In-Reply-To: <20240524200017.150339-1-zide.chen@intel.com>
Both cpu-pm and mem-lock are related to system resource overcommit, but
they are separate from each other, in terms of how they are realized,
and of course, they are applied to different system resources.
It's tempting to use separate command lines to specify their behavior.
e.g., in the following example, the cpu-pm command is quietly
overwritten, and it's not easy to notice it without careful inspection.
--overcommit mem-lock=on
--overcommit cpu-pm=on
Fixes: c8c9dc42b7ca ("Remove the deprecated -realtime option")
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Zide Chen <zide.chen@intel.com>
---
v2:
Thanks to Thomas' suggestion, changed to this better approach, which
is more generic and can handle situations like: "enabled the option in
the config file, and now you'd like to disable it on the command line
again".
system/vl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/system/vl.c b/system/vl.c
index a3eede5fa5b8..dfa6cdd9283b 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -3545,8 +3545,8 @@ void qemu_init(int argc, char **argv)
if (!opts) {
exit(1);
}
- enable_mlock = qemu_opt_get_bool(opts, "mem-lock", false);
- enable_cpu_pm = qemu_opt_get_bool(opts, "cpu-pm", false);
+ enable_mlock = qemu_opt_get_bool(opts, "mem-lock", enable_mlock);
+ enable_cpu_pm = qemu_opt_get_bool(opts, "cpu-pm", enable_cpu_pm);
break;
case QEMU_OPTION_compat:
{
--
2.34.1
next prev parent reply other threads:[~2024-05-24 20:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 20:00 [PATCH V2 0/3] improve -overcommit cpu-pm=on|off Zide Chen
2024-05-24 20:00 ` Zide Chen [this message]
2024-05-27 5:19 ` [PATCH V2 1/3] vl: Allow multiple -overcommit commands Thomas Huth
2024-05-30 14:01 ` Zhao Liu
2024-05-31 4:57 ` Thomas Huth
2024-06-03 8:44 ` Markus Armbruster
2024-05-30 13:39 ` Zhao Liu
2024-05-24 20:00 ` [PATCH V2 2/3] target/i386: call cpu_exec_realizefn before x86_cpu_filter_features Zide Chen
2024-05-31 6:30 ` Zhao Liu
2024-05-31 17:13 ` Chen, Zide
2024-06-01 15:26 ` Zhao Liu
2024-06-03 9:30 ` Igor Mammedov
2024-06-03 21:29 ` Chen, Zide
2024-06-05 15:07 ` Igor Mammedov
2024-06-05 17:58 ` Chen, Zide
2024-06-03 21:29 ` Chen, Zide
2024-05-24 20:00 ` [PATCH V2 3/3] target/i386: Move host_cpu_enable_cpu_pm into kvm_cpu_realizefn() Zide Chen
2024-05-31 6:53 ` Zhao Liu
2024-05-31 17:13 ` Chen, Zide
2024-05-28 9:23 ` [PATCH V2 0/3] improve -overcommit cpu-pm=on|off Igor Mammedov
2024-05-28 18:16 ` Chen, Zide
2024-05-29 12:46 ` Igor Mammedov
2024-05-29 17:31 ` Chen, Zide
2024-05-30 13:54 ` Zhao Liu
2024-05-30 14:34 ` Igor Mammedov
2024-05-30 14:53 ` Sean Christopherson
2024-05-30 14:49 ` Igor Mammedov
2024-06-02 21:54 ` Michael S. Tsirkin
2024-05-30 16:15 ` Chen, Zide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240524200017.150339-2-zide.chen@intel.com \
--to=zide.chen@intel.com \
--cc=cfontana@suse.de \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).