From: Nicholas Piggin <npiggin@gmail.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: Nicholas Piggin <npiggin@gmail.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Thomas Huth <thuth@redhat.com>
Subject: [PATCH 2/3] tests/qtest/migration-test: Enable on ppc64
Date: Sat, 25 May 2024 13:13:28 +1000 [thread overview]
Message-ID: <20240525031330.196609-3-npiggin@gmail.com> (raw)
In-Reply-To: <20240525031330.196609-1-npiggin@gmail.com>
ppc64 with TCG seems to no longer be failing this test. Let's try to
enable it. s390x is still hanging about 1 in 10 runs.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
tests/qtest/migration-test.c | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index c13535c37d..b8617cc843 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -3454,19 +3454,9 @@ int main(int argc, char **argv)
#endif
/*
- * On ppc64, the test only works with kvm-hv, but not with kvm-pr and TCG
- * is touchy due to race conditions on dirty bits (especially on PPC for
- * some reason)
- */
- if (g_str_equal(arch, "ppc64") &&
- (!has_kvm || access("/sys/module/kvm_hv", F_OK))) {
- g_test_message("Skipping tests: kvm_hv not available");
- goto test_add_done;
- }
-
- /*
- * Similar to ppc64, s390x seems to be touchy with TCG, so disable it
- * there until the problems are resolved
+ * On s390x, the test seems to be touchy with TCG, perhaps due to race
+ * conditions on dirty bits, so disable it there until the problems are
+ * resolved.
*/
if (g_str_equal(arch, "s390x") && !has_kvm) {
g_test_message("Skipping tests: s390x host with KVM is required");
--
2.43.0
next prev parent reply other threads:[~2024-05-25 3:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 3:13 [PATCH 0/3] tests/qtest/migration-test: Improve and enable on ppc64 Nicholas Piggin
2024-05-25 3:13 ` [PATCH 1/3] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns Nicholas Piggin
2024-05-27 7:32 ` Thomas Huth
2024-05-27 11:26 ` Nicholas Piggin
2024-05-27 11:37 ` Thomas Huth
2024-05-25 3:13 ` Nicholas Piggin [this message]
2024-05-27 7:35 ` [PATCH 2/3] tests/qtest/migration-test: Enable on ppc64 Thomas Huth
2024-05-27 11:27 ` Nicholas Piggin
2024-05-25 3:13 ` [PATCH 3/3] tests/qtest/migration-test: Use custom asm bios for ppc64 Nicholas Piggin
2024-05-27 13:01 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240525031330.196609-3-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=farosas@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).