From: Chao Du <duchao@eswincomputing.com>
To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
pbonzini@redhat.com, alistair23@gmail.com,
bin.meng@windriver.com, liweiwei@iscas.ac.cn,
dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com,
palmer@dabbelt.com, anup@brainfault.org, duchao713@qq.com
Subject: [PATCH v1 2/4] target/riscv/kvm: implement kvm_arch_update_guest_debug()
Date: Mon, 27 May 2024 02:19:14 +0000 [thread overview]
Message-ID: <20240527021916.12953-3-duchao@eswincomputing.com> (raw)
In-Reply-To: <20240527021916.12953-1-duchao@eswincomputing.com>
Set the control flag when there are active breakpoints. This will
help KVM to know the status in the userspace.
Signed-off-by: Chao Du <duchao@eswincomputing.com>
---
target/riscv/kvm/kvm-cpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c
index cba55c552d..0bc3348b91 100644
--- a/target/riscv/kvm/kvm-cpu.c
+++ b/target/riscv/kvm/kvm-cpu.c
@@ -2039,5 +2039,7 @@ void kvm_arch_remove_all_hw_breakpoints(void)
void kvm_arch_update_guest_debug(CPUState *cs, struct kvm_guest_debug *dbg)
{
- /* TODO; To be implemented later. */
+ if (kvm_sw_breakpoints_active(cs)) {
+ dbg->control |= KVM_GUESTDBG_ENABLE;
+ }
}
--
2.17.1
next prev parent reply other threads:[~2024-05-27 2:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 2:19 [PATCH v1 0/4] target/riscv/kvm: QEMU support for KVM Guest Debug on RISC-V Chao Du
2024-05-27 2:19 ` [PATCH v1 1/4] target/riscv/kvm: add software breakpoints support Chao Du
2024-05-27 12:00 ` Daniel Henrique Barboza
2024-05-27 15:41 ` Andrew Jones
2024-05-28 2:43 ` Chao Du
2024-05-27 2:19 ` Chao Du [this message]
2024-05-27 12:00 ` [PATCH v1 2/4] target/riscv/kvm: implement kvm_arch_update_guest_debug() Daniel Henrique Barboza
2024-05-27 15:42 ` Andrew Jones
2024-05-27 2:19 ` [PATCH v1 3/4] target/riscv/kvm: handle the exit with debug reason Chao Du
2024-05-27 12:00 ` Daniel Henrique Barboza
2024-05-27 15:48 ` Andrew Jones
2024-05-27 2:19 ` [PATCH v1 4/4] target/riscv/kvm: define TARGET_KVM_HAVE_GUEST_DEBUG Chao Du
2024-05-27 12:00 ` Daniel Henrique Barboza
2024-05-27 15:50 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240527021916.12953-3-duchao@eswincomputing.com \
--to=duchao@eswincomputing.com \
--cc=alistair23@gmail.com \
--cc=anup@brainfault.org \
--cc=bin.meng@windriver.com \
--cc=dbarboza@ventanamicro.com \
--cc=duchao713@qq.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).