From: Jamin Lin via <qemu-devel@nongnu.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"Alistair Francis" <alistair@alistair23.me>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: <jamin_lin@aspeedtech.com>, <troy_lee@aspeedtech.com>,
<yunlin.tang@aspeedtech.com>
Subject: [PATCH v4 03/16] aspeed/sdmc: remove redundant macros
Date: Mon, 27 May 2024 16:02:17 +0800 [thread overview]
Message-ID: <20240527080231.1576609-4-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20240527080231.1576609-1-jamin_lin@aspeedtech.com>
These macros are no longer used for ASPEED SOCs, so removes them.
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
---
hw/misc/aspeed_sdmc.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
index 64cd1a81dc..74279bbe8e 100644
--- a/hw/misc/aspeed_sdmc.c
+++ b/hw/misc/aspeed_sdmc.c
@@ -76,10 +76,6 @@
#define ASPEED_SDMC_VGA_32MB 0x2
#define ASPEED_SDMC_VGA_64MB 0x3
#define ASPEED_SDMC_DRAM_SIZE(x) (x & 0x3)
-#define ASPEED_SDMC_DRAM_64MB 0x0
-#define ASPEED_SDMC_DRAM_128MB 0x1
-#define ASPEED_SDMC_DRAM_256MB 0x2
-#define ASPEED_SDMC_DRAM_512MB 0x3
#define ASPEED_SDMC_READONLY_MASK \
(ASPEED_SDMC_RESERVED | ASPEED_SDMC_VGA_COMPAT | \
@@ -100,17 +96,6 @@
#define ASPEED_SDMC_CACHE_ENABLE (1 << 10) /* differs from AST2400 */
#define ASPEED_SDMC_DRAM_TYPE (1 << 4) /* differs from AST2400 */
-/* DRAM size definitions differs */
-#define ASPEED_SDMC_AST2500_128MB 0x0
-#define ASPEED_SDMC_AST2500_256MB 0x1
-#define ASPEED_SDMC_AST2500_512MB 0x2
-#define ASPEED_SDMC_AST2500_1024MB 0x3
-
-#define ASPEED_SDMC_AST2600_256MB 0x0
-#define ASPEED_SDMC_AST2600_512MB 0x1
-#define ASPEED_SDMC_AST2600_1024MB 0x2
-#define ASPEED_SDMC_AST2600_2048MB 0x3
-
#define ASPEED_SDMC_AST2500_READONLY_MASK \
(ASPEED_SDMC_HW_VERSION(0xf) | ASPEED_SDMC_CACHE_INITIAL_DONE | \
ASPEED_SDMC_AST2500_RESERVED | ASPEED_SDMC_VGA_COMPAT | \
--
2.25.1
next prev parent reply other threads:[~2024-05-27 8:04 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 8:02 [PATCH v4 00/16] Add AST2700 support Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 01/16] aspeed/wdt: " Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 02/16] aspeed/sli: " Jamin Lin via
2024-05-27 8:02 ` Jamin Lin via [this message]
2024-05-27 8:02 ` [PATCH v4 04/16] aspeed/sdmc: fix coding style Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 05/16] aspeed/sdmc: Add AST2700 support Jamin Lin via
2024-05-27 10:24 ` Philippe Mathieu-Daudé
2024-05-27 11:18 ` Cédric Le Goater
2024-05-27 12:41 ` Philippe Mathieu-Daudé
2024-05-28 1:26 ` Jamin Lin
2024-05-28 6:34 ` Cédric Le Goater
2024-05-28 9:47 ` Jamin Lin
2024-05-28 9:52 ` Cédric Le Goater
2024-05-28 9:54 ` Jamin Lin
2024-05-27 8:02 ` [PATCH v4 06/16] aspeed/smc: correct device description Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 07/16] aspeed/smc: support dma start length and 1 byte length unit Jamin Lin via
2024-05-27 12:52 ` Cédric Le Goater
2024-05-27 8:02 ` [PATCH v4 08/16] aspeed/smc: support 64 bits dma dram address Jamin Lin via
2024-05-27 12:51 ` Cédric Le Goater
2024-05-28 1:34 ` Jamin Lin
2024-05-28 6:37 ` Cédric Le Goater
2024-05-27 16:06 ` Philippe Mathieu-Daudé
2024-05-28 1:38 ` Jamin Lin
2024-05-28 6:53 ` [SPAM] " Cédric Le Goater
2024-05-27 8:02 ` [PATCH v4 09/16] aspeed/smc: Add AST2700 support Jamin Lin via
2024-05-27 15:58 ` Philippe Mathieu-Daudé
2024-05-28 7:02 ` [SPAM] " Cédric Le Goater
2024-06-03 6:24 ` Jamin Lin
2024-06-03 7:22 ` Cédric Le Goater
2024-06-03 9:49 ` Jamin Lin
2024-06-03 9:58 ` Cédric Le Goater
2024-06-03 10:35 ` Jamin Lin
2024-06-03 11:47 ` Cédric Le Goater
2024-05-27 8:02 ` [PATCH v4 10/16] aspeed/scu: " Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 11/16] aspeed/intc: " Jamin Lin via
2024-05-28 8:47 ` Cédric Le Goater
2024-06-03 5:35 ` Jamin Lin
2024-06-03 7:09 ` Cédric Le Goater
2024-05-27 8:02 ` [PATCH v4 12/16] aspeed/soc: " Jamin Lin via
2024-05-28 8:28 ` Cédric Le Goater
2024-05-31 5:17 ` Jamin Lin
2024-05-31 7:46 ` Cédric Le Goater
2024-05-31 8:24 ` Jamin Lin
2024-05-31 10:56 ` Philippe Mathieu-Daudé
2024-05-28 8:48 ` Cédric Le Goater
2024-05-31 8:57 ` Jamin Lin
2024-05-27 8:02 ` [PATCH v4 13/16] aspeed: Add an AST2700 eval board Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 14/16] aspeed/soc: fix incorrect dram size for AST2700 Jamin Lin via
2024-05-29 8:47 ` Cédric Le Goater
2024-05-30 7:42 ` Jamin Lin
2024-05-30 8:08 ` Cédric Le Goater
2024-05-30 8:11 ` Jamin Lin
2024-05-27 8:02 ` [PATCH v4 15/16] test/avocado/machine_aspeed.py: Add AST2700 test case Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 16/16] docs:aspeed: Add AST2700 Evaluation board Jamin Lin via
2024-05-28 9:56 ` [PATCH v4 00/16] Add AST2700 support Cédric Le Goater
2024-05-28 10:02 ` Jamin Lin
2024-05-28 10:14 ` Cédric Le Goater
2024-05-29 0:47 ` Jamin Lin
2024-06-05 3:47 ` Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240527080231.1576609-4-jamin_lin@aspeedtech.com \
--to=qemu-devel@nongnu.org \
--cc=alistair@alistair23.me \
--cc=andrew@codeconstruct.com.au \
--cc=bleal@redhat.com \
--cc=clg@kaod.org \
--cc=crosa@redhat.com \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=troy_lee@aspeedtech.com \
--cc=wainersm@redhat.com \
--cc=yunlin.tang@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).