From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 4/4] usb/hub: deprecate, don't build by default
Date: Tue, 28 May 2024 11:54:59 +0200 [thread overview]
Message-ID: <20240528095459.896594-5-kraxel@redhat.com> (raw)
In-Reply-To: <20240528095459.896594-1-kraxel@redhat.com>
The hub supports only USB 1.1. When running out of usb ports it is in
almost all cases the much better choice to add another usb host adapter
(or increase the number of root ports when using xhci) instead of using
the usb hub.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/dev-hub.c | 1 +
hw/usb/Kconfig | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c
index 06e9537d0356..68444d39534f 100644
--- a/hw/usb/dev-hub.c
+++ b/hw/usb/dev-hub.c
@@ -686,6 +686,7 @@ static void usb_hub_class_initfn(ObjectClass *klass, void *data)
set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
dc->fw_name = "hub";
dc->vmsd = &vmstate_usb_hub;
+ klass->deprecation_note = "use more root ports or additional hostadapters instead";
device_class_set_props(dc, usb_hub_properties);
}
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index c4a6ea5a687f..a8644c43296b 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -66,7 +66,6 @@ config TUSB6010
config USB_HUB
bool
- default y
depends on USB
config USB_HID
--
2.45.1
prev parent reply other threads:[~2024-05-28 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 9:54 [PATCH 0/4] allow to deprecate objects and devices Gerd Hoffmann
2024-05-28 9:54 ` [PATCH 1/4] qom: allow to mark objects (including devices) as deprecated Gerd Hoffmann
2024-06-03 11:15 ` Daniel P. Berrangé
2024-05-28 9:54 ` [PATCH 2/4] usb: add config options for the hub and hid devices Gerd Hoffmann
2024-05-28 10:44 ` Thomas Huth
2024-05-28 9:54 ` [PATCH 3/4] usb/ohci-pci: deprecate, don't build by default Gerd Hoffmann
2024-05-28 10:35 ` Thomas Huth
2024-05-28 13:34 ` Helge Deller
2024-05-28 13:54 ` Paolo Bonzini
2024-05-28 21:40 ` Mark Cave-Ayland
2024-05-28 9:54 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528095459.896594-5-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).