Re: [PATCH v5 06/23] hw/acpi/ich9: Remove 'memory-hotplug-support' property

[Igor Mammedov <imammedo@redhat.com>]

On Wed, 29 May 2024 07:15:22 +0200
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

> No external code sets the 'memory-hotplug-support'
> property, remove it.
> 
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/acpi/ich9.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
> index 573d032e8e..9b605af21a 100644
> --- a/hw/acpi/ich9.c
> +++ b/hw/acpi/ich9.c
> @@ -351,21 +351,6 @@ static void ich9_pm_get_gpe0_blk(Object *obj, Visitor *v, const char *name,
>      visit_type_uint32(v, name, &value, errp);
>  }
>  
> -static bool ich9_pm_get_memory_hotplug_support(Object *obj, Error **errp)
> -{
> -    ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
> -
> -    return s->pm.acpi_memory_hotplug.is_enabled;
> -}
> -
> -static void ich9_pm_set_memory_hotplug_support(Object *obj, bool value,
> -                                               Error **errp)
> -{
> -    ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
> -
> -    s->pm.acpi_memory_hotplug.is_enabled = value;
> -}
> -
>  static bool ich9_pm_get_cpu_hotplug_legacy(Object *obj, Error **errp)
>  {
>      ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
> @@ -445,9 +430,6 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
>                          NULL, NULL, pm);
>      object_property_add_uint32_ptr(obj, ACPI_PM_PROP_GPE0_BLK_LEN,
>                                     &gpe0_len, OBJ_PROP_FLAG_READ);
> -    object_property_add_bool(obj, "memory-hotplug-support",
> -                             ich9_pm_get_memory_hotplug_support,
> -                             ich9_pm_set_memory_hotplug_support);
>      object_property_add_bool(obj, "cpu-hotplug-legacy",
>                               ich9_pm_get_cpu_hotplug_legacy,
>                               ich9_pm_set_cpu_hotplug_legacy);