* [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h
@ 2024-05-27 6:01 Thomas Huth
2024-05-27 14:58 ` Cornelia Huck
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2024-05-27 6:01 UTC (permalink / raw)
To: Cornelia Huck, Michael S. Tsirkin, Paolo Bonzini, qemu-devel; +Cc: Michael Roth
When running the update-linx-headers.sh script, it currently fails with:
scripts/update-linux-headers.sh: line 73: .../qemu/standard-headers/asm-x86/setup_data.h: No such file or directory
The "include" folder is obviously missing here - no clue how this could
have worked before?
Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import list")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
index fbf7e119bc..23afe8c08a 100755
--- a/scripts/update-linux-headers.sh
+++ b/scripts/update-linux-headers.sh
@@ -159,7 +159,7 @@ for arch in $ARCHLIST; do
cp_portable "$hdrdir/bootparam.h" \
"$output/include/standard-headers/asm-$arch"
cp_portable "$hdrdir/include/asm/setup_data.h" \
- "$output/standard-headers/asm-x86"
+ "$output/include/standard-headers/asm-x86"
fi
if [ $arch = riscv ]; then
cp "$hdrdir/include/asm/ptrace.h" "$output/linux-headers/asm-riscv/"
--
2.45.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h
2024-05-27 6:01 [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h Thomas Huth
@ 2024-05-27 14:58 ` Cornelia Huck
2024-05-29 23:28 ` Michael Roth
2024-05-30 6:02 ` Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2024-05-27 14:58 UTC (permalink / raw)
To: Thomas Huth, Michael S. Tsirkin, Paolo Bonzini, qemu-devel; +Cc: Michael Roth
On Mon, May 27 2024, Thomas Huth <thuth@redhat.com> wrote:
> When running the update-linx-headers.sh script, it currently fails with:
>
> scripts/update-linux-headers.sh: line 73: .../qemu/standard-headers/asm-x86/setup_data.h: No such file or directory
>
> The "include" folder is obviously missing here - no clue how this could
> have worked before?
Presumably nobody tried to run the script against a 6.9-ish kernel?
>
> Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import list")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> scripts/update-linux-headers.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index fbf7e119bc..23afe8c08a 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -159,7 +159,7 @@ for arch in $ARCHLIST; do
> cp_portable "$hdrdir/bootparam.h" \
> "$output/include/standard-headers/asm-$arch"
> cp_portable "$hdrdir/include/asm/setup_data.h" \
> - "$output/standard-headers/asm-x86"
> + "$output/include/standard-headers/asm-x86"
> fi
> if [ $arch = riscv ]; then
> cp "$hdrdir/include/asm/ptrace.h" "$output/linux-headers/asm-riscv/"
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h
2024-05-27 6:01 [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h Thomas Huth
2024-05-27 14:58 ` Cornelia Huck
@ 2024-05-29 23:28 ` Michael Roth
2024-05-30 6:02 ` Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Michael Roth @ 2024-05-29 23:28 UTC (permalink / raw)
To: Thomas Huth
Cc: Cornelia Huck, Michael S. Tsirkin, Paolo Bonzini, qemu-devel,
pankaj.gupta
On Mon, May 27, 2024 at 08:01:26AM +0200, Thomas Huth wrote:
> When running the update-linx-headers.sh script, it currently fails with:
>
> scripts/update-linux-headers.sh: line 73: .../qemu/standard-headers/asm-x86/setup_data.h: No such file or directory
>
> The "include" folder is obviously missing here - no clue how this could
> have worked before?
>
> Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import list")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Tested-by: Michael Roth <michael.roth@amd.com>
> ---
> scripts/update-linux-headers.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index fbf7e119bc..23afe8c08a 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -159,7 +159,7 @@ for arch in $ARCHLIST; do
> cp_portable "$hdrdir/bootparam.h" \
> "$output/include/standard-headers/asm-$arch"
> cp_portable "$hdrdir/include/asm/setup_data.h" \
> - "$output/standard-headers/asm-x86"
> + "$output/include/standard-headers/asm-x86"
> fi
> if [ $arch = riscv ]; then
> cp "$hdrdir/include/asm/ptrace.h" "$output/linux-headers/asm-riscv/"
> --
> 2.45.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h
2024-05-27 6:01 [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h Thomas Huth
2024-05-27 14:58 ` Cornelia Huck
2024-05-29 23:28 ` Michael Roth
@ 2024-05-30 6:02 ` Michael S. Tsirkin
2 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2024-05-30 6:02 UTC (permalink / raw)
To: Thomas Huth; +Cc: Cornelia Huck, Paolo Bonzini, qemu-devel, Michael Roth
On Mon, May 27, 2024 at 08:01:26AM +0200, Thomas Huth wrote:
> When running the update-linx-headers.sh script, it currently fails with:
>
> scripts/update-linux-headers.sh: line 73: .../qemu/standard-headers/asm-x86/setup_data.h: No such file or directory
>
> The "include" folder is obviously missing here - no clue how this could
> have worked before?
>
> Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import list")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Paolo you merged the offending patch wanna merge this one?
> ---
> scripts/update-linux-headers.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index fbf7e119bc..23afe8c08a 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -159,7 +159,7 @@ for arch in $ARCHLIST; do
> cp_portable "$hdrdir/bootparam.h" \
> "$output/include/standard-headers/asm-$arch"
> cp_portable "$hdrdir/include/asm/setup_data.h" \
> - "$output/standard-headers/asm-x86"
> + "$output/include/standard-headers/asm-x86"
> fi
> if [ $arch = riscv ]; then
> cp "$hdrdir/include/asm/ptrace.h" "$output/linux-headers/asm-riscv/"
> --
> 2.45.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-30 6:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-27 6:01 [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h Thomas Huth
2024-05-27 14:58 ` Cornelia Huck
2024-05-29 23:28 ` Michael Roth
2024-05-30 6:02 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).