qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert" <dave@treblig.org>,
	"David Hildenbrand" <david@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	qemu-s390x@nongnu.org, devel@lists.libvirt.org,
	"Eric Farman" <farman@linux.ibm.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Ilya Leoshkevich" <iii@linux.ibm.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Eric Blake" <eblake@redhat.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Anton Johansson" <anjo@rev.ng>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 3/4] hw/s390x: Deprecate the HMP 'dump_skeys' command
Date: Thu, 30 May 2024 09:45:43 +0200	[thread overview]
Message-ID: <20240530074544.25444-4-philmd@linaro.org> (raw)
In-Reply-To: <20240530074544.25444-1-philmd@linaro.org>

Prefer 'dump_s390_skeys' which is target agnostic.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/s390x/s390-skeys.c | 2 ++
 hmp-commands.hx       | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c
index e7dab52a6e..12ec8a808e 100644
--- a/hw/s390x/s390-skeys.c
+++ b/hw/s390x/s390-skeys.c
@@ -120,6 +120,8 @@ void hmp_dump_s390_skeys(Monitor *mon, const QDict *qdict)
 
 void hmp_dump_skeys(Monitor *mon, const QDict *qdict)
 {
+    monitor_printf(mon, "This command is deprecated"
+                        " (replaced by 'dump-s390-skeys')\n");
     hmp_dump_s390_skeys(mon, qdict);
 }
 
diff --git a/hmp-commands.hx b/hmp-commands.hx
index c12e2c2bd9..04ae897134 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1138,14 +1138,14 @@ ERST
         .name       = "dump-skeys",
         .args_type  = "filename:F",
         .params     = "",
-        .help       = "Save guest storage keys into file 'filename'.\n",
+        .help       = "deprecated synonym for dump-s390-skeys.",
         .cmd        = hmp_dump_skeys,
     },
 #endif
 
 SRST
 ``dump-skeys`` *filename*
-  Save guest storage keys to a file.
+  This is a deprecated synonym for the dump-s390-skeys command.
 ERST
 
 #if defined(TARGET_S390X)
-- 
2.41.0



  parent reply	other threads:[~2024-05-30  7:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30  7:45 [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate Philippe Mathieu-Daudé
2024-05-30  7:45 ` [PATCH 1/4] hw/s390x: Introduce the @dump-s390-skeys QMP command Philippe Mathieu-Daudé
2024-05-30  7:45 ` [PATCH 2/4] hw/s390x: Introduce the 'dump_s390_skeys' HMP command Philippe Mathieu-Daudé
2024-05-30  7:45 ` Philippe Mathieu-Daudé [this message]
2024-05-30  7:45 ` [PATCH 4/4] hw/s390x: Deprecate the QMP @dump-skeys command Philippe Mathieu-Daudé
2024-05-31  4:49   ` Thomas Huth
2024-05-30  8:58 ` [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate Anton Johansson via
2024-05-31  4:47 ` Thomas Huth
2024-05-31 14:02   ` Dr. David Alan Gilbert
2024-05-31 16:23     ` Thomas Huth
2024-06-03 17:06       ` Dr. David Alan Gilbert
2024-06-03 12:18   ` Daniel P. Berrangé
2024-06-03 20:54     ` Dr. David Alan Gilbert
2024-06-04  4:58       ` Markus Armbruster
2024-06-04  9:45         ` Philippe Mathieu-Daudé
2024-06-04  9:59           ` Daniel P. Berrangé
2024-06-04 10:00           ` Markus Armbruster
2024-06-05 11:44             ` Dr. David Alan Gilbert
2024-06-10  5:20               ` Markus Armbruster
2024-06-27 16:46                 ` Dr. David Alan Gilbert
2025-03-09 18:55     ` Pierrick Bouvier
2025-03-10  6:50       ` Thomas Huth
2025-03-10  9:11         ` Daniel P. Berrangé
2025-03-10 12:30         ` Dr. David Alan Gilbert
2025-03-09 18:44 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240530074544.25444-4-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=anjo@rev.ng \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=dave@treblig.org \
    --cc=david@redhat.com \
    --cc=devel@lists.libvirt.org \
    --cc=eblake@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).