From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Cameron Esfahani" <dirty@apple.com>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Reinoud Zandijk" <reinoud@netbsd.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
kvm@vger.kernel.org, "Roman Bolshakov" <rbolshakov@ddn.com>
Subject: [PATCH 0/5] cpus: a few tweaks to CPU realization
Date: Thu, 30 May 2024 20:42:45 +0100 [thread overview]
Message-ID: <20240530194250.1801701-1-alex.bennee@linaro.org> (raw)
The recent IPS plugin exposed a race condition between vcpu_init
callbacks and the other vcpu state callbacks. I originally thought
there was some wider re-factoring to be done to clean this up but it
turns out things are broadly where they should be. However some of the
stuff allocated in the vCPU threads can clearly be done earlier so
I've moved enough from cpu_common_realizefn to cpu_common_initfn to
allow plugins to queue work before the threads start solving the race.
Please review.
Alex Bennée (5):
hw/core: expand on the alignment of CPUState
cpu: move Qemu[Thread|Cond] setup into common code
cpu-target: don't set cpu->thread_id to bogus value
plugins: remove special casing for cpu->realized
core/cpu-common: initialise plugin state before thread creation
include/hw/core/cpu.h | 18 ++++++++++++++----
accel/dummy-cpus.c | 3 ---
accel/hvf/hvf-accel-ops.c | 4 ----
accel/kvm/kvm-accel-ops.c | 3 ---
accel/tcg/tcg-accel-ops-mttcg.c | 4 ----
accel/tcg/tcg-accel-ops-rr.c | 14 +++++++-------
cpu-target.c | 1 -
hw/core/cpu-common.c | 25 +++++++++++++++++--------
plugins/core.c | 6 +-----
target/i386/nvmm/nvmm-accel-ops.c | 3 ---
target/i386/whpx/whpx-accel-ops.c | 3 ---
11 files changed, 39 insertions(+), 45 deletions(-)
--
2.39.2
next reply other threads:[~2024-05-30 19:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 19:42 Alex Bennée [this message]
2024-05-30 19:42 ` [PATCH 1/5] hw/core: expand on the alignment of CPUState Alex Bennée
2024-05-30 22:28 ` Pierrick Bouvier
2024-06-03 11:32 ` Philippe Mathieu-Daudé
2024-05-30 19:42 ` [PATCH 2/5] cpu: move Qemu[Thread|Cond] setup into common code Alex Bennée
2024-05-30 22:29 ` Pierrick Bouvier
2024-05-31 13:46 ` Reinoud Zandijk
2024-06-03 11:28 ` Philippe Mathieu-Daudé
2024-05-30 19:42 ` [PATCH 3/5] cpu-target: don't set cpu->thread_id to bogus value Alex Bennée
2024-05-30 22:29 ` Pierrick Bouvier
2024-06-03 11:29 ` Philippe Mathieu-Daudé
2024-05-30 19:42 ` [PATCH 4/5] plugins: remove special casing for cpu->realized Alex Bennée
2024-05-30 22:30 ` Pierrick Bouvier
2024-06-03 11:31 ` Philippe Mathieu-Daudé
2024-06-03 14:11 ` Philippe Mathieu-Daudé
2024-06-03 14:19 ` Alex Bennée
2024-05-30 19:42 ` [PATCH 5/5] core/cpu-common: initialise plugin state before thread creation Alex Bennée
2024-05-30 22:31 ` Pierrick Bouvier
2024-05-31 8:59 ` Alex Bennée
2024-05-31 7:26 ` Philippe Mathieu-Daudé
2024-05-31 8:47 ` Alex Bennée
2024-06-03 14:10 ` Philippe Mathieu-Daudé
2024-06-03 12:47 ` [PATCH 0/5] cpus: a few tweaks to CPU realization Philippe Mathieu-Daudé
2024-06-03 14:11 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530194250.1801701-1-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=dirty@apple.com \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=kvm@vger.kernel.org \
--cc=ma.mandourr@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=reinoud@netbsd.org \
--cc=richard.henderson@linaro.org \
--cc=sunilmut@microsoft.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).