From: Zhenzhong Duan <zhenzhong.duan@intel.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, clg@redhat.com,
eric.auger@redhat.com, mst@redhat.com, peterx@redhat.com,
jasowang@redhat.com, jgg@nvidia.com, nicolinc@nvidia.com,
joao.m.martins@oracle.com, clement.mathieu--drif@eviden.com,
kevin.tian@intel.com, yi.l.liu@intel.com, chao.p.peng@intel.com,
Zhenzhong Duan <zhenzhong.duan@intel.com>
Subject: [PATCH v6 13/19] vfio: Create host IOMMU device instance
Date: Mon, 3 Jun 2024 14:10:17 +0800 [thread overview]
Message-ID: <20240603061023.269738-14-zhenzhong.duan@intel.com> (raw)
In-Reply-To: <20240603061023.269738-1-zhenzhong.duan@intel.com>
Create host IOMMU device instance in vfio_attach_device() and call
.realize() to initialize it further.
Suggested-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
include/hw/vfio/vfio-common.h | 1 +
hw/vfio/common.c | 16 +++++++++++++++-
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
index 56d1717211..c0851e83bb 100644
--- a/include/hw/vfio/vfio-common.h
+++ b/include/hw/vfio/vfio-common.h
@@ -127,6 +127,7 @@ typedef struct VFIODevice {
OnOffAuto pre_copy_dirty_page_tracking;
bool dirty_pages_supported;
bool dirty_tracking;
+ HostIOMMUDevice *hiod;
int devid;
IOMMUFDBackend *iommufd;
} VFIODevice;
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index f9619a1dfb..f20a7b5bba 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -1528,6 +1528,7 @@ bool vfio_attach_device(char *name, VFIODevice *vbasedev,
{
const VFIOIOMMUClass *ops =
VFIO_IOMMU_CLASS(object_class_by_name(TYPE_VFIO_IOMMU_LEGACY));
+ HostIOMMUDevice *hiod;
if (vbasedev->iommufd) {
ops = VFIO_IOMMU_CLASS(object_class_by_name(TYPE_VFIO_IOMMU_IOMMUFD));
@@ -1535,7 +1536,19 @@ bool vfio_attach_device(char *name, VFIODevice *vbasedev,
assert(ops);
- return ops->attach_device(name, vbasedev, as, errp);
+ if (!ops->attach_device(name, vbasedev, as, errp)) {
+ return false;
+ }
+
+ hiod = HOST_IOMMU_DEVICE(object_new(ops->hiod_typename));
+ if (!HOST_IOMMU_DEVICE_GET_CLASS(hiod)->realize(hiod, vbasedev, errp)) {
+ object_unref(hiod);
+ ops->detach_device(vbasedev);
+ return false;
+ }
+ vbasedev->hiod = hiod;
+
+ return true;
}
void vfio_detach_device(VFIODevice *vbasedev)
@@ -1543,5 +1556,6 @@ void vfio_detach_device(VFIODevice *vbasedev)
if (!vbasedev->bcontainer) {
return;
}
+ object_unref(vbasedev->hiod);
vbasedev->bcontainer->ops->detach_device(vbasedev);
}
--
2.34.1
next prev parent reply other threads:[~2024-06-03 6:14 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 6:10 [PATCH v6 00/19] Add a host IOMMU device abstraction to check with vIOMMU Zhenzhong Duan
2024-06-03 6:10 ` [PATCH v6 01/19] backends: Introduce HostIOMMUDevice abstract Zhenzhong Duan
2024-06-03 12:16 ` Cédric Le Goater
2024-06-04 3:10 ` Duan, Zhenzhong
2024-06-03 12:46 ` Eric Auger
2024-06-04 3:41 ` Duan, Zhenzhong
2024-06-03 6:10 ` [PATCH v6 02/19] vfio/container: Introduce TYPE_HOST_IOMMU_DEVICE_LEGACY_VFIO device Zhenzhong Duan
2024-06-03 6:10 ` [PATCH v6 03/19] backends/iommufd: Introduce abstract TYPE_HOST_IOMMU_DEVICE_IOMMUFD device Zhenzhong Duan
2024-06-03 12:50 ` Eric Auger
2024-06-04 3:43 ` Duan, Zhenzhong
2024-06-03 6:10 ` [PATCH v6 04/19] vfio/iommufd: Introduce TYPE_HOST_IOMMU_DEVICE_IOMMUFD_VFIO device Zhenzhong Duan
2024-06-03 6:10 ` [PATCH v6 05/19] backends/host_iommu_device: Introduce HostIOMMUDeviceCaps Zhenzhong Duan
2024-06-03 12:40 ` Cédric Le Goater
2024-06-03 12:51 ` Eric Auger
2024-06-03 6:10 ` [PATCH v6 06/19] range: Introduce range_get_last_bit() Zhenzhong Duan
2024-06-03 12:57 ` Eric Auger
2024-06-03 6:10 ` [PATCH v6 07/19] vfio/container: Implement HostIOMMUDeviceClass::realize() handler Zhenzhong Duan
2024-06-03 11:23 ` Eric Auger
2024-06-04 2:45 ` Duan, Zhenzhong
2024-06-04 7:45 ` Eric Auger
2024-06-04 7:59 ` Duan, Zhenzhong
2024-06-03 6:10 ` [PATCH v6 08/19] backends/iommufd: Introduce helper function iommufd_backend_get_device_info() Zhenzhong Duan
2024-06-03 6:10 ` [PATCH v6 09/19] vfio/iommufd: Implement HostIOMMUDeviceClass::realize() handler Zhenzhong Duan
2024-06-03 11:30 ` Eric Auger
2024-06-04 2:58 ` Duan, Zhenzhong
2024-06-04 7:31 ` Eric Auger
2024-06-04 7:51 ` Duan, Zhenzhong
2024-06-04 8:08 ` Eric Auger
2024-06-04 8:39 ` Duan, Zhenzhong
2024-06-06 9:26 ` Eric Auger
2024-06-06 9:32 ` Eric Auger
2024-06-06 10:19 ` Duan, Zhenzhong
2024-06-03 6:10 ` [PATCH v6 10/19] vfio/container: Implement HostIOMMUDeviceClass::get_cap() handler Zhenzhong Duan
2024-06-03 6:10 ` [PATCH v6 11/19] backends/iommufd: " Zhenzhong Duan
2024-06-03 11:32 ` Eric Auger
2024-06-03 12:35 ` Cédric Le Goater
2024-06-04 3:23 ` Duan, Zhenzhong
2024-06-04 8:10 ` Eric Auger
2024-06-04 8:46 ` Duan, Zhenzhong
2024-06-04 9:37 ` Eric Auger
2024-06-03 6:10 ` [PATCH v6 12/19] vfio: Introduce VFIOIOMMUClass::hiod_typename attribute Zhenzhong Duan
2024-06-03 6:10 ` Zhenzhong Duan [this message]
2024-06-03 12:59 ` [PATCH v6 13/19] vfio: Create host IOMMU device instance Eric Auger
2024-06-04 3:47 ` Duan, Zhenzhong
2024-06-03 6:10 ` [PATCH v6 14/19] hw/pci: Introduce helper function pci_device_get_iommu_bus_devfn() Zhenzhong Duan
2024-06-03 13:40 ` Eric Auger
2024-06-03 6:10 ` [PATCH v6 15/19] hw/pci: Introduce pci_device_[set|unset]_iommu_device() Zhenzhong Duan
2024-06-03 13:54 ` Eric Auger
2024-06-03 6:10 ` [PATCH v6 16/19] vfio/pci: Pass HostIOMMUDevice to vIOMMU Zhenzhong Duan
2024-06-03 13:54 ` Eric Auger
2024-06-03 6:10 ` [PATCH v6 17/19] intel_iommu: Extract out vtd_cap_init() to initialize cap/ecap Zhenzhong Duan
2024-06-03 6:10 ` [PATCH v6 18/19] intel_iommu: Implement [set|unset]_iommu_device() callbacks Zhenzhong Duan
2024-06-03 10:12 ` CLEMENT MATHIEU--DRIF
2024-06-03 11:02 ` Duan, Zhenzhong
2024-06-03 12:56 ` Cédric Le Goater
2024-06-04 3:46 ` Duan, Zhenzhong
2024-06-03 14:13 ` Eric Auger
2024-06-04 5:40 ` Duan, Zhenzhong
2024-06-04 8:14 ` Eric Auger
2024-06-04 8:48 ` Duan, Zhenzhong
2024-06-04 9:38 ` Eric Auger
2024-06-03 14:47 ` Eric Auger
2024-06-04 5:46 ` Duan, Zhenzhong
2024-06-04 8:17 ` Eric Auger
2024-06-06 4:04 ` Duan, Zhenzhong
2024-06-03 6:10 ` [PATCH v6 19/19] intel_iommu: Check compatibility with host IOMMU capabilities Zhenzhong Duan
2024-06-03 14:23 ` Eric Auger
2024-06-04 5:46 ` Duan, Zhenzhong
2024-06-03 12:43 ` [PATCH v6 00/19] Add a host IOMMU device abstraction to check with vIOMMU Eric Auger
2024-06-04 3:32 ` Duan, Zhenzhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603061023.269738-14-zhenzhong.duan@intel.com \
--to=zhenzhong.duan@intel.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=clement.mathieu--drif@eviden.com \
--cc=clg@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=joao.m.martins@oracle.com \
--cc=kevin.tian@intel.com \
--cc=mst@redhat.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).