qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zide Chen <zide.chen@intel.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, mst@redhat.com, thuth@redhat.com,
	cfontana@suse.de, xiaoyao.li@intel.com, qemu-trivial@nongnu.org,
	seanjc@google.com, zhao1.liu@intel.com,
	Zide Chen <zide.chen@intel.com>
Subject: [PATCH V3 0/2] improve -overcommit cpu-pm=on|off
Date: Mon,  3 Jun 2024 17:02:20 -0700	[thread overview]
Message-ID: <20240604000222.75065-1-zide.chen@intel.com> (raw)

Currently, if running "-overcommit cpu-pm=on" on hosts that don't
have MWAIT support, the MWAIT/MONITOR feature is advertised to the
guest and executing MWAIT/MONITOR on the guest triggers #UD.

Typically #UD takes priority over VM-Exit interception checks and
KVM doesn't emulate MONITOR/MWAIT. This causes the guest fail to
boot.

V2:
- [PATCH 1]: took Thomas' suggestion for more generic fix
- [PATCH 2/3]: no changes

V3:
- dropped [PATCH 1/3]. Took the simpler approach not to re-order
  cpu_exec_realizefn() call.
- changed patch title in [PATCH V3 1/2]
- don't set CPUID_EXT_MONITOR in kvm_cpu_realizefn() 

Zide Chen (2):
  vl: Allow multiple -overcommit commands
  target/i386: Advertise MWAIT iff host supports

 system/vl.c               |  4 ++--
 target/i386/host-cpu.c    | 12 ------------
 target/i386/kvm/kvm-cpu.c | 11 +++++++++--
 3 files changed, 11 insertions(+), 16 deletions(-)

-- 
2.34.1



             reply	other threads:[~2024-06-04  0:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  0:02 Zide Chen [this message]
2024-06-04  0:02 ` [PATCH V3 1/2] vl: Allow multiple -overcommit commands Zide Chen
2024-06-05 13:34   ` Igor Mammedov
2024-06-04  0:02 ` [PATCH V3 2/2] target/i386: Advertise MWAIT iff host supports Zide Chen
2024-06-04  4:02   ` Zhao Liu
2024-06-04 15:08   ` Xiaoyao Li
2024-06-05 13:41   ` Igor Mammedov
2024-06-05 13:49 ` [PATCH V3 0/2] improve -overcommit cpu-pm=on|off Igor Mammedov
2024-06-05 18:33   ` Chen, Zide
2024-06-17 12:47 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240604000222.75065-1-zide.chen@intel.com \
    --to=zide.chen@intel.com \
    --cc=cfontana@suse.de \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=seanjc@google.com \
    --cc=thuth@redhat.com \
    --cc=xiaoyao.li@intel.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).