From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5537CC25B7E for ; Tue, 4 Jun 2024 07:06:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEOEP-0002L4-Uy; Tue, 04 Jun 2024 03:05:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEOEN-0002KP-Sb for qemu-devel@nongnu.org; Tue, 04 Jun 2024 03:05:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEOEL-0007vL-QZ for qemu-devel@nongnu.org; Tue, 04 Jun 2024 03:05:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717484713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RMMFlBqBxSKAtY3fSRv5AiVk7Z0F2ZuH2si0lWa8sgI=; b=i8eaqWNwoTmbRZ8SxrBHiDYMIIL7hXT47PnJ0ISudaDJRuQRIG1KUIJ2lL/0RtfUS0HG6K nw6MWBvco7QTdkwsISr5S2oBTWSiSMYE2SPHQMTIGS6P4TGsC+FX4yOVm1uAiWqsptTOMk xg3t68LjofAvHAfEQwaXhXunqGfEVcM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-9OafA1ZkOuiBN3sgMGQ4-Q-1; Tue, 04 Jun 2024 03:05:07 -0400 X-MC-Unique: 9OafA1ZkOuiBN3sgMGQ4-Q-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4212abb4720so32271795e9.0 for ; Tue, 04 Jun 2024 00:05:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717484706; x=1718089506; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RMMFlBqBxSKAtY3fSRv5AiVk7Z0F2ZuH2si0lWa8sgI=; b=htjSInajYMAoMnPA80wkc20qkNuRDGbotGhD8i47OW+vcyG3T24NhksImMKHLRxain DdmYD4O9JrYoARI3RiUKPwlmUPWHQyELaYJMDAAvcl23WAcMRen7QoHGP+8TAcAFwTBY N2avhfa7X8R6cXoC6UWNk2zmjqANTetX/lMSAF1U9Pi8nT3doXuqo+dSnb+FzyF8m5qL ig2J1Cg0KlHPfI6AjROvRaz0t8PHSXS5mUusJcCFGw1AvC8gKOKLSiFIrZQYiRCDwikL fHmJAUPzWcEapwD7nWwsIGcwZbRuwJWD5HFiAzMk9eIuyUR86A3BtVF1Y5WCWN3bdYvK aGzQ== X-Forwarded-Encrypted: i=1; AJvYcCWXjE21X9Pnfx585NNeMFNDQVQxEHfZpmWRo251y5OJJUbO4AsB8VolMmG3U7ZtwUZMyN4qXtGopN7z6l7W4tdZEsERMlc= X-Gm-Message-State: AOJu0YxgW87B4Skm2AQoeiPGqd0SGS7xA/Bz93CGncc1C1bNsmDJM++g 8CntnANeTvQHgTCZLPk8NUupY/A25v0kI2iUyDdB+DYykNWhcMTnihyIybCTbwMxkrRBSGFfufM rlgahz5q61dGsVBaFOmtTDyMOqZlJKTx6hwtatfj5C4ljz21EAu0E X-Received: by 2002:a05:600c:5486:b0:421:5237:31df with SMTP id 5b1f17b1804b1-421523732e3mr5969255e9.28.1717484704990; Tue, 04 Jun 2024 00:05:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHMVaUpMJXCLfNl5Rf/Iai39+UoKVi3W/renVjiGyZsmyNWJ2E9vf67ECy9Bf3AZhYjpAAWEQ== X-Received: by 2002:a05:600c:5486:b0:421:5237:31df with SMTP id 5b1f17b1804b1-421523732e3mr5968975e9.28.1717484704419; Tue, 04 Jun 2024 00:05:04 -0700 (PDT) Received: from redhat.com ([2a0d:6fc7:552:cf5c:2b13:215c:b9df:f231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4213ad0aa15sm77020925e9.44.2024.06.04.00.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 00:05:03 -0700 (PDT) Date: Tue, 4 Jun 2024 03:04:58 -0400 From: "Michael S. Tsirkin" To: Alistair Francis Cc: Sunil V L , qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, Paolo Bonzini , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Daniel P =?iso-8859-1?Q?=2E_Berrang=E9?= , Thomas Huth , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Igor Mammedov , Ani Sinha , Laurent Vivier , Gerd Hoffmann , Sia Jee Heng , Haibo1 Xu , Anup Patel , Andrew Jones , Daniel Henrique Barboza , Peter Maydell , Palmer Dabbelt , Bin Meng , Weiwei Li , Liu Zhiwei Subject: Re: [PATCH v2 00/12] Add support for RISC-V ACPI tests Message-ID: <20240604030424-mutt-send-email-mst@kernel.org> References: <20240524061411.341599-1-sunilvl@ventanamicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jun 04, 2024 at 01:29:28PM +1000, Alistair Francis wrote: > On Fri, May 24, 2024 at 4:14 PM Sunil V L wrote: > > > > Currently, bios-table-test doesn't support RISC-V. This series enables > > the framework changes required and basic testing. Things like NUMA > > related test cases will be added later. > > > > This needs refactoring/renaming of ARM64 bios table tests. Importantly, > > the test cases now look for the expected AML files under > > tests/data/acpi/virt/aarch64 path instead of directly under > > tests/data/acpi/virt. To keep test cases not to fail because of this > > movement, they are updated to look for both paths first. > > > > As part of this effort, it is found that uefi-test-tools is currently > > broken to build. So, updated its Makefile as well to use python based > > edk2 build script. > > It would be great to get someone who knows the UEFI world better than I > do to ack these changes, especially the first few patches > > > Alistair ACPI things look ok. I can merge this but will wait a week or so more for more acks. > > > > The changes are also available at branch > > https://gitlab.com/vlsunil/qemu/-/tree/riscv_bios_table_test_v2 > > > > Changes since v1: > > 1) Addressed feedback from Gerd and Alistair > > 2) Rebased and added tags received > > > > Sunil V L (12): > > uefi-test-tools/UefiTestToolsPkg: Add RISC-V support > > uefi-test-tools: Add support for python based build script > > tests/data/uefi-boot-images: Add RISC-V ISO image > > qtest: bios-tables-test: Rename aarch64 tests with aarch64 in them > > tests/qtest/bios-tables-test.c: Add support for arch in path > > tests/data/acpi/virt: Move ACPI tables under aarch64 > > meson.build: Add RISC-V to the edk2-target list > > pc-bios/meson.build: Add support for RISC-V in unpack_edk2_blobs > > tests/data/acpi/rebuild-expected-aml.sh: Add RISC-V > > tests/qtest/bios-tables-test: Add empty ACPI data files for RISC-V > > tests/qtest/bios-tables-test.c: Enable basic testing for RISC-V > > tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V > > > > meson.build | 2 +- > > pc-bios/meson.build | 2 + > > tests/data/acpi/rebuild-expected-aml.sh | 5 +- > > tests/data/acpi/virt/{ => aarch64}/APIC | Bin > > .../acpi/virt/{ => aarch64}/APIC.acpihmatvirt | Bin > > .../acpi/virt/{ => aarch64}/APIC.topology | Bin > > tests/data/acpi/virt/{ => aarch64}/DBG2 | Bin > > tests/data/acpi/virt/{ => aarch64}/DSDT | Bin > > .../acpi/virt/{ => aarch64}/DSDT.acpihmatvirt | Bin > > tests/data/acpi/virt/{ => aarch64}/DSDT.memhp | Bin > > tests/data/acpi/virt/{ => aarch64}/DSDT.pxb | Bin > > .../acpi/virt/{ => aarch64}/DSDT.topology | Bin > > tests/data/acpi/virt/{ => aarch64}/FACP | Bin > > tests/data/acpi/virt/{ => aarch64}/GTDT | Bin > > .../acpi/virt/{ => aarch64}/HMAT.acpihmatvirt | Bin > > tests/data/acpi/virt/{ => aarch64}/IORT | Bin > > tests/data/acpi/virt/{ => aarch64}/MCFG | Bin > > tests/data/acpi/virt/{ => aarch64}/NFIT.memhp | Bin > > tests/data/acpi/virt/{ => aarch64}/PPTT | Bin > > .../acpi/virt/{ => aarch64}/PPTT.acpihmatvirt | Bin > > .../acpi/virt/{ => aarch64}/PPTT.topology | Bin > > tests/data/acpi/virt/{ => aarch64}/SLIT.memhp | Bin > > tests/data/acpi/virt/{ => aarch64}/SPCR | Bin > > .../acpi/virt/{ => aarch64}/SRAT.acpihmatvirt | Bin > > tests/data/acpi/virt/{ => aarch64}/SRAT.memhp | Bin > > .../data/acpi/virt/{ => aarch64}/SRAT.numamem | Bin > > tests/data/acpi/virt/{ => aarch64}/SSDT.memhp | Bin > > tests/data/acpi/virt/{ => aarch64}/VIOT | Bin > > tests/data/acpi/virt/riscv64/APIC | Bin 0 -> 116 bytes > > tests/data/acpi/virt/riscv64/DSDT | Bin 0 -> 3518 bytes > > tests/data/acpi/virt/riscv64/FACP | Bin 0 -> 276 bytes > > tests/data/acpi/virt/riscv64/MCFG | Bin 0 -> 60 bytes > > tests/data/acpi/virt/riscv64/RHCT | Bin 0 -> 314 bytes > > tests/data/acpi/virt/riscv64/SPCR | Bin 0 -> 80 bytes > > .../bios-tables-test.riscv64.iso.qcow2 | Bin 0 -> 16896 bytes > > tests/qtest/bios-tables-test.c | 93 ++++++++++++++---- > > tests/qtest/meson.build | 3 + > > tests/uefi-test-tools/Makefile | 19 ++-- > > .../UefiTestToolsPkg/UefiTestToolsPkg.dsc | 6 +- > > tests/uefi-test-tools/uefi-test-build.config | 52 ++++++++++ > > 40 files changed, 147 insertions(+), 35 deletions(-) > > rename tests/data/acpi/virt/{ => aarch64}/APIC (100%) > > rename tests/data/acpi/virt/{ => aarch64}/APIC.acpihmatvirt (100%) > > rename tests/data/acpi/virt/{ => aarch64}/APIC.topology (100%) > > rename tests/data/acpi/virt/{ => aarch64}/DBG2 (100%) > > rename tests/data/acpi/virt/{ => aarch64}/DSDT (100%) > > rename tests/data/acpi/virt/{ => aarch64}/DSDT.acpihmatvirt (100%) > > rename tests/data/acpi/virt/{ => aarch64}/DSDT.memhp (100%) > > rename tests/data/acpi/virt/{ => aarch64}/DSDT.pxb (100%) > > rename tests/data/acpi/virt/{ => aarch64}/DSDT.topology (100%) > > rename tests/data/acpi/virt/{ => aarch64}/FACP (100%) > > rename tests/data/acpi/virt/{ => aarch64}/GTDT (100%) > > rename tests/data/acpi/virt/{ => aarch64}/HMAT.acpihmatvirt (100%) > > rename tests/data/acpi/virt/{ => aarch64}/IORT (100%) > > rename tests/data/acpi/virt/{ => aarch64}/MCFG (100%) > > rename tests/data/acpi/virt/{ => aarch64}/NFIT.memhp (100%) > > rename tests/data/acpi/virt/{ => aarch64}/PPTT (100%) > > rename tests/data/acpi/virt/{ => aarch64}/PPTT.acpihmatvirt (100%) > > rename tests/data/acpi/virt/{ => aarch64}/PPTT.topology (100%) > > rename tests/data/acpi/virt/{ => aarch64}/SLIT.memhp (100%) > > rename tests/data/acpi/virt/{ => aarch64}/SPCR (100%) > > rename tests/data/acpi/virt/{ => aarch64}/SRAT.acpihmatvirt (100%) > > rename tests/data/acpi/virt/{ => aarch64}/SRAT.memhp (100%) > > rename tests/data/acpi/virt/{ => aarch64}/SRAT.numamem (100%) > > rename tests/data/acpi/virt/{ => aarch64}/SSDT.memhp (100%) > > rename tests/data/acpi/virt/{ => aarch64}/VIOT (100%) > > create mode 100644 tests/data/acpi/virt/riscv64/APIC > > create mode 100644 tests/data/acpi/virt/riscv64/DSDT > > create mode 100644 tests/data/acpi/virt/riscv64/FACP > > create mode 100644 tests/data/acpi/virt/riscv64/MCFG > > create mode 100644 tests/data/acpi/virt/riscv64/RHCT > > create mode 100644 tests/data/acpi/virt/riscv64/SPCR > > create mode 100644 tests/data/uefi-boot-images/bios-tables-test.riscv64.iso.qcow2 > > create mode 100644 tests/uefi-test-tools/uefi-test-build.config > > > > -- > > 2.40.1 > >