From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Andrew Melnychenko <andrew@daynix.com>, Jason Wang <jasowang@redhat.com>
Subject: [PULL 20/20] ebpf: Added traces back. Changed source set for eBPF to 'system'.
Date: Tue, 4 Jun 2024 15:37:55 +0800 [thread overview]
Message-ID: <20240604073755.1859-21-jasowang@redhat.com> (raw)
In-Reply-To: <20240604073755.1859-1-jasowang@redhat.com>
From: Andrew Melnychenko <andrew@daynix.com>
There was an issue with Qemu build with "--disable-system".
The traces could be generated and the build fails.
The traces were 'cut out' for previous patches, and overall,
the 'system' source set should be used like in pre-'eBPF blob' patches.
Signed-off-by: Andrew Melnychenko <andrew@daynix.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
| 7 +++++++
ebpf/trace.h | 1 +
2 files changed, 8 insertions(+)
create mode 100644 ebpf/trace.h
--git a/ebpf/ebpf_rss.c b/ebpf/ebpf_rss.c
index d102f3dd09..87f0714910 100644
--- a/ebpf/ebpf_rss.c
+++ b/ebpf/ebpf_rss.c
@@ -25,6 +25,8 @@
#include "ebpf/rss.bpf.skeleton.h"
#include "ebpf/ebpf.h"
+#include "trace.h"
+
void ebpf_rss_init(struct EBPFRSSContext *ctx)
{
if (ctx != NULL) {
@@ -55,18 +57,21 @@ static bool ebpf_rss_mmap(struct EBPFRSSContext *ctx)
PROT_READ | PROT_WRITE, MAP_SHARED,
ctx->map_configuration, 0);
if (ctx->mmap_configuration == MAP_FAILED) {
+ trace_ebpf_error("eBPF RSS", "can not mmap eBPF configuration array");
return false;
}
ctx->mmap_toeplitz_key = mmap(NULL, qemu_real_host_page_size(),
PROT_READ | PROT_WRITE, MAP_SHARED,
ctx->map_toeplitz_key, 0);
if (ctx->mmap_toeplitz_key == MAP_FAILED) {
+ trace_ebpf_error("eBPF RSS", "can not mmap eBPF toeplitz key");
goto toeplitz_fail;
}
ctx->mmap_indirections_table = mmap(NULL, qemu_real_host_page_size(),
PROT_READ | PROT_WRITE, MAP_SHARED,
ctx->map_indirections_table, 0);
if (ctx->mmap_indirections_table == MAP_FAILED) {
+ trace_ebpf_error("eBPF RSS", "can not mmap eBPF indirection table");
goto indirection_fail;
}
@@ -108,12 +113,14 @@ bool ebpf_rss_load(struct EBPFRSSContext *ctx)
rss_bpf_ctx = rss_bpf__open();
if (rss_bpf_ctx == NULL) {
+ trace_ebpf_error("eBPF RSS", "can not open eBPF RSS object");
goto error;
}
bpf_program__set_type(rss_bpf_ctx->progs.tun_rss_steering_prog, BPF_PROG_TYPE_SOCKET_FILTER);
if (rss_bpf__load(rss_bpf_ctx)) {
+ trace_ebpf_error("eBPF RSS", "can not load RSS program");
goto error;
}
diff --git a/ebpf/trace.h b/ebpf/trace.h
new file mode 100644
index 0000000000..abefc46ab1
--- /dev/null
+++ b/ebpf/trace.h
@@ -0,0 +1 @@
+#include "trace/trace-ebpf.h"
--
2.42.0
next prev parent reply other threads:[~2024-06-04 7:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 7:37 [PULL 00/20] Net patches Jason Wang
2024-06-04 7:37 ` [PULL 01/20] tap: Remove tap_probe_vnet_hdr_len() Jason Wang
2024-06-04 7:37 ` [PULL 02/20] tap: Remove qemu_using_vnet_hdr() Jason Wang
2024-06-04 7:37 ` [PULL 03/20] net: Move virtio-net header length assertion Jason Wang
2024-06-04 7:37 ` [PULL 04/20] net: Remove receive_raw() Jason Wang
2024-06-04 7:37 ` [PULL 05/20] tap: Call tap_receive_iov() from tap_receive() Jason Wang
2024-06-04 7:37 ` [PULL 06/20] tap: Shrink zeroed virtio-net header Jason Wang
2024-06-04 7:37 ` [PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors Jason Wang
2024-06-05 10:23 ` Daniel P. Berrangé
2024-06-05 20:14 ` Akihiko Odaki
2024-06-06 7:14 ` Daniel P. Berrangé
2024-06-06 7:19 ` Akihiko Odaki
2024-06-06 7:59 ` Daniel P. Berrangé
2024-06-07 6:04 ` Akihiko Odaki
2024-06-04 7:37 ` [PULL 08/20] virtio-net: Add only one queue pair when realizing Jason Wang
2024-10-14 8:30 ` Laurent Vivier
2024-10-14 15:16 ` Laurent Vivier
2024-10-17 6:59 ` Jason Wang
2024-10-17 7:32 ` Laurent Vivier
2024-10-17 9:07 ` Akihiko Odaki
2024-10-17 9:17 ` Laurent Vivier
2024-10-17 9:42 ` Akihiko Odaki
2024-10-18 4:50 ` Jason Wang
2024-10-19 12:38 ` Akihiko Odaki
2024-10-21 7:23 ` Jason Wang
2024-10-21 8:40 ` Akihiko Odaki
2024-06-04 7:37 ` [PULL 09/20] virtio-net: Copy header only when necessary Jason Wang
2024-06-04 7:37 ` [PULL 10/20] virtio-net: Shrink header byte swapping buffer Jason Wang
2024-06-04 7:37 ` [PULL 11/20] virtio-net: Disable RSS on reset Jason Wang
2024-06-04 7:37 ` [PULL 12/20] virtio-net: Unify the logic to update NIC state for RSS Jason Wang
2024-06-04 7:37 ` [PULL 13/20] virtio-net: Always set populate_hash Jason Wang
2024-06-04 7:37 ` [PULL 14/20] virtio-net: Do not write hashes to peer buffer Jason Wang
2024-06-04 7:37 ` [PULL 15/20] ebpf: Fix RSS error handling Jason Wang
2024-06-04 7:37 ` [PULL 16/20] ebpf: Return 0 when configuration fails Jason Wang
2024-06-04 7:37 ` [PULL 17/20] ebpf: Refactor tun_rss_steering_prog() Jason Wang
2024-06-04 7:37 ` [PULL 18/20] ebpf: Add a separate target for skeleton Jason Wang
2024-06-04 7:37 ` [PULL 19/20] virtio-net: drop too short packets early Jason Wang
2024-06-04 7:37 ` Jason Wang [this message]
2024-06-04 19:52 ` [PULL 00/20] Net patches Richard Henderson
2024-06-05 10:14 ` Michael Tokarev
2024-06-05 20:18 ` Akihiko Odaki
2024-06-06 0:13 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604073755.1859-21-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=andrew@daynix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).