From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Weißschuh" <thomas@t-8ch.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 27/32] hw/misc/debugexit: use runstate API instead of plain exit()
Date: Tue, 4 Jun 2024 11:56:03 +0200 [thread overview]
Message-ID: <20240604095609.12285-28-philmd@linaro.org> (raw)
In-Reply-To: <20240604095609.12285-1-philmd@linaro.org>
From: Thomas Weißschuh <thomas@t-8ch.de>
Directly calling exit() prevents any kind of management or handling.
Instead use the corresponding runstate API.
The default behavior of the runstate API is the same as exit().
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240523-debugexit-v1-1-d52fcaf7bf8b@t-8ch.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/misc/debugexit.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/misc/debugexit.c b/hw/misc/debugexit.c
index ab6de69ce7..c5c562fd93 100644
--- a/hw/misc/debugexit.c
+++ b/hw/misc/debugexit.c
@@ -12,6 +12,7 @@
#include "hw/qdev-properties.h"
#include "qemu/module.h"
#include "qom/object.h"
+#include "sysemu/runstate.h"
#define TYPE_ISA_DEBUG_EXIT_DEVICE "isa-debug-exit"
OBJECT_DECLARE_SIMPLE_TYPE(ISADebugExitState, ISA_DEBUG_EXIT_DEVICE)
@@ -32,7 +33,8 @@ static uint64_t debug_exit_read(void *opaque, hwaddr addr, unsigned size)
static void debug_exit_write(void *opaque, hwaddr addr, uint64_t val,
unsigned width)
{
- exit((val << 1) | 1);
+ qemu_system_shutdown_request_with_code(SHUTDOWN_CAUSE_GUEST_SHUTDOWN,
+ (val << 1) | 1);
}
static const MemoryRegionOps debug_exit_ops = {
--
2.41.0
next prev parent reply other threads:[~2024-06-04 9:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 9:55 [PULL 00/32] Misc HW / accel patches Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 01/32] target/riscv: Remove unused 'instmap.h' header in translate.c Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 02/32] target/riscv: Restrict 'rv128' machine to TCG accelerator Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 03/32] target/riscv: Restrict riscv_cpu_do_interrupt() to sysemu Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 04/32] target/mips: Remove unused 'hw/misc/mips_itu.h' header Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 05/32] target/arm: Replace sprintf() by snprintf() Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 06/32] target/i386/kvm: Improve KVM_EXIT_NOTIFY warnings Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 07/32] disas/m68k: Replace sprintf() by snprintf() Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 08/32] disas/microblaze: " Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 09/32] util/hexdump: Remove b parameter from qemu_hexdump_line Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 10/32] util/hexdump: Remove ascii " Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 11/32] MAINTAINERS: drop usb maintainership Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 12/32] system/runstate: Remove unused 'qemu/plugin.h' header Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 13/32] accel/tcg: Move common declarations to 'internal-common.h' Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 14/32] accel/kvm: Fix two lines with hard-coded tabs Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 15/32] hw/core: expand on the alignment of CPUState Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 16/32] cpu: move Qemu[Thread|Cond] setup into common code Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 17/32] cpu-target: don't set cpu->thread_id to bogus value Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 18/32] plugins: remove special casing for cpu->realized Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 19/32] core/cpu-common: initialise plugin state before thread creation Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 20/32] xen: Add xen_mr_is_memory() Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 21/32] physmem: Always pass offset + addr to xen_map_cache Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 22/32] physmem: Replace check for RAMBlock offset 0 with xen_mr_is_memory Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 23/32] hw/xen: Constify XenLegacyDevice::XenDevOps Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 24/32] hw/xen: Constify xenstore_be::XenDevOps Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 25/32] hw/xen: Make XenDevOps structures const Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 26/32] hw/xen: Register framebuffer backend via xen_backend_init() Philippe Mathieu-Daudé
2024-06-04 9:56 ` Philippe Mathieu-Daudé [this message]
2024-06-04 9:56 ` [PULL 28/32] hw/dma/xlnx_dpdma: Read descriptor into buffer, not into pointer-to-buffer Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 29/32] hw/acpi: Remove the deprecated QAPI MEM_UNPLUG_ERROR event Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 30/32] trace: Remove deprecated 'vcpu' field from QMP trace events Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 31/32] qga: Remove deprecated 'blacklist' argument / config key Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 32/32] usb: add config options for the hub and hid devices Philippe Mathieu-Daudé
2024-06-04 21:25 ` [PULL 00/32] Misc HW / accel patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604095609.12285-28-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thomas@t-8ch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).