From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
"Alistair Francis" <alistair.francis@wdc.com>
Subject: [PULL 03/32] target/riscv: Restrict riscv_cpu_do_interrupt() to sysemu
Date: Tue, 4 Jun 2024 11:55:39 +0200 [thread overview]
Message-ID: <20240604095609.12285-4-philmd@linaro.org> (raw)
In-Reply-To: <20240604095609.12285-1-philmd@linaro.org>
riscv_cpu_do_interrupt() is not reachable on user emulation.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20230626232007.8933-7-philmd@linaro.org>
---
target/riscv/cpu.h | 5 +++--
target/riscv/cpu_helper.c | 7 ++-----
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 2d0c02c35b..648e640f22 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -484,7 +484,6 @@ extern const char * const riscv_int_regnamesh[];
extern const char * const riscv_fpr_regnames[];
const char *riscv_cpu_get_trap_name(target_ulong cause, bool async);
-void riscv_cpu_do_interrupt(CPUState *cpu);
int riscv_cpu_write_elf64_note(WriteCoreDumpFunction f, CPUState *cs,
int cpuid, DumpState *s);
int riscv_cpu_write_elf32_note(WriteCoreDumpFunction f, CPUState *cs,
@@ -514,6 +513,7 @@ int riscv_cpu_max_xlen(RISCVCPUClass *mcc);
bool riscv_cpu_option_set(const char *optname);
#ifndef CONFIG_USER_ONLY
+void riscv_cpu_do_interrupt(CPUState *cpu);
void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename);
void riscv_cpu_do_transaction_failed(CPUState *cs, hwaddr physaddr,
vaddr addr, unsigned size,
@@ -539,7 +539,8 @@ void riscv_cpu_set_aia_ireg_rmw_fn(CPURISCVState *env, uint32_t priv,
void *rmw_fn_arg);
RISCVException smstateen_acc_ok(CPURISCVState *env, int index, uint64_t bit);
-#endif
+#endif /* !CONFIG_USER_ONLY */
+
void riscv_cpu_set_mode(CPURISCVState *env, target_ulong newpriv);
void riscv_translate_init(void);
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index 8ad546a45a..0868357f1c 100644
--- a/target/riscv/cpu_helper.c
+++ b/target/riscv/cpu_helper.c
@@ -1635,7 +1635,6 @@ static target_ulong riscv_transformed_insn(CPURISCVState *env,
return xinsn;
}
-#endif /* !CONFIG_USER_ONLY */
/*
* Handle Traps
@@ -1645,8 +1644,6 @@ static target_ulong riscv_transformed_insn(CPURISCVState *env,
*/
void riscv_cpu_do_interrupt(CPUState *cs)
{
-#if !defined(CONFIG_USER_ONLY)
-
RISCVCPU *cpu = RISCV_CPU(cs);
CPURISCVState *env = &cpu->env;
bool write_gva = false;
@@ -1842,6 +1839,6 @@ void riscv_cpu_do_interrupt(CPUState *cs)
env->two_stage_lookup = false;
env->two_stage_indirect_lookup = false;
-#endif
- cs->exception_index = RISCV_EXCP_NONE; /* mark handled to qemu */
}
+
+#endif /* !CONFIG_USER_ONLY */
--
2.41.0
next prev parent reply other threads:[~2024-06-04 9:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 9:55 [PULL 00/32] Misc HW / accel patches Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 01/32] target/riscv: Remove unused 'instmap.h' header in translate.c Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 02/32] target/riscv: Restrict 'rv128' machine to TCG accelerator Philippe Mathieu-Daudé
2024-06-04 9:55 ` Philippe Mathieu-Daudé [this message]
2024-06-04 9:55 ` [PULL 04/32] target/mips: Remove unused 'hw/misc/mips_itu.h' header Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 05/32] target/arm: Replace sprintf() by snprintf() Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 06/32] target/i386/kvm: Improve KVM_EXIT_NOTIFY warnings Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 07/32] disas/m68k: Replace sprintf() by snprintf() Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 08/32] disas/microblaze: " Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 09/32] util/hexdump: Remove b parameter from qemu_hexdump_line Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 10/32] util/hexdump: Remove ascii " Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 11/32] MAINTAINERS: drop usb maintainership Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 12/32] system/runstate: Remove unused 'qemu/plugin.h' header Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 13/32] accel/tcg: Move common declarations to 'internal-common.h' Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 14/32] accel/kvm: Fix two lines with hard-coded tabs Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 15/32] hw/core: expand on the alignment of CPUState Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 16/32] cpu: move Qemu[Thread|Cond] setup into common code Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 17/32] cpu-target: don't set cpu->thread_id to bogus value Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 18/32] plugins: remove special casing for cpu->realized Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 19/32] core/cpu-common: initialise plugin state before thread creation Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 20/32] xen: Add xen_mr_is_memory() Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 21/32] physmem: Always pass offset + addr to xen_map_cache Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 22/32] physmem: Replace check for RAMBlock offset 0 with xen_mr_is_memory Philippe Mathieu-Daudé
2024-06-04 9:55 ` [PULL 23/32] hw/xen: Constify XenLegacyDevice::XenDevOps Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 24/32] hw/xen: Constify xenstore_be::XenDevOps Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 25/32] hw/xen: Make XenDevOps structures const Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 26/32] hw/xen: Register framebuffer backend via xen_backend_init() Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 27/32] hw/misc/debugexit: use runstate API instead of plain exit() Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 28/32] hw/dma/xlnx_dpdma: Read descriptor into buffer, not into pointer-to-buffer Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 29/32] hw/acpi: Remove the deprecated QAPI MEM_UNPLUG_ERROR event Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 30/32] trace: Remove deprecated 'vcpu' field from QMP trace events Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 31/32] qga: Remove deprecated 'blacklist' argument / config key Philippe Mathieu-Daudé
2024-06-04 9:56 ` [PULL 32/32] usb: add config options for the hub and hid devices Philippe Mathieu-Daudé
2024-06-04 21:25 ` [PULL 00/32] Misc HW / accel patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604095609.12285-4-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=dbarboza@ventanamicro.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).