From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com,
edgar.iglesias@amd.com
Subject: [PATCH v1 0/1] hw/intc/arm_gic: Fix deactivation of SPI lines
Date: Wed, 5 Jun 2024 16:30:43 +0200 [thread overview]
Message-ID: <20240605143044.2029444-1-edgar.iglesias@gmail.com> (raw)
From: "Edgar E. Iglesias" <edgar.iglesias@amd.com>
Julien reported that he has seen strange behaviour when running
Xen on QEMU using GICv2. When Xen migrates a guest's vCPU to
another pCPU while the vCPU is handling an interrupt the guest
is unable to properly deactivate interrupts.
It sounds like something rare but in some setups it actually
happens all the time.
Looking at it a little closer, our GICv2 model treats
deactivation of SPI lines as if they were PPI's, i.e banked per
CPU core. The state for active interrupts should only be banked
for PPI lines, not for SPI lines.
When deactivating SPI lines, I think we need to handle the state
as unbanked, similar to how we handle writes to GICD_ICACTIVER.
This fixes the problem on my side.
Cheers,
Edgar
Edgar E. Iglesias (1):
hw/intc/arm_gic: Fix deactivation of SPI lines
hw/intc/gic_internal.h | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
base-commit: d16cab541ab9217977e2a39abf3d79f914146741
--
2.40.1
next reply other threads:[~2024-06-05 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 14:30 Edgar E. Iglesias [this message]
2024-06-05 14:30 ` [PATCH v1 1/1] hw/intc/arm_gic: Fix deactivation of SPI lines Edgar E. Iglesias
2024-06-07 14:33 ` [PATCH v1 0/1] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605143044.2029444-1-edgar.iglesias@gmail.com \
--to=edgar.iglesias@gmail.com \
--cc=bertrand.marquis@arm.com \
--cc=edgar.iglesias@amd.com \
--cc=julien@xen.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).