qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Igor Mammedov <imammedo@redhat.com>,
	Ani Sinha <anisinha@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	qemu-devel@nongnu.org, Andrea Righi <andrea.righi@canonical.com>
Subject: Re: [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT
Date: Fri, 7 Jun 2024 05:33:15 -0400	[thread overview]
Message-ID: <20240607053103-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240607085903.1349513-3-ribalda@chromium.org>

On Fri, Jun 07, 2024 at 08:58:58AM +0000, Ricardo Ribalda wrote:
> --- /tmp/asl-87N0O2.dsl	2024-06-07 07:20:54.081576394 +0000
> +++ /tmp/asl-4Q0YO2.dsl	2024-06-07 07:20:54.077576397 +0000
> @@ -1,30 +1,30 @@
>  /*
>   * Intel ACPI Component Architecture
>   * AML/ASL+ Disassembler version 20230628 (64-bit version)
>   * Copyright (c) 2000 - 2023 Intel Corporation
>   *
>   * Disassembling to symbolic ASL+ operators
>   *
> - * Disassembly of tests/data/acpi/pc/DSDT, Fri Jun  7 07:20:54 2024
> + * Disassembly of /tmp/aml-NF1YO2, Fri Jun  7 07:20:54 2024
>   *
>   * Original Table Header:
>   *     Signature        "DSDT"
> - *     Length           0x00001AAE (6830)
> + *     Length           0x0000214F (8527)
>   *     Revision         0x01 **** 32-bit table (V1), no 64-bit math support
> - *     Checksum         0x0B
> + *     Checksum         0x59
>   *     OEM ID           "BOCHS "
>   *     OEM Table ID     "BXPC    "
>   *     OEM Revision     0x00000001 (1)
>   *     Compiler ID      "BXPC"
>   *     Compiler Version 0x00000001 (1)
>   */
>  DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC    ", 0x00000001)
>  {
>      Scope (\)
>      {
>          OperationRegion (DBG, SystemIO, 0x0402, One)
>          Field (DBG, ByteAcc, NoLock, Preserve)
>          {
>              DBGB,   8
>          }
>

trim this part when you post in the future.

 
> @@ -168,102 +168,1058 @@
>                          ""
>                      }
>                  Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
>                      ))
>                  Local0 [Zero] = Local2
>                  Return (Local0)
>              }
>          }
>      }
> 
>      Scope (_SB)
>      {
>          Scope (PCI0)
>          {
>              Method (_PRT, 0, NotSerialized)  // _PRT: PCI Routing Table
>              {
> -                Local0 = Package (0x80){}
> -                Local1 = Zero
> -                While ((Local1 < 0x80))
> +                Return (Package (0x80)
>                  {
> -                    Local2 = (Local1 >> 0x02)
> -                    Local3 = ((Local1 + Local2) & 0x03)
> -                    If ((Local3 == Zero))
> -                    {
> -                        Local4 = Package (0x04)
> -                            {
> -                                Zero,
> -                                Zero,
> -                                LNKD,
> -                                Zero
> -                            }
> -                    }
> +                    Package (0x04)
> +                    {
> +                        0xFFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> 
> -                    If ((Local3 == One))
> +                    Package (0x04)
>                      {
> -                        If ((Local1 == 0x04))
> -                        {
> -                            Local4 = Package (0x04)
> -                                {
> -                                    Zero,
> -                                    Zero,
> -                                    LNKS,
> -                                    Zero
> -                                }
> -                        }
> -                        Else
> -                        {
> -                            Local4 = Package (0x04)
> -                                {
> -                                    Zero,
> -                                    Zero,
> -                                    LNKA,
> -                                    Zero
> -                                }
> -                        }
> -                    }
> +                        0xFFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> 
> -                    If ((Local3 == 0x02))
> +                    Package (0x04)
>                      {
> -                        Local4 = Package (0x04)
> -                            {
> -                                Zero,
> -                                Zero,
> -                                LNKB,
> -                                Zero
> -                            }
> -                    }
> +                        0xFFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> 
> -                    If ((Local3 == 0x03))
> +                    Package (0x04)
>                      {
> -                        Local4 = Package (0x04)
> -                            {
> -                                Zero,
> -                                Zero,
> -                                LNKC,
> -                                Zero
> -                            }
> -                    }
> +                        0xFFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> 
> -                    Local4 [Zero] = ((Local2 << 0x10) | 0xFFFF)
> -                    Local4 [One] = (Local1 & 0x03)
> -                    Local0 [Local1] = Local4
> -                    Local1++
> -                }
> +                    Package (0x04)
> +                    {
> +                        0x0001FFFF,
> +                        Zero,
> +                        LNKS,
> +                        Zero
> +                    },
> 
> -                Return (Local0)
> +                    Package (0x04)
> +                    {
> +                        0x0001FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0001FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0001FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0002FFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0002FFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0002FFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0002FFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0003FFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0003FFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0003FFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0003FFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0004FFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0004FFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0004FFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0004FFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0005FFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0005FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0005FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0005FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0006FFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0006FFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0006FFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0006FFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0007FFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0007FFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0007FFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0007FFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0008FFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0008FFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0008FFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0008FFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0009FFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0009FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0009FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0009FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000AFFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000AFFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000AFFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000AFFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000BFFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000BFFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000BFFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000BFFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000CFFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000CFFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000CFFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000CFFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000DFFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000DFFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000DFFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000DFFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000EFFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000EFFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000EFFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000EFFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000FFFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000FFFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000FFFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x000FFFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0010FFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0010FFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0010FFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0010FFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0011FFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0011FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0011FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0011FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0012FFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0012FFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0012FFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0012FFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0013FFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0013FFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0013FFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0013FFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0014FFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0014FFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0014FFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0014FFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0015FFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0015FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0015FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0015FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0016FFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0016FFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0016FFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0016FFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0017FFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0017FFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0017FFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0017FFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0018FFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0018FFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0018FFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0018FFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0019FFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0019FFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0019FFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x0019FFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001AFFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001AFFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001AFFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001AFFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001BFFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001BFFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001BFFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001BFFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001CFFFF,
> +                        Zero,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001CFFFF,
> +                        One,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001CFFFF,
> +                        0x02,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001CFFFF,
> +                        0x03,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001DFFFF,
> +                        Zero,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001DFFFF,
> +                        One,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001DFFFF,
> +                        0x02,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001DFFFF,
> +                        0x03,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001EFFFF,
> +                        Zero,
> +                        LNKB,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001EFFFF,
> +                        One,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001EFFFF,
> +                        0x02,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001EFFFF,
> +                        0x03,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001FFFFF,
> +                        Zero,
> +                        LNKC,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001FFFFF,
> +                        One,
> +                        LNKD,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001FFFFF,
> +                        0x02,
> +                        LNKA,
> +                        Zero
> +                    },
> +
> +                    Package (0x04)
> +                    {
> +                        0x001FFFFF,
> +                        0x03,
> +                        LNKB,
> +                        Zero
> +                    }


Too much detail, include two-three examples, and then
just put in ....



> +                })
>              }
>          }
> 
>          Method (IQST, 1, NotSerialized)
>          {
>              If ((0x80 & Arg0))
>              {
>                  Return (0x09)
>              }
> 
>              Return (0x0B)
>          }
> 
>          Method (IQCR, 1, Serialized)
>          {
>              Name (PRR0, ResourceTemplate ()
> **
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  tests/data/acpi/pc/DSDT                     | Bin 6830 -> 8527 bytes
>  tests/data/acpi/pc/DSDT.acpierst            | Bin 6741 -> 8438 bytes
>  tests/data/acpi/pc/DSDT.acpihmat            | Bin 8155 -> 9852 bytes
>  tests/data/acpi/pc/DSDT.bridge              | Bin 13701 -> 15398 bytes
>  tests/data/acpi/pc/DSDT.cphp                | Bin 7294 -> 8991 bytes
>  tests/data/acpi/pc/DSDT.dimmpxm             | Bin 8484 -> 10181 bytes
>  tests/data/acpi/pc/DSDT.hpbridge            | Bin 6781 -> 8478 bytes
>  tests/data/acpi/pc/DSDT.hpbrroot            | Bin 3337 -> 5034 bytes
>  tests/data/acpi/pc/DSDT.ipmikcs             | Bin 6902 -> 8599 bytes
>  tests/data/acpi/pc/DSDT.memhp               | Bin 8189 -> 9886 bytes
>  tests/data/acpi/pc/DSDT.nohpet              | Bin 6688 -> 8385 bytes
>  tests/data/acpi/pc/DSDT.numamem             | Bin 6836 -> 8533 bytes
>  tests/data/acpi/pc/DSDT.roothp              | Bin 10623 -> 12320 bytes
>  tests/data/acpi/q35/DSDT.cxl                | Bin 9714 -> 13148 bytes
>  tests/data/acpi/q35/DSDT.viot               | Bin 9464 -> 14615 bytes
>  tests/qtest/bios-tables-test-allowed-diff.h |   1 -
>  16 files changed, 1 deletion(-)
> 
> diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT
> index c93ad6b7f83a168a1833d7dba1112dd2ab8a431f..92225236e717b2e522a2ee00492fb0ded418dc7b 100644
> GIT binary patch
> delta 1914
> zcmY+_OK#gR6a`RPmVc7`lmCBo0R=kA0^&G>phg?inPg;S4auBYNk<(QD7uD@yN<4c
> zy?hjfcW1ixyAY2k+COjp9<$Ts^z`+EF^%V6*~i2_e7|0f*U|ay@$TW%^#1Mo`0dI3
> zn4Dj;_cBj&=gj%b=aUK74P4)vvhbg03BoakCc>R5`)T1^!}!jnPQHb~LHJI37!A>y
> z%vW&(sU}jzaFu*D&L&2x7?mobZ(=zz+mvQpLeuzW9BqasMx}}9n{pS6^`=sdOGu>}

...

-- 
MST



  reply	other threads:[~2024-06-07  9:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07  8:58 [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Ricardo Ribalda
2024-06-07  8:58 ` [PATCH v2 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table Ricardo Ribalda
2024-06-07  9:30   ` Michael S. Tsirkin
2024-06-07  8:58 ` [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT Ricardo Ribalda
2024-06-07  9:33   ` Michael S. Tsirkin [this message]
2024-06-07  9:33 ` [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2024-09-24 13:24 [PATCH v2 0/3] Fix WinXP ISO boot using the dc390/am53C974 SCSI device Ricardo Ribalda
2024-09-24 13:24 ` [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT Ricardo Ribalda
2024-09-24 14:22   ` Igor Mammedov
2024-11-04 13:46   ` Michael S. Tsirkin
2024-11-04 14:00     ` Ricardo Ribalda
2024-11-04 14:21       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240607053103-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=andrea.righi@canonical.com \
    --cc=anisinha@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=imammedo@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ribalda@chromium.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).