qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Harsh Prateek Bora" <harshpb@linux.ibm.com>,
	qemu-ppc@nongnu.org, "Nicholas Piggin" <npiggin@gmail.com>,
	"Frédéric Barrat" <fbarrat@linux.ibm.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 16/26] hw/ppc: Avoid using Monitor in pnv_psi_pic_print_info()
Date: Mon, 10 Jun 2024 08:20:54 +0200	[thread overview]
Message-ID: <20240610062105.49848-17-philmd@linaro.org> (raw)
In-Reply-To: <20240610062105.49848-1-philmd@linaro.org>

Replace Monitor API by HumanReadableText one.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/hw/ppc/pnv_psi.h |  2 +-
 hw/ppc/pnv.c             | 10 +++++++---
 hw/ppc/pnv_psi.c         |  9 +--------
 3 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/include/hw/ppc/pnv_psi.h b/include/hw/ppc/pnv_psi.h
index 2a6f715350..cf7f95a6b1 100644
--- a/include/hw/ppc/pnv_psi.h
+++ b/include/hw/ppc/pnv_psi.h
@@ -110,6 +110,6 @@ typedef enum PnvPsiIrq {
 #define PSIHB9_IRQ_PSU          13
 #define PSIHB9_NUM_IRQS         14
 
-void pnv_psi_pic_print_info(Pnv9Psi *psi, Monitor *mon);
+void pnv_psi_pic_print_info(Pnv9Psi *psi, GString *buf);
 
 #endif /* PPC_PNV_PSI_H */
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 7e6f923c7e..4a1a302a25 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -812,12 +812,11 @@ static void pnv_chip_power9_pic_print_info(PnvChip *chip, Monitor *mon)
     g_autoptr(HumanReadableText) info = NULL;
 
     pnv_xive_pic_print_info(&chip9->xive, buf);
+    pnv_psi_pic_print_info(&chip9->psi, buf);
 
     info = human_readable_text_from_str(buf);
     monitor_puts(mon, info->human_readable_text);
 
-    pnv_psi_pic_print_info(&chip9->psi, mon);
-
     object_child_foreach_recursive(OBJECT(chip),
                          pnv_chip_power9_pic_print_info_child, mon);
 }
@@ -862,9 +861,14 @@ static void pnv_ipmi_bt_init(ISABus *bus, IPMIBmc *bmc, uint32_t irq)
 static void pnv_chip_power10_pic_print_info(PnvChip *chip, Monitor *mon)
 {
     Pnv10Chip *chip10 = PNV10_CHIP(chip);
+    g_autoptr(GString) buf = g_string_new("");
+    g_autoptr(HumanReadableText) info = NULL;
 
     pnv_xive2_pic_print_info(&chip10->xive, mon);
-    pnv_psi_pic_print_info(&chip10->psi, mon);
+
+    pnv_psi_pic_print_info(&chip10->psi, buf);
+    info = human_readable_text_from_str(buf);
+    monitor_puts(mon, info->human_readable_text);
 
     object_child_foreach_recursive(OBJECT(chip),
                          pnv_chip_power9_pic_print_info_child, mon);
diff --git a/hw/ppc/pnv_psi.c b/hw/ppc/pnv_psi.c
index 922ac07b2f..18cc76a7e4 100644
--- a/hw/ppc/pnv_psi.c
+++ b/hw/ppc/pnv_psi.c
@@ -25,8 +25,6 @@
 #include "qemu/module.h"
 #include "sysemu/reset.h"
 #include "qapi/error.h"
-#include "qapi/type-helpers.h"
-#include "monitor/monitor.h"
 
 
 #include "hw/ppc/fdt.h"
@@ -978,11 +976,9 @@ static void pnv_psi_register_types(void)
 
 type_init(pnv_psi_register_types);
 
-void pnv_psi_pic_print_info(Pnv9Psi *psi9, Monitor *mon)
+void pnv_psi_pic_print_info(Pnv9Psi *psi9, GString *buf)
 {
     PnvPsi *psi = PNV_PSI(psi9);
-    g_autoptr(GString) buf = g_string_new("");
-    g_autoptr(HumanReadableText) info = NULL;
 
     uint32_t offset =
         (psi->regs[PSIHB_REG(PSIHB9_IVT_OFFSET)] >> PSIHB9_IVT_OFF_SHIFT);
@@ -990,7 +986,4 @@ void pnv_psi_pic_print_info(Pnv9Psi *psi9, Monitor *mon)
     g_string_append_printf(buf, "PSIHB Source %08x .. %08x\n",
                            offset, offset + psi9->source.nr_irqs - 1);
     xive_source_pic_print_info(&psi9->source, offset, buf);
-
-    info = human_readable_text_from_str(buf);
-    monitor_puts(mon, info->human_readable_text);
 }
-- 
2.41.0



  parent reply	other threads:[~2024-06-10  6:25 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  6:20 [PATCH 00/26] hw/ppc: Prefer HumanReadableText over Monitor Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 01/26] hw/ppc: Avoid using Monitor in pnv_phb3_msi_pic_print_info() Philippe Mathieu-Daudé
2024-06-17 10:11   ` Harsh Prateek Bora
2024-06-17 10:19     ` Harsh Prateek Bora
2024-06-17 10:29       ` Harsh Prateek Bora
2024-06-10  6:20 ` [PATCH 02/26] hw/ppc: Avoid using Monitor in icp_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 03/26] hw/ppc: Avoid using Monitor in xive_tctx_pic_print_info() Philippe Mathieu-Daudé
2024-06-17 10:19   ` Harsh Prateek Bora
2024-06-17 11:23     ` Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 04/26] hw/ppc: Avoid using Monitor in ics_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 05/26] hw/ppc: Avoid using Monitor in PnvChipClass::intc_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 06/26] hw/ppc: Avoid using Monitor in xive_end_queue_pic_print_info() Philippe Mathieu-Daudé
2024-06-17 12:35   ` Harsh Prateek Bora
2024-06-10  6:20 ` [PATCH 07/26] hw/ppc: Avoid using Monitor in spapr_xive_end_pic_print_info() Philippe Mathieu-Daudé
2024-06-17 12:39   ` Harsh Prateek Bora
2024-06-10  6:20 ` [PATCH 08/26] hw/ppc: Avoid using Monitor in spapr_xive_pic_print_info() Philippe Mathieu-Daudé
2024-06-17 12:50   ` Harsh Prateek Bora
2024-06-10  6:20 ` [PATCH 09/26] hw/ppc: Avoid using Monitor in xive_source_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 10/26] hw/ppc: Avoid using Monitor in pnv_phb4_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 11/26] hw/ppc: Avoid using Monitor in xive_eas_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 12/26] hw/ppc: Avoid using Monitor in xive_end_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 13/26] hw/ppc: Avoid using Monitor in xive_end_eas_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 14/26] hw/ppc: Avoid using Monitor in xive_nvt_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 15/26] hw/ppc: Avoid using Monitor in pnv_xive_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` Philippe Mathieu-Daudé [this message]
2024-06-10  6:20 ` [PATCH 17/26] hw/ppc: Avoid using Monitor in xive2_eas_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 18/26] hw/ppc: Avoid using Monitor in xive2_end_eas_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 19/26] hw/ppc: Avoid using Monitor in xive2_end_queue_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 20/26] hw/ppc: Avoid using Monitor in xive2_end_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:20 ` [PATCH 21/26] hw/ppc: Avoid using Monitor in xive2_nvp_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:21 ` [PATCH 22/26] hw/ppc: Avoid using Monitor in pnv_xive2_pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:21 ` [PATCH 23/26] hw/ppc: Avoid using Monitor in SpaprInterruptControllerClass::print_info() Philippe Mathieu-Daudé
2024-06-10  6:21 ` [PATCH 24/26] hw/ppc: Avoid using Monitor in spapr_irq_print_info() Philippe Mathieu-Daudé
2024-06-10  6:21 ` [PATCH 25/26] hw/ppc: Avoid using Monitor in pnv_chip_power9_pic_print_info_child() Philippe Mathieu-Daudé
2024-06-10  6:21 ` [PATCH 26/26] hw/ppc: Avoid using Monitor in pic_print_info() Philippe Mathieu-Daudé
2024-06-10  6:24 ` [PATCH 00/26] hw/ppc: Prefer HumanReadableText over Monitor Philippe Mathieu-Daudé
2024-06-10  8:16 ` Cédric Le Goater
2024-06-10  8:19 ` Cédric Le Goater
2024-06-13  9:48   ` Philippe Mathieu-Daudé
2024-06-13 10:29     ` Cédric Le Goater
2024-06-13 12:26       ` Philippe Mathieu-Daudé
2024-06-12  5:48 ` Manos Pitsidianakis
2024-06-13 12:44 ` Cédric Le Goater
2024-06-13 13:31   ` Philippe Mathieu-Daudé
2024-06-13 13:36     ` Cédric Le Goater
2024-06-17 13:30 ` Harsh Prateek Bora
2024-06-18 10:43 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240610062105.49848-17-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=berrange@redhat.com \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=fbarrat@linux.ibm.com \
    --cc=harshpb@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).