From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Markus Armbruster" <armbru@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Dr. David Alan Gilbert" <dave@treblig.org>,
qemu-devel@nongnu.org
Cc: "Yanan Wang" <wangyanan55@huawei.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Eric Farman" <farman@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
qemu-s390x@nongnu.org, "Eduardo Habkost" <eduardo@habkost.net>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"David Hildenbrand" <david@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [RFC PATCH 0/3] monitor: Pass HMP arguments to QMP HumanReadableText API as JSON
Date: Mon, 10 Jun 2024 19:58:49 +0200 [thread overview]
Message-ID: <20240610175852.21215-1-philmd@linaro.org> (raw)
Current HMPCommand::cmd_info_hrt() handlers don't allow
passing arguments from the monitor. This series pass them
to the underlying QMP commands as a JSON dictionary,
easily deserialized as QDict, similarly to how current
HMP commands receive their arguments. Thus very few
changes are required to port to the new API. As an
example, the @x-query-s390x-cmma command is ported.
Based-on: <20240610063518.50680-1-philmd@linaro.org>
Philippe Mathieu-Daudé (3):
hw/s390x: Declare target specific monitor commands in hmp-target.h
monitor: Allow passing HMP arguments to QMP HumanReadableText API
hw/s390x: Introduce x-query-s390x-cmma QMP command
docs/devel/writing-monitor-commands.rst | 15 ++++++++-
qapi/machine.json | 44 +++++++++++++++++++++++++
include/hw/s390x/storage-attributes.h | 4 ---
include/hw/s390x/storage-keys.h | 4 ---
include/monitor/hmp-target.h | 5 +++
include/monitor/monitor.h | 3 +-
monitor/monitor-internal.h | 2 +-
accel/tcg/monitor.c | 4 +--
hw/core/loader.c | 2 +-
hw/core/machine-qmp-cmds.c | 9 ++---
hw/s390x/s390-skeys.c | 2 ++
hw/s390x/s390-stattrib.c | 30 +++++++++++------
hw/usb/bus.c | 2 +-
monitor/hmp-target.c | 8 ++---
monitor/hmp.c | 11 ++++---
hmp-commands-info.hx | 2 +-
16 files changed, 107 insertions(+), 40 deletions(-)
--
2.41.0
next reply other threads:[~2024-06-10 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 17:58 Philippe Mathieu-Daudé [this message]
2024-06-10 17:58 ` [PATCH 1/3] hw/s390x: Declare target specific monitor commands in hmp-target.h Philippe Mathieu-Daudé
2024-06-10 21:02 ` Dr. David Alan Gilbert
2024-06-10 17:58 ` [RFC PATCH 2/3] monitor: Allow passing HMP arguments to QMP HumanReadableText API Philippe Mathieu-Daudé
2024-06-10 18:26 ` Daniel P. Berrangé
2024-06-10 17:58 ` [RFC PATCH 3/3] hw/s390x: Introduce x-query-s390x-cmma QMP command Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610175852.21215-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=dave@treblig.org \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=farman@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).