qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Pankaj Gupta <pankaj.gupta@amd.com>
Subject: [PULL 04/25] i386/sev: Move SEV_COMMON null check before dereferencing
Date: Tue, 11 Jun 2024 16:25:02 +0200	[thread overview]
Message-ID: <20240611142524.83762-5-pbonzini@redhat.com> (raw)
In-Reply-To: <20240611142524.83762-1-pbonzini@redhat.com>

From: Pankaj Gupta <pankaj.gupta@amd.com>

Fixes Coverity CID 1546886.

Fixes: 9861405a8f ("i386/sev: Invoke launch_updata_data() for SEV class")
Signed-off-by: Pankaj Gupta <pankaj.gupta@amd.com>
Message-ID: <20240607183611.1111100-3-pankaj.gupta@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target/i386/sev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/i386/sev.c b/target/i386/sev.c
index 7c9df621de1..f18432f58e2 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -1529,11 +1529,12 @@ int
 sev_encrypt_flash(hwaddr gpa, uint8_t *ptr, uint64_t len, Error **errp)
 {
     SevCommonState *sev_common = SEV_COMMON(MACHINE(qdev_get_machine())->cgs);
-    SevCommonStateClass *klass = SEV_COMMON_GET_CLASS(sev_common);
+    SevCommonStateClass *klass;
 
     if (!sev_common) {
         return 0;
     }
+    klass = SEV_COMMON_GET_CLASS(sev_common);
 
     /* if SEV is in update state then encrypt the data else do nothing */
     if (sev_check_state(sev_common, SEV_STATE_LAUNCH_UPDATE)) {
-- 
2.45.1



  parent reply	other threads:[~2024-06-11 14:27 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 14:24 [PULL 00/25] target/i386, SCSI changes for 2024-06-11 Paolo Bonzini
2024-06-11 14:24 ` [PULL 01/25] scsi-disk: Fix crash for VM configured with USB CDROM after live migration Paolo Bonzini
2024-06-11 14:25 ` [PULL 02/25] i386/cpu: fixup number of addressable IDs for processor cores in the physical package Paolo Bonzini
2024-06-11 14:25 ` [PULL 03/25] i386/sev: fix unreachable code coverity issue Paolo Bonzini
2024-06-11 14:25 ` Paolo Bonzini [this message]
2024-06-11 14:25 ` [PULL 05/25] i386/sev: Return when sev_common is null Paolo Bonzini
2024-06-11 14:25 ` [PULL 06/25] target/i386: remove CPUX86State argument from generator functions Paolo Bonzini
2024-06-11 14:25 ` [PULL 07/25] target/i386: rewrite flags writeback for ADCX/ADOX Paolo Bonzini
2024-06-11 14:25 ` [PULL 08/25] target/i386: put BLS* input in T1, use generic flag writeback Paolo Bonzini
2024-06-11 14:25 ` [PULL 09/25] target/i386: change X86_ENTRYr to use T0 Paolo Bonzini
2024-06-11 14:25 ` [PULL 10/25] target/i386: change X86_ENTRYwr to use T0, use it for moves Paolo Bonzini
2024-06-11 14:25 ` [PULL 11/25] target/i386: replace NoSeg special with NoLoadEA Paolo Bonzini
2024-06-11 14:25 ` [PULL 12/25] target/i386: fix processing of intercept 0 (read CR0) Paolo Bonzini
2024-06-11 14:25 ` [PULL 13/25] target/i386: convert MOV from/to CR and DR to new decoder Paolo Bonzini
2024-06-11 14:25 ` [PULL 14/25] target/i386: fix bad sorting of entries in the 0F table Paolo Bonzini
2024-06-11 14:25 ` [PULL 15/25] target/i386: finish converting 0F AE to the new decoder Paolo Bonzini
2024-06-11 14:25 ` [PULL 16/25] target/i386: replace read_crN helper with read_cr8 Paolo Bonzini
2024-06-11 14:25 ` [PULL 17/25] target/i386: split X86_CHECK_prot into PE and VM86 checks Paolo Bonzini
2024-06-11 14:25 ` [PULL 18/25] target/i386: convert non-grouped, helper-based 2-byte opcodes Paolo Bonzini
2024-06-11 14:25 ` [PULL 19/25] target/i386: pull load/writeback out of gen_shiftd_rm_T1 Paolo Bonzini
2024-06-11 14:25 ` [PULL 20/25] target/i386: adapt gen_shift_count for SHLD/SHRD Paolo Bonzini
2024-06-11 14:25 ` [PULL 21/25] target/i386: convert SHLD/SHRD to new decoder Paolo Bonzini
2024-06-11 14:25 ` [PULL 22/25] target/i386: convert LZCNT/TZCNT/BSF/BSR/POPCNT " Paolo Bonzini
2024-06-11 14:25 ` [PULL 23/25] target/i386: convert XADD " Paolo Bonzini
2024-06-11 14:25 ` [PULL 24/25] target/i386: convert CMPXCHG " Paolo Bonzini
2024-06-11 14:25 ` [PULL 25/25] target/i386: SEV: do not assume machine->cgs is SEV Paolo Bonzini
2024-06-13  5:29 ` [PULL 00/25] target/i386, SCSI changes for 2024-06-11 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240611142524.83762-5-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=pankaj.gupta@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).