From: Alexander Monakov <amonakov@ispras.ru>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Alexander Monakov <amonakov@ispras.ru>
Subject: [PATCH 2/5] Revert "host/i386: assume presence of SSSE3"
Date: Wed, 12 Jun 2024 13:55:22 +0300 [thread overview]
Message-ID: <20240612105525.8795-3-amonakov@ispras.ru> (raw)
In-Reply-To: <20240612105525.8795-1-amonakov@ispras.ru>
This reverts commit 433cd6d94a8256af70a5200f236dc8047c3c1468.
Revert in preparation to rolling back x86_64-v2 ISA requirement.
Signed-off-by: Alexander Monakov <amonakov@ispras.ru>
---
util/cpuinfo-i386.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/cpuinfo-i386.c b/util/cpuinfo-i386.c
index 6d474a62..ca74ef04 100644
--- a/util/cpuinfo-i386.c
+++ b/util/cpuinfo-i386.c
@@ -38,8 +38,8 @@ unsigned __attribute__((constructor)) cpuinfo_init(void)
info |= (c & bit_POPCNT ? CPUINFO_POPCNT : 0);
info |= (c & bit_PCLMUL ? CPUINFO_PCLMUL : 0);
- /* NOTE: our AES support requires SSSE3 (PSHUFB) as well. */
- info |= (c & bit_AES) ? CPUINFO_AES : 0;
+ /* Our AES support requires PSHUFB as well. */
+ info |= ((c & bit_AES) && (c & bit_SSSE3) ? CPUINFO_AES : 0);
/* For AVX features, we must check available and usable. */
if ((c & bit_AVX) && (c & bit_OSXSAVE)) {
--
2.32.0
next prev parent reply other threads:[~2024-06-12 10:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 10:55 [PATCH 0/5] Reinstate ability to use Qemu on pre-SSE4.1 x86 hosts Alexander Monakov
2024-06-12 10:55 ` [PATCH 1/5] Revert "host/i386: assume presence of POPCNT" Alexander Monakov
2024-06-12 10:55 ` Alexander Monakov [this message]
2024-06-12 10:55 ` [PATCH 3/5] Revert "host/i386: assume presence of SSE2" Alexander Monakov
2024-06-12 10:55 ` [PATCH 4/5] Revert "host/i386: assume presence of CMOV" Alexander Monakov
2024-06-12 10:55 ` [PATCH 5/5] Revert "meson: assume x86-64-v2 baseline ISA" Alexander Monakov
2024-06-12 11:04 ` [PATCH 0/5] Reinstate ability to use Qemu on pre-SSE4.1 x86 hosts Daniel P. Berrangé
2024-06-12 11:12 ` Paolo Bonzini
2024-06-12 11:19 ` Alexander Monakov
2024-06-12 11:29 ` Paolo Bonzini
2024-06-12 11:46 ` Alexander Monakov
2024-06-12 11:58 ` Paolo Bonzini
2024-06-12 12:10 ` Alexander Monakov
2024-06-12 12:13 ` Paolo Bonzini
2024-06-12 13:34 ` Alexander Monakov
2024-06-12 13:39 ` Paolo Bonzini
2024-06-12 14:27 ` Alexander Monakov
2024-06-12 11:38 ` Daniel P. Berrangé
2024-06-12 11:51 ` Paolo Bonzini
2024-06-12 12:21 ` Daniel P. Berrangé
2024-06-12 15:09 ` Daniel P. Berrangé
2024-06-12 15:29 ` Paolo Bonzini
2024-06-12 15:40 ` Alexander Monakov
2024-06-12 16:24 ` Daniel P. Berrangé
2024-06-12 17:06 ` Daniel P. Berrangé
2024-06-12 17:00 ` Daniel P. Berrangé
2024-06-12 17:08 ` Paolo Bonzini
2024-06-23 21:27 ` Alexander Monakov
2024-06-23 22:14 ` Richard Henderson
2024-06-12 11:14 ` Alexander Monakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612105525.8795-3-amonakov@ispras.ru \
--to=amonakov@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).