From: Stefano Garzarella <sgarzare@redhat.com>
To: mst@redhat.com, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Hanna Reitz" <hreitz@redhat.com>,
"Brad Smith" <brad@comstyle.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
gmaglione@redhat.com, stefanha@redhat.com,
"Coiby Xu" <Coiby.Xu@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
slp@redhat.com, "Igor Mammedov" <imammedo@redhat.com>,
"Raphael Norwitz" <raphael@enfabrica.net>,
"Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"David Hildenbrand" <david@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Jason Wang" <jasowang@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>
Subject: [PATCH RESEND v7 02/12] libvhost-user: fail vu_message_write() if sendmsg() is failing
Date: Wed, 12 Jun 2024 15:01:30 +0200 [thread overview]
Message-ID: <20240612130140.63004-3-sgarzare@redhat.com> (raw)
In-Reply-To: <20240612130140.63004-1-sgarzare@redhat.com>
In vu_message_write() we use sendmsg() to send the message header,
then a write() to send the payload.
If sendmsg() fails we should avoid sending the payload, since we
were unable to send the header.
Discovered before fixing the issue with the previous patch, where
sendmsg() failed on macOS due to wrong parameters, but the frontend
still sent the payload which the backend incorrectly interpreted
as a wrong header.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
subprojects/libvhost-user/libvhost-user.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/subprojects/libvhost-user/libvhost-user.c b/subprojects/libvhost-user/libvhost-user.c
index 22bea0c775..a11afd1960 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -639,6 +639,11 @@ vu_message_write(VuDev *dev, int conn_fd, VhostUserMsg *vmsg)
rc = sendmsg(conn_fd, &msg, 0);
} while (rc < 0 && (errno == EINTR || errno == EAGAIN));
+ if (rc <= 0) {
+ vu_panic(dev, "Error while writing: %s", strerror(errno));
+ return false;
+ }
+
if (vmsg->size) {
do {
if (vmsg->data) {
--
2.45.2
next prev parent reply other threads:[~2024-06-12 13:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 13:01 [PATCH RESEND v7 00/12] vhost-user: support any POSIX system (tested on macOS, FreeBSD, OpenBSD) Stefano Garzarella
2024-06-12 13:01 ` [PATCH RESEND v7 01/12] libvhost-user: set msg.msg_control to NULL when it is empty Stefano Garzarella
2024-06-12 13:01 ` Stefano Garzarella [this message]
2024-06-12 13:01 ` [PATCH RESEND v7 03/12] libvhost-user: mask F_INFLIGHT_SHMFD if memfd is not supported Stefano Garzarella
2024-06-12 13:01 ` [PATCH RESEND v7 04/12] vhost-user-server: do not set memory fd non-blocking Stefano Garzarella
2024-06-12 13:01 ` [PATCH RESEND v7 05/12] contrib/vhost-user-blk: fix bind() using the right size of the address Stefano Garzarella
2024-06-12 13:01 ` [PATCH RESEND v7 06/12] contrib/vhost-user-*: use QEMU bswap helper functions Stefano Garzarella
2024-06-12 13:01 ` [PATCH RESEND v7 07/12] vhost-user: enable frontends on any POSIX system Stefano Garzarella
2024-06-12 13:01 ` [PATCH RESEND v7 08/12] libvhost-user: enable it " Stefano Garzarella
2024-06-12 13:01 ` [PATCH RESEND v7 09/12] contrib/vhost-user-blk: " Stefano Garzarella
2024-06-12 13:01 ` [PATCH RESEND v7 10/12] hostmem: add a new memory backend based on POSIX shm_open() Stefano Garzarella
2024-06-12 13:20 ` Markus Armbruster
2024-06-13 11:31 ` Stefano Garzarella
2024-06-12 13:01 ` [PATCH RESEND v7 11/12] tests/qtest/vhost-user-blk-test: use memory-backend-shm Stefano Garzarella
2024-06-12 13:01 ` [PATCH RESEND v7 12/12] tests/qtest/vhost-user-test: add a test case for memory-backend-shm Stefano Garzarella
2024-06-17 10:35 ` [PATCH RESEND v7 00/12] vhost-user: support any POSIX system (tested on macOS, FreeBSD, OpenBSD) Stefano Garzarella
2024-06-17 12:02 ` Markus Armbruster
2024-06-17 12:59 ` Stefano Garzarella
2024-06-17 13:42 ` Michael S. Tsirkin
2024-06-17 14:36 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612130140.63004-3-sgarzare@redhat.com \
--to=sgarzare@redhat.com \
--cc=Coiby.Xu@gmail.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=brad@comstyle.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=gmaglione@redhat.com \
--cc=hreitz@redhat.com \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael@enfabrica.net \
--cc=slp@redhat.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).