From: "Fea.Wang" <fea.wang@sifive.com>
To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Alistair Francis <alistair@alistair23.me>,
Peter Maydell <peter.maydell@linaro.org>,
Jason Wang <jasowang@redhat.com>,
qemu-arm@nongnu.org (open list:Xilinx Zynq),
"Fea.Wang" <fea.wang@sifive.com>,
"Edgar E . Iglesias" <edgar.iglesias@amd.com>,
Frank Chang <frank.chang@sifive.com>
Subject: [PATCH v3 2/3] hw/dma: Add a trace log for a description loading failure
Date: Thu, 13 Jun 2024 09:35:00 +0800 [thread overview]
Message-ID: <20240613013501.426905-3-fea.wang@sifive.com> (raw)
In-Reply-To: <20240613013501.426905-1-fea.wang@sifive.com>
Due to a description loading failure, adding a trace log makes observing
the DMA behavior easy.
Signed-off-by: Fea.Wang <fea.wang@sifive.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Reviewed-by: Frank Chang <frank.chang@sifive.com>
---
hw/dma/trace-events | 3 +++
hw/dma/xilinx_axidma.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/hw/dma/trace-events b/hw/dma/trace-events
index 3c47df54e4..4c09790f9a 100644
--- a/hw/dma/trace-events
+++ b/hw/dma/trace-events
@@ -44,3 +44,6 @@ pl330_debug_exec_stall(void) "stall of debug instruction not implemented"
pl330_iomem_write(uint32_t offset, uint32_t value) "addr: 0x%08"PRIx32" data: 0x%08"PRIx32
pl330_iomem_write_clr(int i) "event interrupt lowered %d"
pl330_iomem_read(uint32_t addr, uint32_t data) "addr: 0x%08"PRIx32" data: 0x%08"PRIx32
+
+# xilinx_axidma.c
+xilinx_axidma_loading_desc_fail(uint32_t res) "error:%u"
diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
index ad307994c2..c9cfc3169b 100644
--- a/hw/dma/xilinx_axidma.c
+++ b/hw/dma/xilinx_axidma.c
@@ -36,6 +36,7 @@
#include "sysemu/dma.h"
#include "hw/stream.h"
#include "qom/object.h"
+#include "trace.h"
#define D(x)
@@ -201,6 +202,8 @@ static MemTxResult stream_desc_load(struct Stream *s, hwaddr addr)
addr, MEMTXATTRS_UNSPECIFIED,
d, sizeof *d);
if (result != MEMTX_OK) {
+ trace_xilinx_axidma_loading_desc_fail(result);
+
if (result == MEMTX_DECODE_ERROR) {
s->regs[R_DMASR] |= DMASR_DECERR;
} else {
--
2.34.1
next prev parent reply other threads:[~2024-06-13 1:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 1:34 [PATCH v3 0/3] hw/dma: Add error handling for loading descriptions failing Fea.Wang
2024-06-13 1:34 ` [PATCH v3 1/3] hw/dma: Enhance error handling in loading description Fea.Wang
2024-06-13 1:35 ` Fea.Wang [this message]
2024-06-18 10:54 ` [PATCH v3 2/3] hw/dma: Add a trace log for a description loading failure Philippe Mathieu-Daudé
2024-06-13 1:35 ` [PATCH v3 3/3] hw/net: Fix the transmission return size Fea.Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613013501.426905-3-fea.wang@sifive.com \
--to=fea.wang@sifive.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@amd.com \
--cc=edgar.iglesias@gmail.com \
--cc=frank.chang@sifive.com \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).