* [PATCH v2] hw/misc: Set valid access size for Exynos4210 RNG
@ 2024-06-18 15:51 Zheyu Ma
2024-06-18 15:58 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Zheyu Ma @ 2024-06-18 15:51 UTC (permalink / raw)
To: Igor Mitsyanko, Peter Maydell; +Cc: Zheyu Ma, qemu-arm, qemu-devel
This commit ensures that accesses to the RNG memory region are properly
validated and align with expected access sizes.
Reproducer:
cat << EOF | qemu-system-aarch64 -display none \
-machine accel=qtest, -m 512M -machine smdkc210 -qtest stdio
readb 0x10830454
EOF
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
---
hw/misc/exynos4210_rng.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/misc/exynos4210_rng.c b/hw/misc/exynos4210_rng.c
index 0756bd3205..674d8eece5 100644
--- a/hw/misc/exynos4210_rng.c
+++ b/hw/misc/exynos4210_rng.c
@@ -217,6 +217,8 @@ static const MemoryRegionOps exynos4210_rng_ops = {
.read = exynos4210_rng_read,
.write = exynos4210_rng_write,
.endianness = DEVICE_NATIVE_ENDIAN,
+ .valid.min_access_size = 4,
+ .valid.max_access_size = 4,
};
static void exynos4210_rng_reset(DeviceState *dev)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] hw/misc: Set valid access size for Exynos4210 RNG
2024-06-18 15:51 [PATCH v2] hw/misc: Set valid access size for Exynos4210 RNG Zheyu Ma
@ 2024-06-18 15:58 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-06-18 15:58 UTC (permalink / raw)
To: Zheyu Ma, Igor Mitsyanko, Peter Maydell; +Cc: qemu-arm, qemu-devel
On 18/6/24 17:51, Zheyu Ma wrote:
> This commit ensures that accesses to the RNG memory region are properly
> validated and align with expected access sizes.
Please point to the device specifications.
> Reproducer:
> cat << EOF | qemu-system-aarch64 -display none \
> -machine accel=qtest, -m 512M -machine smdkc210 -qtest stdio
> readb 0x10830454
> EOF
>
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> ---
> hw/misc/exynos4210_rng.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/misc/exynos4210_rng.c b/hw/misc/exynos4210_rng.c
> index 0756bd3205..674d8eece5 100644
> --- a/hw/misc/exynos4210_rng.c
> +++ b/hw/misc/exynos4210_rng.c
> @@ -217,6 +217,8 @@ static const MemoryRegionOps exynos4210_rng_ops = {
> .read = exynos4210_rng_read,
> .write = exynos4210_rng_write,
> .endianness = DEVICE_NATIVE_ENDIAN,
> + .valid.min_access_size = 4,
> + .valid.max_access_size = 4,
> };
>
> static void exynos4210_rng_reset(DeviceState *dev)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-18 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-18 15:51 [PATCH v2] hw/misc: Set valid access size for Exynos4210 RNG Zheyu Ma
2024-06-18 15:58 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).