From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Song Gao" <gaosong@loongson.cn>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 65/76] hw/mips/loongson3_virt: Wire up loongson_ipi device
Date: Tue, 18 Jun 2024 18:00:27 +0200 [thread overview]
Message-ID: <20240618160039.36108-66-philmd@linaro.org> (raw)
In-Reply-To: <20240618160039.36108-1-philmd@linaro.org>
From: Jiaxun Yang <jiaxun.yang@flygoat.com>
Wire up loongson_ipi device for loongson3_virt machine, so we
can have SMP support for TCG backend as well.
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Acked-by: Song Gao <gaosong@loongson.cn>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240605-loongson3-ipi-v3-3-ddd2c0e03fa3@flygoat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/mips/loongson3_bootp.h | 3 +++
hw/mips/loongson3_bootp.c | 2 --
hw/mips/loongson3_virt.c | 39 +++++++++++++++++++++++++++++++++++++--
hw/mips/Kconfig | 1 +
4 files changed, 41 insertions(+), 4 deletions(-)
diff --git a/hw/mips/loongson3_bootp.h b/hw/mips/loongson3_bootp.h
index 1b0dd3b591..9091265df7 100644
--- a/hw/mips/loongson3_bootp.h
+++ b/hw/mips/loongson3_bootp.h
@@ -200,6 +200,8 @@ struct boot_params {
struct efi_reset_system_t reset_system;
};
+#define LOONGSON3_CORE_PER_NODE 4
+
/* Overall MMIO & Memory layout */
enum {
VIRT_LOWMEM,
@@ -211,6 +213,7 @@ enum {
VIRT_BIOS_ROM,
VIRT_UART,
VIRT_LIOINTC,
+ VIRT_IPI,
VIRT_PCIE_MMIO,
VIRT_HIGHMEM
};
diff --git a/hw/mips/loongson3_bootp.c b/hw/mips/loongson3_bootp.c
index 03a10b63c1..b97b81903b 100644
--- a/hw/mips/loongson3_bootp.c
+++ b/hw/mips/loongson3_bootp.c
@@ -25,8 +25,6 @@
#include "hw/boards.h"
#include "hw/mips/loongson3_bootp.h"
-#define LOONGSON3_CORE_PER_NODE 4
-
static void init_cpu_info(void *g_cpuinfo, uint64_t cpu_freq)
{
struct efi_cpuinfo_loongson *c = g_cpuinfo;
diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c
index 440268a074..4ad36f0c5b 100644
--- a/hw/mips/loongson3_virt.c
+++ b/hw/mips/loongson3_virt.c
@@ -36,6 +36,7 @@
#include "hw/mips/loongson3_bootp.h"
#include "hw/misc/unimp.h"
#include "hw/intc/i8259.h"
+#include "hw/intc/loongson_ipi.h"
#include "hw/loader.h"
#include "hw/isa/superio.h"
#include "hw/pci/msi.h"
@@ -74,6 +75,7 @@ const MemMapEntry virt_memmap[] = {
[VIRT_PCIE_ECAM] = { 0x1a000000, 0x2000000 },
[VIRT_BIOS_ROM] = { 0x1fc00000, 0x200000 },
[VIRT_UART] = { 0x1fe001e0, 0x8 },
+ [VIRT_IPI] = { 0x3ff01000, 0x400 },
[VIRT_LIOINTC] = { 0x3ff01400, 0x64 },
[VIRT_PCIE_MMIO] = { 0x40000000, 0x40000000 },
[VIRT_HIGHMEM] = { 0x80000000, 0x0 }, /* Variable */
@@ -485,6 +487,7 @@ static void mips_loongson3_virt_init(MachineState *machine)
Clock *cpuclk;
CPUMIPSState *env;
DeviceState *liointc;
+ DeviceState *ipi = NULL;
char *filename;
const char *kernel_cmdline = machine->kernel_cmdline;
const char *kernel_filename = machine->kernel_filename;
@@ -494,6 +497,7 @@ static void mips_loongson3_virt_init(MachineState *machine)
MemoryRegion *ram = g_new(MemoryRegion, 1);
MemoryRegion *bios = g_new(MemoryRegion, 1);
MemoryRegion *iomem = g_new(MemoryRegion, 1);
+ MemoryRegion *iocsr = g_new(MemoryRegion, 1);
/* TODO: TCG will support all CPU types */
if (!kvm_enabled()) {
@@ -527,6 +531,19 @@ static void mips_loongson3_virt_init(MachineState *machine)
create_unimplemented_device("mmio fallback 0", 0x10000000, 256 * MiB);
create_unimplemented_device("mmio fallback 1", 0x30000000, 256 * MiB);
+ memory_region_init(iocsr, OBJECT(machine), "loongson3.iocsr", UINT32_MAX);
+
+ /* IPI controller is in kernel for KVM */
+ if (!kvm_enabled()) {
+ ipi = qdev_new(TYPE_LOONGSON_IPI);
+ qdev_prop_set_uint32(ipi, "num-cpu", machine->smp.cpus);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(ipi), &error_fatal);
+ memory_region_add_subregion(iocsr, SMP_IPI_MAILBOX,
+ sysbus_mmio_get_region(SYS_BUS_DEVICE(ipi), 0));
+ memory_region_add_subregion(iocsr, MAIL_SEND_ADDR,
+ sysbus_mmio_get_region(SYS_BUS_DEVICE(ipi), 1));
+ }
+
liointc = qdev_new("loongson.liointc");
sysbus_realize_and_unref(SYS_BUS_DEVICE(liointc), &error_fatal);
@@ -543,6 +560,8 @@ static void mips_loongson3_virt_init(MachineState *machine)
clock_set_hz(cpuclk, DEF_LOONGSON3_FREQ);
for (i = 0; i < machine->smp.cpus; i++) {
+ int node = i / LOONGSON3_CORE_PER_NODE;
+ int core = i % LOONGSON3_CORE_PER_NODE;
int ip;
/* init CPUs */
@@ -553,12 +572,28 @@ static void mips_loongson3_virt_init(MachineState *machine)
cpu_mips_clock_init(cpu);
qemu_register_reset(main_cpu_reset, cpu);
- if (i >= 4) {
+ if (ipi) {
+ hwaddr base = ((hwaddr)node << 44) + virt_memmap[VIRT_IPI].base;
+ base += core * 0x100;
+ qdev_connect_gpio_out(ipi, i, cpu->env.irq[6]);
+ sysbus_mmio_map(SYS_BUS_DEVICE(ipi), i + 2, base);
+ }
+
+ if (ase_lcsr_available(&MIPS_CPU(cpu)->env)) {
+ MemoryRegion *core_iocsr = g_new(MemoryRegion, 1);
+ g_autofree char *name = g_strdup_printf("core%d_iocsr", i);
+ memory_region_init_alias(core_iocsr, OBJECT(cpu), name,
+ iocsr, 0, UINT32_MAX);
+ memory_region_add_subregion(&MIPS_CPU(cpu)->env.iocsr.mr,
+ 0, core_iocsr);
+ }
+
+ if (node > 0) {
continue; /* Only node-0 can be connected to LIOINTC */
}
for (ip = 0; ip < 4 ; ip++) {
- int pin = i * 4 + ip;
+ int pin = core * LOONGSON3_CORE_PER_NODE + ip;
sysbus_connect_irq(SYS_BUS_DEVICE(liointc),
pin, cpu->env.irq[ip + 2]);
}
diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
index a7f26edebe..692bede538 100644
--- a/hw/mips/Kconfig
+++ b/hw/mips/Kconfig
@@ -67,6 +67,7 @@ config LOONGSON3V
imply USB_OHCI_PCI
select SERIAL
select GOLDFISH_RTC
+ select LOONGSON_IPI
select LOONGSON_LIOINTC
select PCI_EXPRESS_GENERIC_BRIDGE
select MSI_NONBROKEN
--
2.41.0
next prev parent reply other threads:[~2024-06-18 16:10 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 15:59 [PULL 00/76] Misc patches for 2024-06-18 Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 01/76] hw/i386/pc: Deprecate 2.4 to 2.12 pc-i440fx machines Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 02/76] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 03/76] hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 04/76] hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 05/76] hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 06/76] hw/acpi/ich9: Remove 'memory-hotplug-support' property Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 07/76] hw/acpi/ich9: Remove dead code related to 'acpi_memory_hotplug' Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 08/76] hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 09/76] target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h' Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 10/76] hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 11/76] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 12/76] hw/smbios: Remove 'smbios_uuid_encoded', simplify smbios_encode_uuid() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 13/76] hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 14/76] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 15/76] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 16/76] hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 17/76] hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 18/76] hw/i386/pc: Remove PCMachineClass::rsdp_in_ram Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 19/76] hw/i386/acpi: Remove AcpiBuildState::rsdp field Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 20/76] hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 21/76] hw/i386/pc: Simplify DEFINE_I440FX_MACHINE() macro Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 22/76] target/i386: Remove X86CPU::kvm_no_smi_migration field Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 23/76] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 24/76] hw/audio/virtio-snd: Always use little endian audio format Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 25/76] hw/ppc: Avoid using Monitor in pnv_phb3_msi_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 26/76] hw/ppc: Avoid using Monitor in icp_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 27/76] hw/ppc: Avoid using Monitor in xive_tctx_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 28/76] hw/ppc: Avoid using Monitor in ics_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 29/76] hw/ppc: Avoid using Monitor in PnvChipClass::intc_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 30/76] hw/ppc: Avoid using Monitor in xive_end_queue_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 31/76] hw/ppc: Avoid using Monitor in spapr_xive_end_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 32/76] hw/ppc: Avoid using Monitor in spapr_xive_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 33/76] hw/ppc: Avoid using Monitor in xive_source_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 34/76] hw/ppc: Avoid using Monitor in pnv_phb4_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 35/76] hw/ppc: Avoid using Monitor in xive_eas_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 36/76] hw/ppc: Avoid using Monitor in xive_end_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 15:59 ` [PULL 37/76] hw/ppc: Avoid using Monitor in xive_end_eas_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 38/76] hw/ppc: Avoid using Monitor in xive_nvt_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 39/76] hw/ppc: Avoid using Monitor in pnv_xive_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 40/76] hw/ppc: Avoid using Monitor in pnv_psi_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 41/76] hw/ppc: Avoid using Monitor in xive2_eas_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 42/76] hw/ppc: Avoid using Monitor in xive2_end_eas_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 43/76] hw/ppc: Avoid using Monitor in xive2_end_queue_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 44/76] hw/ppc: Avoid using Monitor in xive2_end_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 45/76] hw/ppc: Avoid using Monitor in xive2_nvp_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 46/76] hw/ppc: Avoid using Monitor in pnv_xive2_pic_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 47/76] hw/ppc: Avoid using Monitor in SpaprInterruptControllerClass::print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 48/76] hw/ppc: Avoid using Monitor in spapr_irq_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 49/76] hw/ppc: Avoid using Monitor in pnv_chip_power9_pic_print_info_child() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 50/76] hw/ppc: Avoid using Monitor in pic_print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 51/76] hw/intc: Avoid using Monitor in INTERRUPT_STATS_PROVIDER::print_info() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 52/76] hw/intc: Introduce x-query-interrupt-controllers QMP command Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 53/76] ppc/pnv: Introduce pnv_chip_foreach_cpu() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 54/76] target/arm: Set arm_v7m_tcg_ops cpu_exec_halt to arm_cpu_exec_halt() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 55/76] target: Set TCGCPUOps::cpu_exec_halt to target's has_work implementation Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 56/76] accel/tcg: Make TCGCPUOps::cpu_exec_halt mandatory Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 57/76] memory: Constify IOMMUTLBEvent in memory_region_notify_iommu_one() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 58/76] memory: Constify IOMMUTLBEvent in memory_region_notify_iommu() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 59/76] hw/i386/iommu: Constify IOMMUTLBEvent in vtd_page_walk_hook prototype Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 60/76] hw/usb: Remove unused 'host.h' header Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 61/76] hw/usb/dev-mtp: Correctly report free space Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 62/76] hw/intc: Remove loongarch_ipi.c Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 63/76] hw/intc/loongson_ipi: Provide per core MMIO address spaces Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 64/76] hw/intc/loongson_ipi: Replace ipi_getcpu with cpu_by_arch_id Philippe Mathieu-Daudé
2024-06-18 16:00 ` Philippe Mathieu-Daudé [this message]
2024-06-20 19:50 ` [PULL 65/76] hw/mips/loongson3_virt: Wire up loongson_ipi device Philippe Mathieu-Daudé
2024-06-20 20:49 ` Jiaxun Yang
2024-06-18 16:00 ` [PULL 66/76] hw/s390x: Introduce s390_skeys_get|set() helpers Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 67/76] target/s390x: Use s390_skeys_get|set() helper Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 68/76] util/readline: Fix lints for readline_handle_byte Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 69/76] util/readline: Add C-n, C-p shortcuts Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 70/76] util/readline: Add C-u shortcut Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 71/76] MAINTAINERS: drop virtio-gpu maintainership Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 72/76] MAINTAINERS: drop spice+ui maintainership Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 73/76] ui/cocoa: Use qemu_add_mouse_change_notifier Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 74/76] stdvga: fix screen blanking Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 75/76] ui+display: rename is_placeholder() -> surface_is_placeholder() Philippe Mathieu-Daudé
2024-06-18 16:00 ` [PULL 76/76] ui+display: rename is_buffer_shared() -> surface_is_allocated() Philippe Mathieu-Daudé
2024-06-18 20:06 ` [PULL 00/76] Misc patches for 2024-06-18 Richard Henderson
2024-06-18 20:15 ` Philippe Mathieu-Daudé
2024-06-18 20:32 ` Richard Henderson
2024-06-19 10:44 ` Philippe Mathieu-Daudé
2024-06-19 13:27 ` Peter Maydell
2024-07-04 15:54 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618160039.36108-66-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=gaosong@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).