* [PATCH] hw/net: Fix Coverity Issue for nocm-gmac
@ 2024-06-18 17:23 Nabih Estefan
2024-06-18 17:23 ` [PATCH] hw/net: Fix Coverity Issue for npcm-gmac Nabih Estefan
0 siblings, 1 reply; 3+ messages in thread
From: Nabih Estefan @ 2024-06-18 17:23 UTC (permalink / raw)
To: peter.maydell; +Cc: qemu-devel, kfting, wuhaotsh, jasowang, nabihestefan
There is an extra `buf=` set that is not used by npcm-gmac. Remove it
for coverity to be happy.
Signed-off-by: Nabih Estefan <nabihestefan@google.com>
---
hw/net/npcm_gmac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c
index 1b71e2526e..b397fd5064 100644
--- a/hw/net/npcm_gmac.c
+++ b/hw/net/npcm_gmac.c
@@ -614,7 +614,6 @@ static void gmac_try_send_next_packet(NPCMGMACState *gmac)
net_checksum_calculate(tx_send_buffer, length, csum);
qemu_send_packet(qemu_get_queue(gmac->nic), tx_send_buffer, length);
trace_npcm_gmac_packet_sent(DEVICE(gmac)->canonical_path, length);
- buf = tx_send_buffer;
length = 0;
}
--
2.45.2.627.g7a2c4fd464-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] hw/net: Fix Coverity Issue for npcm-gmac
2024-06-18 17:23 [PATCH] hw/net: Fix Coverity Issue for nocm-gmac Nabih Estefan
@ 2024-06-18 17:23 ` Nabih Estefan
0 siblings, 0 replies; 3+ messages in thread
From: Nabih Estefan @ 2024-06-18 17:23 UTC (permalink / raw)
To: peter.maydell; +Cc: qemu-devel, kfting, wuhaotsh, jasowang, nabihestefan
There is an extra `buf=` set that is not used by npcm-gmac. Remove it
for coverity to be happy.
Signed-off-by: Nabih Estefan <nabihestefan@google.com>
---
hw/net/npcm_gmac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c
index 1b71e2526e..b397fd5064 100644
--- a/hw/net/npcm_gmac.c
+++ b/hw/net/npcm_gmac.c
@@ -614,7 +614,6 @@ static void gmac_try_send_next_packet(NPCMGMACState *gmac)
net_checksum_calculate(tx_send_buffer, length, csum);
qemu_send_packet(qemu_get_queue(gmac->nic), tx_send_buffer, length);
trace_npcm_gmac_packet_sent(DEVICE(gmac)->canonical_path, length);
- buf = tx_send_buffer;
length = 0;
}
--
2.45.2.627.g7a2c4fd464-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] hw/net: Fix Coverity Issue for nocm-gmac
@ 2024-06-18 17:24 Nabih Estefan
0 siblings, 0 replies; 3+ messages in thread
From: Nabih Estefan @ 2024-06-18 17:24 UTC (permalink / raw)
To: peter.maydell; +Cc: qemu-devel, kfting, wuhaotsh, jasowang, nabihestefan
There is an extra `buf=` set that is not used by npcm-gmac. Remove it
for coverity to be happy.
Signed-off-by: Nabih Estefan <nabihestefan@google.com>
---
hw/net/npcm_gmac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c
index 1b71e2526e..b397fd5064 100644
--- a/hw/net/npcm_gmac.c
+++ b/hw/net/npcm_gmac.c
@@ -614,7 +614,6 @@ static void gmac_try_send_next_packet(NPCMGMACState *gmac)
net_checksum_calculate(tx_send_buffer, length, csum);
qemu_send_packet(qemu_get_queue(gmac->nic), tx_send_buffer, length);
trace_npcm_gmac_packet_sent(DEVICE(gmac)->canonical_path, length);
- buf = tx_send_buffer;
length = 0;
}
--
2.45.2.627.g7a2c4fd464-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-18 17:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-18 17:23 [PATCH] hw/net: Fix Coverity Issue for nocm-gmac Nabih Estefan
2024-06-18 17:23 ` [PATCH] hw/net: Fix Coverity Issue for npcm-gmac Nabih Estefan
-- strict thread matches above, loose matches on Subject: below --
2024-06-18 17:24 [PATCH] hw/net: Fix Coverity Issue for nocm-gmac Nabih Estefan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).