qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Nabih Estefan <nabihestefan@google.com>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, kfting@nuvoton.com, wuhaotsh@google.com,
	 jasowang@redhat.org, nabihestefan@google.com
Subject: [PATCH] hw/net: Fix Coverity Issue for npcm-gmac
Date: Tue, 18 Jun 2024 17:24:42 +0000	[thread overview]
Message-ID: <20240618172442.3449262-2-nabihestefan@google.com> (raw)
In-Reply-To: <20240618172442.3449262-1-nabihestefan@google.com>

There is an extra `buf=` set that is not used by npcm-gmac. Remove it
for coverity to be happy.

Signed-off-by: Nabih Estefan <nabihestefan@google.com>
---
 hw/net/npcm_gmac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c
index 1b71e2526e..b397fd5064 100644
--- a/hw/net/npcm_gmac.c
+++ b/hw/net/npcm_gmac.c
@@ -614,7 +614,6 @@ static void gmac_try_send_next_packet(NPCMGMACState *gmac)
             net_checksum_calculate(tx_send_buffer, length, csum);
             qemu_send_packet(qemu_get_queue(gmac->nic), tx_send_buffer, length);
             trace_npcm_gmac_packet_sent(DEVICE(gmac)->canonical_path, length);
-            buf = tx_send_buffer;
             length = 0;
         }
 
-- 
2.45.2.627.g7a2c4fd464-goog



  reply	other threads:[~2024-06-18 17:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 17:24 [PATCH] hw/net: Fix Coverity Issue for nocm-gmac Nabih Estefan
2024-06-18 17:24 ` Nabih Estefan [this message]
2024-06-19  8:34   ` [PATCH] hw/net: Fix Coverity Issue for npcm-gmac Zhang, Chen
  -- strict thread matches above, loose matches on Subject: below --
2024-06-18 17:26 Nabih Estefan
2024-06-18 17:25 Nabih Estefan
2024-06-19  9:13 ` Alex Bennée
2024-06-20  9:52   ` Peter Maydell
2024-06-18 17:23 [PATCH] hw/net: Fix Coverity Issue for nocm-gmac Nabih Estefan
2024-06-18 17:23 ` [PATCH] hw/net: Fix Coverity Issue for npcm-gmac Nabih Estefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240618172442.3449262-2-nabihestefan@google.com \
    --to=nabihestefan@google.com \
    --cc=jasowang@redhat.org \
    --cc=kfting@nuvoton.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wuhaotsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).