* [PATCH 1/3] exec: Make the MemOp enum cast explicit
@ 2024-06-18 22:45 Roman Kiryanov
2024-06-18 22:59 ` Richard Henderson
2024-06-19 10:40 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Roman Kiryanov @ 2024-06-18 22:45 UTC (permalink / raw)
To: qemu-devel; +Cc: jansene, mett, jpcottin, Roman Kiryanov
to use the QEMU headers with a C++ compiler.
Google-Bug-Id: 331190993
Change-Id: I785f2e65d192287f1f964d2840131b653755648c
Signed-off-by: Roman Kiryanov <rkir@google.com>
---
include/exec/memop.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/exec/memop.h b/include/exec/memop.h
index 06417ff361..f881fe7af4 100644
--- a/include/exec/memop.h
+++ b/include/exec/memop.h
@@ -161,7 +161,7 @@ static inline MemOp size_memop(unsigned size)
/* Power of 2 up to 8. */
assert((size & (size - 1)) == 0 && size >= 1 && size <= 8);
#endif
- return ctz32(size);
+ return (MemOp)ctz32(size);
}
/* Big endianness from MemOp. */
--
2.45.2.627.g7a2c4fd464-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] exec: Make the MemOp enum cast explicit
2024-06-18 22:45 [PATCH 1/3] exec: Make the MemOp enum cast explicit Roman Kiryanov
@ 2024-06-18 22:59 ` Richard Henderson
2024-06-19 10:40 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2024-06-18 22:59 UTC (permalink / raw)
To: Roman Kiryanov, qemu-devel; +Cc: jansene, mett, jpcottin
On 6/18/24 15:45, Roman Kiryanov wrote:
> to use the QEMU headers with a C++ compiler.
>
> Google-Bug-Id: 331190993
> Change-Id: I785f2e65d192287f1f964d2840131b653755648c
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> include/exec/memop.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/exec/memop.h b/include/exec/memop.h
> index 06417ff361..f881fe7af4 100644
> --- a/include/exec/memop.h
> +++ b/include/exec/memop.h
> @@ -161,7 +161,7 @@ static inline MemOp size_memop(unsigned size)
> /* Power of 2 up to 8. */
> assert((size & (size - 1)) == 0 && size >= 1 && size <= 8);
> #endif
> - return ctz32(size);
> + return (MemOp)ctz32(size);
> }
>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] exec: Make the MemOp enum cast explicit
2024-06-18 22:45 [PATCH 1/3] exec: Make the MemOp enum cast explicit Roman Kiryanov
2024-06-18 22:59 ` Richard Henderson
@ 2024-06-19 10:40 ` Philippe Mathieu-Daudé
2024-06-19 10:49 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-06-19 10:40 UTC (permalink / raw)
To: Roman Kiryanov, qemu-devel; +Cc: jansene, mett, jpcottin
On 19/6/24 00:45, Roman Kiryanov wrote:
> to use the QEMU headers with a C++ compiler.
>
> Google-Bug-Id: 331190993
> Change-Id: I785f2e65d192287f1f964d2840131b653755648c
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> include/exec/memop.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
and queued, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] exec: Make the MemOp enum cast explicit
2024-06-19 10:40 ` Philippe Mathieu-Daudé
@ 2024-06-19 10:49 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-06-19 10:49 UTC (permalink / raw)
To: Roman Kiryanov, qemu-devel; +Cc: jansene, mett, jpcottin
On 19/6/24 12:40, Philippe Mathieu-Daudé wrote:
> On 19/6/24 00:45, Roman Kiryanov wrote:
>> to use the QEMU headers with a C++ compiler.
>>
>> Google-Bug-Id: 331190993
I searched for this on
https://developers.google.com/issue-tracker/concepts/searches but no
hit, is this public information?
>> Change-Id: I785f2e65d192287f1f964d2840131b653755648c
>> Signed-off-by: Roman Kiryanov <rkir@google.com>
>> ---
>> include/exec/memop.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> and queued, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-19 10:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-18 22:45 [PATCH 1/3] exec: Make the MemOp enum cast explicit Roman Kiryanov
2024-06-18 22:59 ` Richard Henderson
2024-06-19 10:40 ` Philippe Mathieu-Daudé
2024-06-19 10:49 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).