From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
Bandan Das <bdas@redhat.com>, Zhijian Li <lizhijian@fujitsu.com>,
Fabiano Rosas <farosas@suse.de>,
Jiri Denemark <jdenemar@redhat.com>,
Prasad Pandit <ppandit@redhat.com>,
Eric Blake <eblake@redhat.com>,
peterx@redhat.com
Subject: [PATCH v3 10/11] tests/migration-tests: Verify postcopy-recover-setup status
Date: Wed, 19 Jun 2024 18:30:45 -0400 [thread overview]
Message-ID: <20240619223046.1798968-11-peterx@redhat.com> (raw)
In-Reply-To: <20240619223046.1798968-1-peterx@redhat.com>
Making sure the postcopy-recover-setup status is present in the postcopy
failure unit test. Note that it only applies to src QEMU not dest.
This also introduces the tiny but helpful migration_event_wait() helper.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/qtest/migration-test.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index c015e801ac..de81e28088 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -1412,6 +1412,12 @@ static void postcopy_recover_fail(QTestState *from, QTestState *to)
migrate_recover(to, "fd:fd-mig");
migrate_qmp(from, to, "fd:fd-mig", NULL, "{'resume': true}");
+ /*
+ * Source QEMU has an extra RECOVER_SETUP phase, dest doesn't have it.
+ * Make sure it appears along the way.
+ */
+ migration_event_wait(from, "postcopy-recover-setup");
+
/*
* Make sure both QEMU instances will go into RECOVER stage, then test
* kicking them out using migrate-pause.
--
2.45.0
next prev parent reply other threads:[~2024-06-19 22:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 22:30 [PATCH v3 00/11] migration: New postcopy state, and some cleanups Peter Xu
2024-06-19 22:30 ` [PATCH v3 01/11] migration/multifd: Avoid the final FLUSH in complete() Peter Xu
2024-06-19 22:30 ` [PATCH v3 02/11] migration: Rename thread debug names Peter Xu
2024-06-19 22:30 ` [PATCH v3 03/11] migration: Use MigrationStatus instead of int Peter Xu
2024-06-19 22:30 ` [PATCH v3 04/11] migration: Cleanup incoming migration setup state change Peter Xu
2024-06-19 22:30 ` [PATCH v3 05/11] migration/postcopy: Add postcopy-recover-setup phase Peter Xu
2024-06-19 22:30 ` [PATCH v3 06/11] migration/docs: Update postcopy recover session for SETUP phase Peter Xu
2024-06-19 22:30 ` [PATCH v3 07/11] tests/migration-tests: Drop most WIN32 ifdefs for postcopy failure tests Peter Xu
2024-06-19 22:30 ` [PATCH v3 08/11] tests/migration-tests: Always enable migration events Peter Xu
2024-06-20 13:20 ` Fabiano Rosas
2024-06-19 22:30 ` [PATCH v3 09/11] tests/migration-tests: migration_event_wait() Peter Xu
2024-06-20 13:21 ` Fabiano Rosas
2024-06-19 22:30 ` Peter Xu [this message]
2024-06-20 13:21 ` [PATCH v3 10/11] tests/migration-tests: Verify postcopy-recover-setup status Fabiano Rosas
2024-06-19 22:30 ` [PATCH v3 11/11] tests/migration-tests: Cover postcopy failure on reconnect Peter Xu
2024-06-21 17:38 ` [PATCH v3 00/11] migration: New postcopy state, and some cleanups Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619223046.1798968-11-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=bdas@redhat.com \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=jdenemar@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).