From: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Radoslaw Biernacki" <rad@semihalf.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Rebecca Cran" <rebecca@bsdio.com>,
"Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>
Subject: [PATCH v3 2/2] tests/avocado: use default amount of cores on sbsa-ref
Date: Thu, 20 Jun 2024 12:19:49 +0200 [thread overview]
Message-ID: <20240620-b4-new-firmware-v3-2-29a3a2f1be1e@linaro.org> (raw)
In-Reply-To: <20240620-b4-new-firmware-v3-0-29a3a2f1be1e@linaro.org>
The version of the sbsa-ref EDK2 firmware we used to use in this test
had a bug where it might make an unaligned access to the framebuffer,
which causes a guest crash on newer versions of QEMU where we enforce
the architectural requirement that unaligned accesses to Device memory
should take an exception.
We happened to not notice this because our test was booting with "-smp
1" and through luck this didn't write the boot logo to the framebuffer
at an unaligned address; but trying to boot the same firmware with two
CPUs would result in a guest crash. Now we have updated the firmware
we're using for the test, we can make the test use all the cores on the
board, so we are testing the SMP boot path.
Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
tests/avocado/machine_aarch64_sbsaref.py | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py
index e854ec6a1a..e920bbf08c 100644
--- a/tests/avocado/machine_aarch64_sbsaref.py
+++ b/tests/avocado/machine_aarch64_sbsaref.py
@@ -75,8 +75,6 @@ def fetch_firmware(self):
f"if=pflash,file={fs0_path},format=raw",
"-drive",
f"if=pflash,file={fs1_path},format=raw",
- "-smp",
- "1",
"-machine",
"sbsa-ref",
)
--
2.45.1
next prev parent reply other threads:[~2024-06-20 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 10:19 [PATCH v3 0/2] tests/avocado: make sbsa-ref working with >1 core Marcin Juszkiewicz
2024-06-20 10:19 ` [PATCH v3 1/2] tests/avocado: update firmware for sbsa-ref Marcin Juszkiewicz
2024-06-30 14:37 ` Ard Biesheuvel
2024-07-01 6:49 ` Marcin Juszkiewicz
2024-07-01 8:58 ` Peter Maydell
2024-06-20 10:19 ` Marcin Juszkiewicz [this message]
2024-06-24 8:10 ` [PATCH v3 0/2] tests/avocado: make sbsa-ref working with >1 core Philippe Mathieu-Daudé
2024-06-24 13:31 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620-b4-new-firmware-v3-2-29a3a2f1be1e@linaro.org \
--to=marcin.juszkiewicz@linaro.org \
--cc=ardb+tianocore@kernel.org \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=rebecca@bsdio.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).