qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: add precision about capstone for execlog plugin
@ 2024-06-20 13:57 Alexandre Iooss
  2024-06-20 18:33 ` Pierrick Bouvier
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Iooss @ 2024-06-20 13:57 UTC (permalink / raw)
  Cc: Alexandre Iooss, Alex Bennée, Mahmoud Mandour,
	Pierrick Bouvier, Richard Henderson, Paolo Bonzini,
	open list:All patches CC here

Some people are wondering why they get an empty string as disassembly.
Most of the time, they configured QEMU without Capstone support.
Let's document this behaviour to help users.

Signed-off-by: Alexandre Iooss <erdnaxe@crans.org>
---
 docs/devel/tcg-plugins.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst
index 9cc09d8c3d..f7d7b9e3a4 100644
--- a/docs/devel/tcg-plugins.rst
+++ b/docs/devel/tcg-plugins.rst
@@ -539,7 +539,9 @@ which will output an execution trace following this structure::
   0, 0xd34, 0xf9c8f000, "bl #0x10c8"
   0, 0x10c8, 0xfff96c43, "ldr r3, [r0, #0x44]", load, 0x200000e4, RAM
 
-the output can be filtered to only track certain instructions or
+Please note that you need to configure QEMU with Capstone support to get disassembly.
+
+The output can be filtered to only track certain instructions or
 addresses using the ``ifilter`` or ``afilter`` options. You can stack the
 arguments if required::
 
-- 
2.30.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] docs: add precision about capstone for execlog plugin
  2024-06-20 13:57 [PATCH] docs: add precision about capstone for execlog plugin Alexandre Iooss
@ 2024-06-20 18:33 ` Pierrick Bouvier
  0 siblings, 0 replies; 2+ messages in thread
From: Pierrick Bouvier @ 2024-06-20 18:33 UTC (permalink / raw)
  To: Alexandre Iooss
  Cc: Alex Bennée, Mahmoud Mandour, Richard Henderson,
	Paolo Bonzini, open list:All patches CC here

On 6/20/24 06:57, Alexandre Iooss wrote:
> Some people are wondering why they get an empty string as disassembly.
> Most of the time, they configured QEMU without Capstone support.
> Let's document this behaviour to help users.
> 
> Signed-off-by: Alexandre Iooss <erdnaxe@crans.org>
> ---
>   docs/devel/tcg-plugins.rst | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst
> index 9cc09d8c3d..f7d7b9e3a4 100644
> --- a/docs/devel/tcg-plugins.rst
> +++ b/docs/devel/tcg-plugins.rst
> @@ -539,7 +539,9 @@ which will output an execution trace following this structure::
>     0, 0xd34, 0xf9c8f000, "bl #0x10c8"
>     0, 0x10c8, 0xfff96c43, "ldr r3, [r0, #0x44]", load, 0x200000e4, RAM
>   
> -the output can be filtered to only track certain instructions or
> +Please note that you need to configure QEMU with Capstone support to get disassembly.
> +
> +The output can be filtered to only track certain instructions or
>   addresses using the ``ifilter`` or ``afilter`` options. You can stack the
>   arguments if required::
>   

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-20 18:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-20 13:57 [PATCH] docs: add precision about capstone for execlog plugin Alexandre Iooss
2024-06-20 18:33 ` Pierrick Bouvier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).