From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Halil Pasic" <pasic@linux.ibm.com>,
devel@lists.libvirt.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eric Farman" <farman@linux.ibm.com>,
qemu-s390x@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"David Hildenbrand" <david@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
qemu-arm@nongnu.org, "Cédric Le Goater" <clegoate@redhat.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Thomas Huth" <thuth@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-ppc@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v2 02/14] hw/arm: convert 'virt' machine definitions to use new macros
Date: Thu, 20 Jun 2024 17:57:30 +0100 [thread overview]
Message-ID: <20240620165742.1711389-3-berrange@redhat.com> (raw)
In-Reply-To: <20240620165742.1711389-1-berrange@redhat.com>
This changes the DEFINE_VIRT_MACHINE macro to use the common
helpers for constructing versioned symbol names and strings,
bringing greater consistency across targets.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
hw/arm/virt.c | 28 +++++++++++++++-------------
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index c7a1f754e7..a326aa24db 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -101,33 +101,35 @@ static void arm_virt_compat_set(MachineClass *mc)
arm_virt_compat_len);
}
-#define DEFINE_VIRT_MACHINE_LATEST(major, minor, latest) \
- static void virt_##major##_##minor##_class_init(ObjectClass *oc, \
- void *data) \
+#define DEFINE_VIRT_MACHINE_IMPL(latest, ...) \
+ static void MACHINE_VER_SYM(class_init, virt, __VA_ARGS__)( \
+ ObjectClass *oc, \
+ void *data) \
{ \
MachineClass *mc = MACHINE_CLASS(oc); \
arm_virt_compat_set(mc); \
- virt_machine_##major##_##minor##_options(mc); \
- mc->desc = "QEMU " # major "." # minor " ARM Virtual Machine"; \
+ MACHINE_VER_SYM(options, virt, __VA_ARGS__)(mc); \
+ mc->desc = "QEMU " MACHINE_VER_STR(__VA_ARGS__) " ARM Virtual Machine"; \
if (latest) { \
mc->alias = "virt"; \
} \
} \
- static const TypeInfo machvirt_##major##_##minor##_info = { \
- .name = MACHINE_TYPE_NAME("virt-" # major "." # minor), \
+ static const TypeInfo MACHINE_VER_SYM(info, virt, __VA_ARGS__) = \
+ { \
+ .name = MACHINE_VER_TYPE_NAME("virt", __VA_ARGS__), \
.parent = TYPE_VIRT_MACHINE, \
- .class_init = virt_##major##_##minor##_class_init, \
+ .class_init = MACHINE_VER_SYM(class_init, virt, __VA_ARGS__), \
}; \
- static void machvirt_machine_##major##_##minor##_init(void) \
+ static void MACHINE_VER_SYM(register, virt, __VA_ARGS__)(void) \
{ \
- type_register_static(&machvirt_##major##_##minor##_info); \
+ type_register_static(&MACHINE_VER_SYM(info, virt, __VA_ARGS__)); \
} \
- type_init(machvirt_machine_##major##_##minor##_init);
+ type_init(MACHINE_VER_SYM(register, virt, __VA_ARGS__));
#define DEFINE_VIRT_MACHINE_AS_LATEST(major, minor) \
- DEFINE_VIRT_MACHINE_LATEST(major, minor, true)
+ DEFINE_VIRT_MACHINE_IMPL(true, major, minor)
#define DEFINE_VIRT_MACHINE(major, minor) \
- DEFINE_VIRT_MACHINE_LATEST(major, minor, false)
+ DEFINE_VIRT_MACHINE_IMPL(false, major, minor)
/* Number of external interrupt lines to configure the GIC with */
--
2.43.0
next prev parent reply other threads:[~2024-06-20 16:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 16:57 [PATCH v2 00/14] hw: define and enforce a standard lifecycle for versioned machines Daniel P. Berrangé
2024-06-20 16:57 ` [PATCH v2 01/14] include/hw: add helpers for defining versioned machine types Daniel P. Berrangé
2024-06-20 16:57 ` Daniel P. Berrangé [this message]
2024-07-01 12:55 ` [PATCH v2 02/14] hw/arm: convert 'virt' machine definitions to use new macros Philippe Mathieu-Daudé
2024-06-20 16:57 ` [PATCH v2 03/14] hw/s390x: convert 'ccw' " Daniel P. Berrangé
2024-07-01 12:53 ` Philippe Mathieu-Daudé
2024-06-20 16:57 ` [PATCH v2 04/14] hw/ppc: convert 'spapr' " Daniel P. Berrangé
2024-06-20 16:57 ` [PATCH v2 05/14] hw/m68k: convert 'virt' " Daniel P. Berrangé
2024-07-01 12:54 ` Philippe Mathieu-Daudé
2024-06-20 16:57 ` [PATCH v2 06/14] hw/i386: convert 'i440fx' " Daniel P. Berrangé
2024-07-01 9:11 ` Thomas Huth
2024-07-01 12:58 ` Philippe Mathieu-Daudé
2024-06-20 16:57 ` [PATCH v2 07/14] hw/i386: convert 'q35' " Daniel P. Berrangé
2024-07-01 9:14 ` Thomas Huth
2024-07-01 12:59 ` Philippe Mathieu-Daudé
2024-06-20 16:57 ` [PATCH v2 08/14] include/hw: add macros for deprecation & removal of versioned machines Daniel P. Berrangé
2024-07-01 15:13 ` Philippe Mathieu-Daudé
2024-06-20 16:57 ` [PATCH v2 09/14] include/hw: temporarily disable deletion of versioned machine types Daniel P. Berrangé
2024-06-20 17:18 ` Thomas Huth
2024-06-20 16:57 ` [PATCH v2 10/14] hw: set deprecation info for all " Daniel P. Berrangé
2024-07-01 11:20 ` Philippe Mathieu-Daudé
2024-06-20 16:57 ` [PATCH v2 11/14] hw: skip registration of outdated " Daniel P. Berrangé
2024-07-01 15:14 ` Philippe Mathieu-Daudé
2024-06-20 16:57 ` [PATCH v2 12/14] hw/ppc: remove obsolete manual deprecation reason string of spapr machines Daniel P. Berrangé
2024-07-01 11:20 ` Philippe Mathieu-Daudé
2024-06-20 16:57 ` [PATCH v2 13/14] hw/i386: remove obsolete manual deprecation reason string of i440fx machines Daniel P. Berrangé
2024-07-01 11:21 ` Philippe Mathieu-Daudé
2024-06-20 16:57 ` [PATCH v2 14/14] docs: document special exception for machine type deprecation & removal Daniel P. Berrangé
2024-07-01 15:15 ` Philippe Mathieu-Daudé
2024-07-01 15:41 ` [PATCH v2 00/14] hw: define and enforce a standard lifecycle for versioned machines Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620165742.1711389-3-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=clegoate@redhat.com \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=devel@lists.libvirt.org \
--cc=eduardo@habkost.net \
--cc=farman@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).