From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Huang Rui" <ray.huang@amd.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Antonio Caggiano" <quic_acaggian@quicinc.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Robert Beckett" <bob.beckett@collabora.com>,
"Gert Wollny" <gert.wollny@collabora.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
ernunes@redhat.com, "Alyssa Ross" <hi@alyssa.is>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Stefano Stabellini" <stefano.stabellini@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Xenia Ragiadakou" <xenia.ragiadakou@amd.com>,
"Pierre-Eric Pelloux-Prayer" <pierre-eric.pelloux-prayer@amd.com>,
"Honglei Huang" <honglei1.huang@amd.com>,
"Julia Zhang" <julia.zhang@amd.com>,
"Chen Jiqian" <Jiqian.Chen@amd.com>,
"Yiwei Zhang" <zzyiwei@chromium.org>
Subject: [PATCH v16 02/13] virtio-gpu: Move fence_poll timer to VirtIOGPUGL
Date: Sun, 23 Jun 2024 18:23:32 +0300 [thread overview]
Message-ID: <20240623152343.328436-3-dmitry.osipenko@collabora.com> (raw)
In-Reply-To: <20240623152343.328436-1-dmitry.osipenko@collabora.com>
Move fence_poll timer to VirtIOGPUGL for consistency with cmdq_resume_bh
that are used only by GL device.
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
hw/display/virtio-gpu-virgl.c | 8 +++++---
include/hw/virtio/virtio-gpu.h | 3 ++-
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c
index 14091b191ec0..91dce90f9176 100644
--- a/hw/display/virtio-gpu-virgl.c
+++ b/hw/display/virtio-gpu-virgl.c
@@ -594,11 +594,12 @@ static void virtio_gpu_print_stats(void *opaque)
static void virtio_gpu_fence_poll(void *opaque)
{
VirtIOGPU *g = opaque;
+ VirtIOGPUGL *gl = VIRTIO_GPU_GL(g);
virgl_renderer_poll();
virtio_gpu_process_cmdq(g);
if (!QTAILQ_EMPTY(&g->cmdq) || !QTAILQ_EMPTY(&g->fenceq)) {
- timer_mod(g->fence_poll, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + 10);
+ timer_mod(gl->fence_poll, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + 10);
}
}
@@ -626,6 +627,7 @@ int virtio_gpu_virgl_init(VirtIOGPU *g)
{
int ret;
uint32_t flags = 0;
+ VirtIOGPUGL *gl = VIRTIO_GPU_GL(g);
#if VIRGL_RENDERER_CALLBACKS_VERSION >= 4
if (qemu_egl_display) {
@@ -645,8 +647,8 @@ int virtio_gpu_virgl_init(VirtIOGPU *g)
return ret;
}
- g->fence_poll = timer_new_ms(QEMU_CLOCK_VIRTUAL,
- virtio_gpu_fence_poll, g);
+ gl->fence_poll = timer_new_ms(QEMU_CLOCK_VIRTUAL,
+ virtio_gpu_fence_poll, g);
if (virtio_gpu_stats_enabled(g->parent_obj.conf)) {
g->print_stats = timer_new_ms(QEMU_CLOCK_VIRTUAL,
diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index 7a59379f5a7a..bc69fd78a440 100644
--- a/include/hw/virtio/virtio-gpu.h
+++ b/include/hw/virtio/virtio-gpu.h
@@ -196,7 +196,6 @@ struct VirtIOGPU {
uint64_t hostmem;
bool processing_cmdq;
- QEMUTimer *fence_poll;
QEMUTimer *print_stats;
uint32_t inflight;
@@ -231,6 +230,8 @@ struct VirtIOGPUGL {
bool renderer_inited;
bool renderer_reset;
+
+ QEMUTimer *fence_poll;
};
struct VhostUserGPU {
--
2.45.2
next prev parent reply other threads:[~2024-06-23 15:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 15:23 [PATCH v16 00/13] Support blob memory and venus on qemu Dmitry Osipenko
2024-06-23 15:23 ` [PATCH v16 01/13] virtio-gpu: Use trace events for tracking number of in-flight fences Dmitry Osipenko
2024-06-24 5:34 ` Akihiko Odaki
2024-08-06 14:23 ` Alex Bennée
2024-06-23 15:23 ` Dmitry Osipenko [this message]
2024-06-24 5:35 ` [PATCH v16 02/13] virtio-gpu: Move fence_poll timer to VirtIOGPUGL Akihiko Odaki
2024-08-06 17:08 ` Alex Bennée
2024-06-23 15:23 ` [PATCH v16 03/13] virtio-gpu: Move print_stats " Dmitry Osipenko
2024-06-24 5:35 ` Akihiko Odaki
2024-06-23 15:23 ` [PATCH v16 04/13] virtio-gpu: Handle virtio_gpu_virgl_init() failure Dmitry Osipenko
2024-06-24 5:35 ` Akihiko Odaki
2024-06-23 15:23 ` [PATCH v16 05/13] virtio-gpu: Unrealize GL device Dmitry Osipenko
2024-06-24 5:36 ` Akihiko Odaki
2024-06-23 15:23 ` [PATCH v16 06/13] virtio-gpu: Use pkgconfig version to decide which virgl features are available Dmitry Osipenko
2024-06-24 5:36 ` Akihiko Odaki
2024-06-23 15:23 ` [PATCH v16 07/13] virtio-gpu: Support context-init feature with virglrenderer Dmitry Osipenko
2024-06-24 5:37 ` Akihiko Odaki
2024-06-23 15:23 ` [PATCH v16 08/13] virtio-gpu: Don't require udmabuf when blobs and virgl are enabled Dmitry Osipenko
2024-06-24 5:37 ` Akihiko Odaki
2024-06-23 15:23 ` [PATCH v16 09/13] virtio-gpu: Add virgl resource management Dmitry Osipenko
2024-06-24 5:37 ` Akihiko Odaki
2024-06-23 15:23 ` [PATCH v16 10/13] virtio-gpu: Support suspension of commands processing Dmitry Osipenko
2024-06-24 5:38 ` Akihiko Odaki
2024-06-23 15:23 ` [PATCH v16 11/13] virtio-gpu: Handle resource blob commands Dmitry Osipenko
2024-06-24 5:38 ` Akihiko Odaki
2024-06-23 15:23 ` [PATCH v16 12/13] virtio-gpu: Register capsets dynamically Dmitry Osipenko
2024-06-24 5:39 ` Akihiko Odaki
2024-06-23 15:23 ` [PATCH v16 13/13] virtio-gpu: Support Venus context Dmitry Osipenko
2024-06-24 5:39 ` Akihiko Odaki
2024-07-01 10:48 ` [PATCH v16 00/13] Support blob memory and venus on qemu Marc-André Lureau
2024-07-01 20:43 ` Michael S. Tsirkin
2024-07-01 20:45 ` Michael S. Tsirkin
2024-07-22 13:55 ` Alex Bennée
2024-08-22 13:13 ` Alex Bennée
2024-08-22 13:48 ` Dmitry Osipenko
2024-08-20 10:44 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240623152343.328436-3-dmitry.osipenko@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=Jiqian.Chen@amd.com \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=alexander.deucher@amd.com \
--cc=bob.beckett@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dgilbert@redhat.com \
--cc=ernunes@redhat.com \
--cc=gert.wollny@collabora.com \
--cc=gurchetansingh@chromium.org \
--cc=hi@alyssa.is \
--cc=honglei1.huang@amd.com \
--cc=julia.zhang@amd.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=quic_acaggian@quicinc.com \
--cc=ray.huang@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=xenia.ragiadakou@amd.com \
--cc=zzyiwei@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).