From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Gao,Shiyuan" <gaoshiyuan@baidu.com>
Cc: "imammedo@redhat.com" <imammedo@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"berrange@redhat.com" <berrange@redhat.com>
Subject: Re: Failed to hot-plug device to pxb bridge
Date: Mon, 24 Jun 2024 06:13:03 -0400 [thread overview]
Message-ID: <20240624060856-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <74e8929fd34d496ea64aab6b3a136b3b@baidu.com>
On Mon, Jun 24, 2024 at 03:08:55AM +0000, Gao,Shiyuan wrote:
> > I checked the guest dmesg and found that failed load shpc driver.
> > [ 0.966668] shpchp 0000:00:05.0: Requesting control of SHPC hotplug via OSHP (\_SB_.PCI0.S28_)
> > [ 0.968238] shpchp 0000:00:05.0: Requesting control of SHPC hotplug via OSHP (\_SB_.PCI0)
> > [ 0.969160] shpchp 0000:00:05.0: Cannot get control of SHPC hotplug
> > [ 0.969876] shpchp 0000:00:06.0: Requesting control of SHPC hotplug via OSHP (\_SB_.PCI0.S30_)
> > [ 0.971454] shpchp 0000:00:06.0: Requesting control of SHPC hotplug via OSHP (\_SB_.PCI0)
> > [ 0.972376] shpchp 0000:00:06.0: Cannot get control of SHPC hotplug
> > [ 0.973119] shpchp 0000:80:00.0: Requesting control of SHPC hotplug via OSHP (\_SB_.PC80)
> > [ 0.974674] shpchp 0000:80:00.0: Cannot get control of SHPC hotplug
> > [ 0.979422] shpchp 0000:81:01.0: Requesting control of SHPC hotplug via OSHP (\_SB_.PC80)
> > [ 0.980948] shpchp 0000:81:01.0: Cannot get control of SHPC hotplug
> > [ 0.981685] shpchp 0000:60:00.0: Requesting control of SHPC hotplug via OSHP (\_SB_.PC60)
> > [ 0.994623] shpchp 0000:60:00.0: Cannot get control of SHPC hotplug
> > [ 0.995349] shpchp 0000:61:01.0: Requesting control of SHPC hotplug via OSHP (\_SB_.PC60)
> > [ 0.996891] shpchp 0000:61:01.0: Cannot get control of SHPC hotplug
> > [ 0.997626] shpchp: Standard Hot Plug PCI Controller Driver version: 0.4
> > Read the shpc driver code, I found that before shpc_init it need check the shpc capability of bridge(shpc_capable) and
> > get hotplug control from firmware(acpi_get_hp_hw_control_from_firmware) in shpc_probe.
> > Howerver it return fail in acpi_get_hp_hw_control_from_firmware. I dump the acpid table, not found OSC and OSHP
> > method in dsdt.dsl.
> > In the QEMU build_dsdt, not found build osc method in i440fx.
> > Putting aside this pxb scenario, I suspect that after disable acpi-pci-hotplug-with-bridge-support,
> > hot-plug into the PCI bridge via SHPC can be successful in i440fx ?
>
> After adding oshp method in build_dsdt, the SHPC driver load sucess and hotplug device sucess. Maybe we need a patch
> fix it ?
>
>
>
>
Sorry, can't really say what you are proposing.
Send a patch?
prev parent reply other threads:[~2024-06-24 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 8:29 Failed to hot-plug device to pxb bridge Gao,Shiyuan via
[not found] ` <20240530160919.01a3effc@imammedo.users.ipa.redhat.com>
2024-06-21 2:50 ` Gao,Shiyuan via
2024-06-24 3:08 ` Gao,Shiyuan via
2024-06-24 10:13 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624060856-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=berrange@redhat.com \
--cc=gaoshiyuan@baidu.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).