qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Dr . David Alan Gilbert" <dave@treblig.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>
Subject: [PULL 09/12] plugins: add migration blocker
Date: Mon, 24 Jun 2024 11:18:33 +0100	[thread overview]
Message-ID: <20240624101836.193761-10-alex.bennee@linaro.org> (raw)
In-Reply-To: <20240624101836.193761-1-alex.bennee@linaro.org>

If the plugin in controlling time there is some state that might be
missing from the plugin tracking it. Migration is unlikely to work in
this case so lets put a migration blocker in to let the user know if
they try.

Suggested-by: Dr. David Alan Gilbert <dave@treblig.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240620152220.2192768-10-alex.bennee@linaro.org>

diff --git a/plugins/api.c b/plugins/api.c
index 4431a0ea7e..2ff13d09de 100644
--- a/plugins/api.c
+++ b/plugins/api.c
@@ -47,6 +47,8 @@
 #include "disas/disas.h"
 #include "plugin.h"
 #ifndef CONFIG_USER_ONLY
+#include "qapi/error.h"
+#include "migration/blocker.h"
 #include "exec/ram_addr.h"
 #include "qemu/plugin-memory.h"
 #include "hw/boards.h"
@@ -589,11 +591,19 @@ uint64_t qemu_plugin_u64_sum(qemu_plugin_u64 entry)
  * Time control
  */
 static bool has_control;
+#ifdef CONFIG_SOFTMMU
+static Error *migration_blocker;
+#endif
 
 const void *qemu_plugin_request_time_control(void)
 {
     if (!has_control) {
         has_control = true;
+#ifdef CONFIG_SOFTMMU
+        error_setg(&migration_blocker,
+                   "TCG plugin time control does not support migration");
+        migrate_add_blocker(&migration_blocker, NULL);
+#endif
         return &has_control;
     }
     return NULL;
-- 
2.39.2



  parent reply	other threads:[~2024-06-24 10:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24 10:18 [PULL 00/12] maintainer updates (plugins, gdbstub) Alex Bennée
2024-06-24 10:18 ` [PULL 01/12] include/exec: add missing include guard comment Alex Bennée
2024-06-24 10:18 ` [PULL 02/12] gdbstub: move enums into separate header Alex Bennée
2024-06-24 10:18 ` [PULL 03/12] plugins: Ensure register handles are not NULL Alex Bennée
2024-06-24 10:18 ` [PULL 04/12] sysemu: add set_virtual_time to accel ops Alex Bennée
2024-06-24 10:18 ` [PULL 05/12] qtest: use cpu interface in qtest_clock_warp Alex Bennée
2024-06-24 10:18 ` [PULL 06/12] sysemu: generalise qtest_warp_clock as qemu_clock_advance_virtual_time Alex Bennée
2024-06-24 10:18 ` [PULL 07/12] qtest: move qtest_{get, set}_virtual_clock to accel/qtest/qtest.c Alex Bennée
2024-06-24 10:18 ` [PULL 08/12] plugins: add time control API Alex Bennée
2024-06-24 10:18 ` Alex Bennée [this message]
2024-06-24 10:18 ` [PULL 10/12] contrib/plugins: add Instructions Per Second (IPS) example for cost modeling Alex Bennée
2024-06-24 10:18 ` [PULL 11/12] plugins: fix inject_mem_cb rw masking Alex Bennée
2024-06-24 10:18 ` [PULL 12/12] accel/tcg: Avoid unnecessary call overhead from qemu_plugin_vcpu_mem_cb Alex Bennée
2024-06-25  1:23 ` [PULL 00/12] maintainer updates (plugins, gdbstub) Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240624101836.193761-10-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=dave@treblig.org \
    --cc=erdnaxe@crans.org \
    --cc=ma.mandourr@gmail.com \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).