qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Max Chou" <max.chou@sifive.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Frank Chang" <frank.chang@sifive.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PULL 12/12] accel/tcg: Avoid unnecessary call overhead from qemu_plugin_vcpu_mem_cb
Date: Mon, 24 Jun 2024 11:18:36 +0100	[thread overview]
Message-ID: <20240624101836.193761-13-alex.bennee@linaro.org> (raw)
In-Reply-To: <20240624101836.193761-1-alex.bennee@linaro.org>

From: Max Chou <max.chou@sifive.com>

If there are not any QEMU plugin memory callback functions, checking
before calling the qemu_plugin_vcpu_mem_cb function can reduce the
function call overhead.

Signed-off-by: Max Chou <max.chou@sifive.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Frank Chang <frank.chang@sifive.com>
Message-Id: <20240613175122.1299212-2-max.chou@sifive.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240620152220.2192768-13-alex.bennee@linaro.org>

diff --git a/accel/tcg/ldst_common.c.inc b/accel/tcg/ldst_common.c.inc
index c82048e377..87ceb95487 100644
--- a/accel/tcg/ldst_common.c.inc
+++ b/accel/tcg/ldst_common.c.inc
@@ -125,7 +125,9 @@ void helper_st_i128(CPUArchState *env, uint64_t addr, Int128 val, MemOpIdx oi)
 
 static void plugin_load_cb(CPUArchState *env, abi_ptr addr, MemOpIdx oi)
 {
-    qemu_plugin_vcpu_mem_cb(env_cpu(env), addr, oi, QEMU_PLUGIN_MEM_R);
+    if (cpu_plugin_mem_cbs_enabled(env_cpu(env))) {
+        qemu_plugin_vcpu_mem_cb(env_cpu(env), addr, oi, QEMU_PLUGIN_MEM_R);
+    }
 }
 
 uint8_t cpu_ldb_mmu(CPUArchState *env, abi_ptr addr, MemOpIdx oi, uintptr_t ra)
@@ -188,7 +190,9 @@ Int128 cpu_ld16_mmu(CPUArchState *env, abi_ptr addr,
 
 static void plugin_store_cb(CPUArchState *env, abi_ptr addr, MemOpIdx oi)
 {
-    qemu_plugin_vcpu_mem_cb(env_cpu(env), addr, oi, QEMU_PLUGIN_MEM_W);
+    if (cpu_plugin_mem_cbs_enabled(env_cpu(env))) {
+        qemu_plugin_vcpu_mem_cb(env_cpu(env), addr, oi, QEMU_PLUGIN_MEM_W);
+    }
 }
 
 void cpu_stb_mmu(CPUArchState *env, abi_ptr addr, uint8_t val,
-- 
2.39.2



  parent reply	other threads:[~2024-06-24 10:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24 10:18 [PULL 00/12] maintainer updates (plugins, gdbstub) Alex Bennée
2024-06-24 10:18 ` [PULL 01/12] include/exec: add missing include guard comment Alex Bennée
2024-06-24 10:18 ` [PULL 02/12] gdbstub: move enums into separate header Alex Bennée
2024-06-24 10:18 ` [PULL 03/12] plugins: Ensure register handles are not NULL Alex Bennée
2024-06-24 10:18 ` [PULL 04/12] sysemu: add set_virtual_time to accel ops Alex Bennée
2024-06-24 10:18 ` [PULL 05/12] qtest: use cpu interface in qtest_clock_warp Alex Bennée
2024-06-24 10:18 ` [PULL 06/12] sysemu: generalise qtest_warp_clock as qemu_clock_advance_virtual_time Alex Bennée
2024-06-24 10:18 ` [PULL 07/12] qtest: move qtest_{get, set}_virtual_clock to accel/qtest/qtest.c Alex Bennée
2024-06-24 10:18 ` [PULL 08/12] plugins: add time control API Alex Bennée
2024-06-24 10:18 ` [PULL 09/12] plugins: add migration blocker Alex Bennée
2024-06-24 10:18 ` [PULL 10/12] contrib/plugins: add Instructions Per Second (IPS) example for cost modeling Alex Bennée
2024-06-24 10:18 ` [PULL 11/12] plugins: fix inject_mem_cb rw masking Alex Bennée
2024-06-24 10:18 ` Alex Bennée [this message]
2024-06-25  1:23 ` [PULL 00/12] maintainer updates (plugins, gdbstub) Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240624101836.193761-13-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=frank.chang@sifive.com \
    --cc=max.chou@sifive.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).