From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"John Snow" <jsnow@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>
Subject: [PATCH 1/4] python: linter changes for pylint 3.x
Date: Wed, 26 Jun 2024 19:22:27 -0400 [thread overview]
Message-ID: <20240626232230.408004-2-jsnow@redhat.com> (raw)
In-Reply-To: <20240626232230.408004-1-jsnow@redhat.com>
New bleeding edge versions, new nits to iron out. This addresses the
'check-python-tox' optional GitLab test, while 'check-python-minreqs'
saw no regressions, since it's frozen on an older version of pylint.
Fixes:
qemu/machine/machine.py:345:52: E0606: Possibly using variable 'sock' before assignment (possibly-used-before-assignment)
qemu/utils/qemu_ga_client.py:168:4: R1711: Useless return at end of function or method (useless-return)
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/machine/machine.py | 1 +
python/qemu/utils/qemu_ga_client.py | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index f648f6af451..ebb58d5b68c 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -335,6 +335,7 @@ def binary(self) -> str:
def _pre_launch(self) -> None:
if self._qmp_set:
+ sock = None
if self._monitor_address is None:
self._sock_pair = socket.socketpair()
os.set_inheritable(self._sock_pair[0].fileno(), True)
diff --git a/python/qemu/utils/qemu_ga_client.py b/python/qemu/utils/qemu_ga_client.py
index 9a665e6e990..cf0fcf9a8bb 100644
--- a/python/qemu/utils/qemu_ga_client.py
+++ b/python/qemu/utils/qemu_ga_client.py
@@ -174,7 +174,7 @@ def suspend(self, mode: str) -> None:
# On error exception will raise
except asyncio.TimeoutError:
# On success command will timed out
- return
+ pass
def shutdown(self, mode: str = 'powerdown') -> None:
if mode not in ['powerdown', 'halt', 'reboot']:
--
2.45.0
next prev parent reply other threads:[~2024-06-26 23:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 23:22 [PATCH 0/4] Python: Add 3.13 support, play linter whackamole John Snow
2024-06-26 23:22 ` John Snow [this message]
2024-07-03 9:50 ` [PATCH 1/4] python: linter changes for pylint 3.x Alex Bennée
2024-06-26 23:22 ` [PATCH 2/4] python: Do not use pylint 3.2.4 with python 3.8 John Snow
2024-07-03 9:50 ` Alex Bennée
2024-06-26 23:22 ` [PATCH 3/4] iotests: Change imports for Python 3.13 John Snow
2024-07-01 23:44 ` John Snow
2024-07-02 11:52 ` Nir Soffer
2024-07-02 14:44 ` John Snow
2024-07-02 17:51 ` Nir Soffer
2024-07-03 20:12 ` John Snow
2024-06-26 23:22 ` [PATCH 4/4] python: enable testing for 3.13 John Snow
2024-07-03 10:29 ` Alex Bennée
2024-07-05 15:52 ` [PATCH 0/4] Python: Add 3.13 support, play linter whackamole John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626232230.408004-2-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).