From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alexandre Iooss" <erdnaxe@crans.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v2 1/7] plugins: fix mem callback array size
Date: Wed, 26 Jun 2024 16:37:51 -0700 [thread overview]
Message-ID: <20240626233757.375083-2-pierrick.bouvier@linaro.org> (raw)
In-Reply-To: <20240626233757.375083-1-pierrick.bouvier@linaro.org>
data was correctly copied, but size of array was not set
(g_array_sized_new only reserves memory, but does not set size).
As a result, callbacks were not called for code path relying on
plugin_register_vcpu_mem_cb().
Found when trying to trigger mem access callbacks for atomic
instructions.
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
accel/tcg/plugin-gen.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c
index b6bae32b997..ec89a085b43 100644
--- a/accel/tcg/plugin-gen.c
+++ b/accel/tcg/plugin-gen.c
@@ -85,8 +85,7 @@ static void gen_enable_mem_helper(struct qemu_plugin_tb *ptb,
len = insn->mem_cbs->len;
arr = g_array_sized_new(false, false,
sizeof(struct qemu_plugin_dyn_cb), len);
- memcpy(arr->data, insn->mem_cbs->data,
- len * sizeof(struct qemu_plugin_dyn_cb));
+ g_array_append_vals(arr, insn->mem_cbs->data, len);
qemu_plugin_add_dyn_cb_arr(arr);
tcg_gen_st_ptr(tcg_constant_ptr((intptr_t)arr), tcg_env,
--
2.39.2
next prev parent reply other threads:[~2024-06-26 23:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 23:37 [PATCH v2 0/7] plugins: access values during a memory read/write Pierrick Bouvier
2024-06-26 23:37 ` Pierrick Bouvier [this message]
2024-06-26 23:37 ` [PATCH v2 2/7] plugins: save value during memory accesses Pierrick Bouvier
2024-06-27 19:10 ` Richard Henderson
2024-06-27 19:25 ` Pierrick Bouvier
2024-06-27 20:03 ` Richard Henderson
2024-06-26 23:37 ` [PATCH v2 3/7] plugins: extend API to get latest memory value accessed Pierrick Bouvier
2024-06-26 23:37 ` [PATCH v2 4/7] tests/tcg: add mechanism to run specific tests with plugins Pierrick Bouvier
2024-06-30 1:31 ` Richard Henderson
2024-06-26 23:37 ` [PATCH v2 5/7] tests/tcg: allow to check output of plugins Pierrick Bouvier
2024-06-26 23:37 ` [PATCH v2 6/7] tests/plugin/mem: add option to print memory accesses Pierrick Bouvier
2024-06-27 3:17 ` Xingtao Yao (Fujitsu) via
2024-06-27 5:29 ` Pierrick Bouvier
2024-06-27 6:04 ` Xingtao Yao (Fujitsu) via
2024-06-27 18:31 ` Pierrick Bouvier
2024-06-26 23:37 ` [PATCH v2 7/7] tests/tcg/x86_64: add test for plugin memory access Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626233757.375083-2-pierrick.bouvier@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).