From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alexandre Iooss" <erdnaxe@crans.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v2 3/7] plugins: extend API to get latest memory value accessed
Date: Wed, 26 Jun 2024 16:37:53 -0700 [thread overview]
Message-ID: <20240626233757.375083-4-pierrick.bouvier@linaro.org> (raw)
In-Reply-To: <20240626233757.375083-1-pierrick.bouvier@linaro.org>
Two functions are added to plugins API:
- qemu_plugin_mem_get_value_upper_bits
- qemu_plugin_mem_get_value_lower_bits
This value can be accessed only during a memory callback.
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
include/qemu/qemu-plugin.h | 20 ++++++++++++++++++++
plugins/api.c | 21 +++++++++++++++++++++
plugins/qemu-plugins.symbols | 2 ++
3 files changed, 43 insertions(+)
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index c71c705b699..5945f256949 100644
--- a/include/qemu/qemu-plugin.h
+++ b/include/qemu/qemu-plugin.h
@@ -551,6 +551,26 @@ bool qemu_plugin_mem_is_big_endian(qemu_plugin_meminfo_t info);
QEMU_PLUGIN_API
bool qemu_plugin_mem_is_store(qemu_plugin_meminfo_t info);
+/**
+ * qemu_plugin_mem_get_value_lower_bits() - return 64 lower bits of latest
+ * accessed memory value
+ * @info: opaque memory transaction handle
+ *
+ * Returns: lower bits for value accessed
+ */
+QEMU_PLUGIN_API
+uint64_t qemu_plugin_mem_get_value_lower_bits(qemu_plugin_meminfo_t info);
+
+/**
+ * qemu_plugin_mem_get_value_upper_bits() - return 64 upper bits of latest
+ * accessed memory value
+ * @info: opaque memory transaction handle
+ *
+ * Returns: upper bits for value accessed
+ */
+QEMU_PLUGIN_API
+uint64_t qemu_plugin_mem_get_value_upper_bits(qemu_plugin_meminfo_t info);
+
/**
* qemu_plugin_get_hwaddr() - return handle for memory operation
* @info: opaque memory info structure
diff --git a/plugins/api.c b/plugins/api.c
index 2ff13d09de6..89e9f6ba5b4 100644
--- a/plugins/api.c
+++ b/plugins/api.c
@@ -351,6 +351,27 @@ bool qemu_plugin_mem_is_store(qemu_plugin_meminfo_t info)
return get_plugin_meminfo_rw(info) & QEMU_PLUGIN_MEM_W;
}
+uint64_t qemu_plugin_mem_get_value_upper_bits(qemu_plugin_meminfo_t info)
+{
+ return current_cpu->plugin_state->mem_value_upper_bits;
+}
+
+uint64_t qemu_plugin_mem_get_value_lower_bits(qemu_plugin_meminfo_t info)
+{
+ uint64_t value = current_cpu->plugin_state->mem_value_lower_bits;
+ /* tcg values are sign extended, so we must clip them */
+ switch (qemu_plugin_mem_size_shift(info)) {
+ case 0:
+ return value & 0xff;
+ case 1:
+ return value & 0xffff;
+ case 2:
+ return value & 0xffffffff;
+ default:
+ return value;
+ }
+}
+
/*
* Virtual Memory queries
*/
diff --git a/plugins/qemu-plugins.symbols b/plugins/qemu-plugins.symbols
index ca773d8d9fe..9f2646fc812 100644
--- a/plugins/qemu-plugins.symbols
+++ b/plugins/qemu-plugins.symbols
@@ -13,6 +13,8 @@
qemu_plugin_insn_size;
qemu_plugin_insn_symbol;
qemu_plugin_insn_vaddr;
+ qemu_plugin_mem_get_value_upper_bits;
+ qemu_plugin_mem_get_value_lower_bits;
qemu_plugin_mem_is_big_endian;
qemu_plugin_mem_is_sign_extended;
qemu_plugin_mem_is_store;
--
2.39.2
next prev parent reply other threads:[~2024-06-26 23:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 23:37 [PATCH v2 0/7] plugins: access values during a memory read/write Pierrick Bouvier
2024-06-26 23:37 ` [PATCH v2 1/7] plugins: fix mem callback array size Pierrick Bouvier
2024-06-26 23:37 ` [PATCH v2 2/7] plugins: save value during memory accesses Pierrick Bouvier
2024-06-27 19:10 ` Richard Henderson
2024-06-27 19:25 ` Pierrick Bouvier
2024-06-27 20:03 ` Richard Henderson
2024-06-26 23:37 ` Pierrick Bouvier [this message]
2024-06-26 23:37 ` [PATCH v2 4/7] tests/tcg: add mechanism to run specific tests with plugins Pierrick Bouvier
2024-06-30 1:31 ` Richard Henderson
2024-06-26 23:37 ` [PATCH v2 5/7] tests/tcg: allow to check output of plugins Pierrick Bouvier
2024-06-26 23:37 ` [PATCH v2 6/7] tests/plugin/mem: add option to print memory accesses Pierrick Bouvier
2024-06-27 3:17 ` Xingtao Yao (Fujitsu) via
2024-06-27 5:29 ` Pierrick Bouvier
2024-06-27 6:04 ` Xingtao Yao (Fujitsu) via
2024-06-27 18:31 ` Pierrick Bouvier
2024-06-26 23:37 ` [PATCH v2 7/7] tests/tcg/x86_64: add test for plugin memory access Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626233757.375083-4-pierrick.bouvier@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).