From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alexandre Iooss" <erdnaxe@crans.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v2 6/7] tests/plugin/mem: add option to print memory accesses
Date: Wed, 26 Jun 2024 16:37:56 -0700 [thread overview]
Message-ID: <20240626233757.375083-7-pierrick.bouvier@linaro.org> (raw)
In-Reply-To: <20240626233757.375083-1-pierrick.bouvier@linaro.org>
By using "print-accesses=true" option, mem plugin will now print every
value accessed, with associated size, type (store vs load) and symbol
where this happens.
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
tests/plugin/mem.c | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/tests/plugin/mem.c b/tests/plugin/mem.c
index b650dddcce1..d897034a044 100644
--- a/tests/plugin/mem.c
+++ b/tests/plugin/mem.c
@@ -24,7 +24,7 @@ typedef struct {
static struct qemu_plugin_scoreboard *counts;
static qemu_plugin_u64 mem_count;
static qemu_plugin_u64 io_count;
-static bool do_inline, do_callback;
+static bool do_inline, do_callback, do_print_accesses;
static bool do_haddr;
static enum qemu_plugin_mem_rw rw = QEMU_PLUGIN_MEM_RW;
@@ -60,6 +60,20 @@ static void vcpu_mem(unsigned int cpu_index, qemu_plugin_meminfo_t meminfo,
}
}
+static void print_access(unsigned int cpu_index, qemu_plugin_meminfo_t meminfo,
+ uint64_t vaddr, void *udata)
+{
+ unsigned size = 8 << qemu_plugin_mem_size_shift(meminfo);
+ const char *type = qemu_plugin_mem_is_store(meminfo) ? "store" : "load";
+ uint64_t upper = qemu_plugin_mem_get_value_upper_bits(meminfo);
+ uint64_t lower = qemu_plugin_mem_get_value_lower_bits(meminfo);
+ const char *sym = udata ? udata : "";
+ g_autoptr(GString) out = g_string_new("");
+ g_string_printf(out, "access: 0x%.0"PRIx64"%"PRIx64",%d,%s,%s\n",
+ upper, lower, size, type, sym);
+ qemu_plugin_outs(out->str);
+}
+
static void vcpu_tb_trans(qemu_plugin_id_t id, struct qemu_plugin_tb *tb)
{
size_t n = qemu_plugin_tb_n_insns(tb);
@@ -79,6 +93,12 @@ static void vcpu_tb_trans(qemu_plugin_id_t id, struct qemu_plugin_tb *tb)
QEMU_PLUGIN_CB_NO_REGS,
rw, NULL);
}
+ if (do_print_accesses) {
+ const char *sym = qemu_plugin_insn_symbol(insn);
+ qemu_plugin_register_vcpu_mem_cb(insn, print_access,
+ QEMU_PLUGIN_CB_NO_REGS,
+ rw, (void *) sym);
+ }
}
}
@@ -117,6 +137,12 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin_id_t id,
fprintf(stderr, "boolean argument parsing failed: %s\n", opt);
return -1;
}
+ } else if (g_strcmp0(tokens[0], "print-accesses") == 0) {
+ if (!qemu_plugin_bool_parse(tokens[0], tokens[1],
+ &do_print_accesses)) {
+ fprintf(stderr, "boolean argument parsing failed: %s\n", opt);
+ return -1;
+ }
} else {
fprintf(stderr, "option parsing failed: %s\n", opt);
return -1;
--
2.39.2
next prev parent reply other threads:[~2024-06-26 23:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 23:37 [PATCH v2 0/7] plugins: access values during a memory read/write Pierrick Bouvier
2024-06-26 23:37 ` [PATCH v2 1/7] plugins: fix mem callback array size Pierrick Bouvier
2024-06-26 23:37 ` [PATCH v2 2/7] plugins: save value during memory accesses Pierrick Bouvier
2024-06-27 19:10 ` Richard Henderson
2024-06-27 19:25 ` Pierrick Bouvier
2024-06-27 20:03 ` Richard Henderson
2024-06-26 23:37 ` [PATCH v2 3/7] plugins: extend API to get latest memory value accessed Pierrick Bouvier
2024-06-26 23:37 ` [PATCH v2 4/7] tests/tcg: add mechanism to run specific tests with plugins Pierrick Bouvier
2024-06-30 1:31 ` Richard Henderson
2024-06-26 23:37 ` [PATCH v2 5/7] tests/tcg: allow to check output of plugins Pierrick Bouvier
2024-06-26 23:37 ` Pierrick Bouvier [this message]
2024-06-27 3:17 ` [PATCH v2 6/7] tests/plugin/mem: add option to print memory accesses Xingtao Yao (Fujitsu) via
2024-06-27 5:29 ` Pierrick Bouvier
2024-06-27 6:04 ` Xingtao Yao (Fujitsu) via
2024-06-27 18:31 ` Pierrick Bouvier
2024-06-26 23:37 ` [PATCH v2 7/7] tests/tcg/x86_64: add test for plugin memory access Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626233757.375083-7-pierrick.bouvier@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).