From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Xiaoyao Li <xiaoyao.li@intel.com>, John Allen <john.allen@amd.com>
Subject: [PATCH 0/2] target/i386: drop AMD machine check bits from Intel CPUID
Date: Thu, 27 Jun 2024 16:06:26 +0200 [thread overview]
Message-ID: <20240627140628.1025317-1-pbonzini@redhat.com> (raw)
The recent addition of the SUCCOR bit to kvm_arch_get_supported_cpuid()
causes the bit to be visible when "-cpu host" VMs are started on Intel
processors.
While this should in principle be harmless, it's not tidy and we don't
even know for sure that it doesn't cause any guest OS to take unexpected
paths. So plumb in a mechanism for x86_cpu_get_supported_feature_word()
to return different values depending on the *guest* CPU vendor (which,
for KVM, is by default the same as the host vendor); and then use it
to hide the SUCCOR bit if the guest has non-AMD vendor.
Paolo Bonzini (2):
target/i386: pass X86CPU to x86_cpu_get_supported_feature_word
target/i386: drop AMD machine check bits from Intel CPUID
target/i386/cpu.h | 3 +--
target/i386/cpu.c | 29 +++++++++++++++++++++--------
target/i386/kvm/kvm-cpu.c | 2 +-
3 files changed, 23 insertions(+), 11 deletions(-)
--
2.45.2
next reply other threads:[~2024-06-27 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 14:06 Paolo Bonzini [this message]
2024-06-27 14:06 ` [PATCH 1/2] target/i386: pass X86CPU to x86_cpu_get_supported_feature_word Paolo Bonzini
2024-06-28 8:26 ` Xiaoyao Li
2024-06-27 14:06 ` [PATCH 2/2] target/i386: drop AMD machine check bits from Intel CPUID Paolo Bonzini
2024-06-28 8:31 ` Xiaoyao Li
2024-06-28 13:23 ` Paolo Bonzini
2024-07-01 4:23 ` Zhao Liu
2024-07-01 6:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627140628.1025317-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=john.allen@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).