qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Laurent Vivier" <lvivier@redhat.com>,
	"Tyrone Ting" <kfting@nuvoton.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Bin Meng" <bmeng.cn@gmail.com>, "Hao Wu" <wuhaotsh@google.com>,
	"Francisco Iglesias" <francisco.iglesias@amd.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	qemu-arm@nongnu.org, "Joel Stanley" <joel@jms.id.au>,
	"Sai Pavan Boddu" <sai.pavan.boddu@amd.com>,
	devel@lists.libvirt.org, "Luc Michel" <luc.michel@amd.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH v3 14/17] hw/sd/sdcard: Extract sd_blk_len() helper
Date: Thu, 27 Jun 2024 18:22:29 +0200	[thread overview]
Message-ID: <20240627162232.80428-15-philmd@linaro.org> (raw)
In-Reply-To: <20240627162232.80428-1-philmd@linaro.org>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Extract sd_blk_len() helper, use definitions instead
of magic values.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/sd/sd.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index aaa50ab2c5..5997e13107 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -603,6 +603,14 @@ static void sd_response_r7_make(SDState *sd, uint8_t *response)
     stl_be_p(response, sd->vhs);
 }
 
+static uint32_t sd_blk_len(SDState *sd)
+{
+    if (FIELD_EX32(sd->ocr, OCR, CARD_CAPACITY)) {
+        return 1 << HWBLOCK_SHIFT;
+    }
+    return sd->blk_len;
+}
+
 static uint64_t sd_req_get_address(SDState *sd, SDRequest req)
 {
     uint64_t addr;
@@ -2076,7 +2084,7 @@ uint8_t sd_read_byte(SDState *sd)
     if (sd->card_status & (ADDRESS_ERROR | WP_VIOLATION))
         return 0x00;
 
-    io_len = (sd->ocr & (1 << 30)) ? 512 : sd->blk_len;
+    io_len = sd_blk_len(sd);
 
     trace_sdcard_read_data(sd->proto->name,
                            sd->last_cmd_name,
-- 
2.41.0



  parent reply	other threads:[~2024-06-27 16:25 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27 16:22 [PATCH v3 00/17] hw/sd/sdcard: Accumulation of cleanups and fixes Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 01/17] hw/sd/sdcard: Deprecate support for spec v1.10 Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 02/17] hw/sd/sdcard: Use spec v3.01 by default Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 03/17] hw/sd/sdcard: Track last command used to help logging Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 04/17] hw/sd/sdcard: Trace block offset in READ/WRITE data accesses Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 05/17] hw/sd/sdcard: Trace requested address computed by sd_req_get_address() Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 06/17] hw/sd/sdcard: Do not store vendor data on block drive (CMD56) Philippe Mathieu-Daudé
2024-07-09 20:38   ` Fabiano Rosas
2024-07-09 21:01     ` Peter Xu
2024-07-10 14:08       ` Fabiano Rosas
2024-07-10 15:01         ` Peter Xu
2024-07-10 16:21           ` Fabiano Rosas
2024-07-10 19:13             ` Peter Xu
2024-07-10 19:48               ` Fabiano Rosas
2024-07-10 20:11                 ` Peter Xu
2024-07-10 21:38                   ` Fabiano Rosas
2024-07-10 22:06                     ` Peter Xu
2024-07-11 13:34                       ` Fabiano Rosas
2024-07-11 14:10                         ` Peter Xu
2024-07-11 14:44                           ` Fabiano Rosas
2024-07-11 14:56                             ` Peter Xu
2024-07-11 15:03                               ` Fabiano Rosas
2024-06-27 16:22 ` [PATCH v3 07/17] hw/sd/sdcard: Send WRITE_PROT bits MSB first (CMD30) Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 08/17] hw/sd/sdcard: Send NUM_WR_BLOCKS bits MSB first (ACMD22) Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 09/17] hw/sd/sdcard: Use READY_FOR_DATA definition instead of magic value Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 10/17] hw/sd/sdcard: Assign SDCardStates enum values Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 11/17] hw/sd/sdcard: Simplify sd_inactive_state handling Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 12/17] hw/sd/sdcard: Restrict SWITCH_FUNCTION to sd_transfer_state (CMD6) Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 13/17] hw/sd/sdcard: Add direct reference to SDProto in SDState Philippe Mathieu-Daudé
2024-06-27 16:22 ` Philippe Mathieu-Daudé [this message]
2024-06-27 16:22 ` [PATCH v3 15/17] tests/qtest: Disable npcm7xx_sdhci tests using hardcoded RCA Philippe Mathieu-Daudé
2024-06-27 16:47   ` Thomas Huth
2024-06-27 17:19     ` Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 16/17] hw/sd/sdcard: Generate random RCA value Philippe Mathieu-Daudé
2024-06-27 16:22 ` [PATCH v3 17/17] hw/sd/sdcard: Introduce definitions for EXT_CSD register Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240627162232.80428-15-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=bmeng.cn@gmail.com \
    --cc=clg@kaod.org \
    --cc=devel@lists.libvirt.org \
    --cc=f4bug@amsat.org \
    --cc=francisco.iglesias@amd.com \
    --cc=joel@jms.id.au \
    --cc=kfting@nuvoton.com \
    --cc=luc.michel@amd.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sai.pavan.boddu@amd.com \
    --cc=thuth@redhat.com \
    --cc=wuhaotsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).