From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: akihiko.odaki@daynix.com, alex.bennee@linaro.org, qemu-arm@nongnu.org
Subject: [PATCH v4 13/14] tests/tcg/arm: Use vmrs/vmsr instead of mcr/mrc
Date: Sun, 30 Jun 2024 12:00:49 -0700 [thread overview]
Message-ID: <20240630190050.160642-14-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240630190050.160642-1-richard.henderson@linaro.org>
Clang 14 generates
/home/rth/qemu/src/tests/tcg/arm/fcvt.c:431:9: error: invalid operand for instruction
asm("mrc p10, 7, r1, cr1, cr0, 0\n\t"
^
<inline asm>:1:6: note: instantiated into assembly here
mrc p10, 7, r1, cr1, cr0, 0
^
/home/rth/qemu/src/tests/tcg/arm/fcvt.c:432:32: error: invalid operand for instruction
"orr r1, r1, %[flags]\n\t"
^
<inline asm>:3:6: note: instantiated into assembly here
mcr p10, 7, r1, cr1, cr0, 0
^
This is perhaps a clang bug, but using the neon mnemonic is clearer.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tests/tcg/arm/fcvt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/tcg/arm/fcvt.c b/tests/tcg/arm/fcvt.c
index d8c61cd29f..ecebbb0247 100644
--- a/tests/tcg/arm/fcvt.c
+++ b/tests/tcg/arm/fcvt.c
@@ -427,10 +427,9 @@ int main(int argc, char *argv[argc])
/* And now with ARM alternative FP16 */
#if defined(__arm__)
- /* See glibc sysdeps/arm/fpu_control.h */
- asm("mrc p10, 7, r1, cr1, cr0, 0\n\t"
+ asm("vmrs r1, fpscr\n\t"
"orr r1, r1, %[flags]\n\t"
- "mcr p10, 7, r1, cr1, cr0, 0\n\t"
+ "vmsr fpscr, r1"
: /* no output */ : [flags] "n" (1 << 26) : "r1" );
#else
asm("mrs x1, fpcr\n\t"
--
2.34.1
next prev parent reply other threads:[~2024-06-30 19:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 19:00 [PATCH v4 00/14] test/tcg: Clang build fixes for arm/aarch64 Richard Henderson
2024-06-30 19:00 ` [PATCH v4 01/14] tests/tcg/minilib: Constify digits in print_num Richard Henderson
2024-07-01 12:10 ` Philippe Mathieu-Daudé
2024-06-30 19:00 ` [PATCH v4 02/14] tests/tcg: Adjust variable defintion from cc-option Richard Henderson
2024-06-30 19:00 ` [PATCH v4 03/14] tests/tcg/aarch64: Drop -fno-tree-loop-distribute-patterns Richard Henderson
2024-06-30 19:00 ` [PATCH v4 04/14] tests/tcg/aarch64: Explicitly specify register width Richard Henderson
2024-06-30 19:00 ` [PATCH v4 05/14] tests/tcg/aarch64: Fix irg operand type Richard Henderson
2024-06-30 19:00 ` [PATCH v4 06/14] tests/tcg/aarch64: Do not use x constraint Richard Henderson
2024-06-30 19:00 ` [PATCH v4 07/14] tests/tcg/aarch64: Add -fno-integrated-as for sme Richard Henderson
2024-06-30 19:00 ` [PATCH v4 08/14] tests/tcg/arm: Fix fcvt result messages Richard Henderson
2024-06-30 19:00 ` [PATCH v4 09/14] tests/tcg/arm: Drop -N from LDFLAGS Richard Henderson
2024-06-30 19:00 ` [PATCH v4 10/14] tests/tcg/arm: Use -fno-integrated-as for test-arm-iwmmxt Richard Henderson
2024-06-30 19:00 ` [PATCH v4 11/14] tests/tcg/arm: Manually register allocate half-precision numbers Richard Henderson
2024-06-30 19:00 ` [PATCH v4 12/14] tests/tcg/arm: Use -march and -mfpu for fcvt Richard Henderson
2024-06-30 19:00 ` Richard Henderson [this message]
2024-06-30 19:00 ` [PATCH v4 14/14] linux-user/main: Suppress out-of-range comparison warning for clang Richard Henderson
2024-07-01 10:40 ` [PATCH v4 00/14] test/tcg: Clang build fixes for arm/aarch64 Akihiko Odaki
2024-07-04 19:55 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240630190050.160642-14-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).