From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Hanna Czenczek" <hreitz@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [PATCH 08/14] rust: define wrappers for methods of the QOM Device class
Date: Mon, 1 Jul 2024 16:58:40 +0200 [thread overview]
Message-ID: <20240701145853.1394967-9-pbonzini@redhat.com> (raw)
In-Reply-To: <20240701145853.1394967-1-pbonzini@redhat.com>
Provide a trait that can be used to invoke methods of the QOM Device
class. The trait extends Deref and has a blanket implementation for any
type that dereferences to IsA<DeviceState>. This way, it can be used on any
struct that dereferences to Object or a subclass.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
qemu/src/hw/core/device.rs | 56 ++++++++++++++++++++++++++++++++++++++
qemu/src/hw/core/mod.rs | 1 +
qemu/src/hw/mod.rs | 1 +
qemu/src/lib.rs | 4 +++
4 files changed, 62 insertions(+)
create mode 100644 qemu/src/hw/core/device.rs
create mode 100644 qemu/src/hw/core/mod.rs
create mode 100644 qemu/src/hw/mod.rs
diff --git a/qemu/src/hw/core/device.rs b/qemu/src/hw/core/device.rs
new file mode 100644
index 0000000..294251e
--- /dev/null
+++ b/qemu/src/hw/core/device.rs
@@ -0,0 +1,56 @@
+//! Bindings for the QOM Device class
+//!
+//! @author Paolo Bonzini
+
+use crate::qom::object::ObjectType;
+
+use crate::qom::refs::IsA;
+use crate::qom::refs::ObjectCast;
+
+use crate::bindings;
+use crate::bindings::device_cold_reset;
+use crate::bindings::device_realize;
+use crate::bindings::DeviceState;
+use crate::bindings::Object;
+
+use crate::qom_isa;
+
+use crate::Result;
+
+use std::ffi::CStr;
+use std::ops::Deref;
+use std::ptr::null_mut;
+
+unsafe impl ObjectType for DeviceState {
+ const TYPE: &'static CStr = c"device";
+}
+
+qom_isa!(DeviceState, Object);
+
+/// Trait for methods exposed by the Object class. The methods can be
+/// called on all objects that have the trait `IsA<Object>`.
+///
+/// The trait should only be used through the blanket implementation,
+/// which guarantees safety via `IsA`
+pub trait DeviceMethods: Deref
+where
+ Self::Target: IsA<DeviceState>,
+{
+ fn realize(&self) -> Result<()> {
+ let device = self.upcast::<DeviceState>();
+ let mut err: *mut bindings::Error = null_mut();
+ // SAFETY: safety of this is the requirement for implementing IsA
+ unsafe {
+ device_realize(device.as_mut_ptr(), &mut err);
+ crate::Error::err_or_default(err)
+ }
+ }
+
+ fn cold_reset(&self) {
+ let device = self.upcast::<DeviceState>();
+ // SAFETY: safety of this is the requirement for implementing IsA
+ unsafe { device_cold_reset(device.as_mut_ptr()) }
+ }
+}
+
+impl<R: Deref> DeviceMethods for R where R::Target: IsA<DeviceState> {}
diff --git a/qemu/src/hw/core/mod.rs b/qemu/src/hw/core/mod.rs
new file mode 100644
index 0000000..5458924
--- /dev/null
+++ b/qemu/src/hw/core/mod.rs
@@ -0,0 +1 @@
+pub mod device;
diff --git a/qemu/src/hw/mod.rs b/qemu/src/hw/mod.rs
new file mode 100644
index 0000000..5a7ca06
--- /dev/null
+++ b/qemu/src/hw/mod.rs
@@ -0,0 +1 @@
+pub mod core;
diff --git a/qemu/src/lib.rs b/qemu/src/lib.rs
index a6e7b17..b0dcce1 100644
--- a/qemu/src/lib.rs
+++ b/qemu/src/lib.rs
@@ -2,8 +2,12 @@
#![allow(dead_code)]
pub mod bindings;
+pub use bindings::DeviceState;
pub use bindings::Object;
+pub mod hw;
+pub use hw::core::device::DeviceMethods;
+
pub mod qom;
pub use qom::object::ObjectClassMethods;
pub use qom::object::ObjectMethods;
--
2.45.2
next prev parent reply other threads:[~2024-07-01 15:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 14:58 [PATCH 00/14] rust: example of bindings code for Rust in QEMU Paolo Bonzini
2024-07-01 14:58 ` [PATCH 01/14] add skeleton Paolo Bonzini
2024-07-01 14:58 ` [PATCH 02/14] set expectations Paolo Bonzini
2024-07-01 14:58 ` [PATCH 03/14] rust: define traits and pointer wrappers to convert from/to C representations Paolo Bonzini
2024-07-03 12:48 ` Marc-André Lureau
2024-07-03 12:58 ` Marc-André Lureau
2024-07-03 15:55 ` Paolo Bonzini
2024-09-27 16:09 ` Kevin Wolf
2024-09-27 20:19 ` Paolo Bonzini
2024-09-27 19:36 ` Stefan Hajnoczi
2024-09-27 20:26 ` Paolo Bonzini
2025-05-26 12:35 ` Paolo Bonzini
2024-07-01 14:58 ` [PATCH 04/14] rust: add tests for util::foreign Paolo Bonzini
2024-07-01 14:58 ` [PATCH 05/14] rust: define wrappers for Error Paolo Bonzini
2024-07-01 14:58 ` [PATCH 06/14] rust: define wrappers for basic QOM concepts Paolo Bonzini
2024-07-01 14:58 ` [PATCH 07/14] rust: define wrappers for methods of the QOM Object class Paolo Bonzini
2024-07-01 14:58 ` Paolo Bonzini [this message]
2024-07-01 14:58 ` [PATCH 09/14] rust: add idiomatic bindings to define Object subclasses Paolo Bonzini
2024-07-01 14:58 ` [PATCH 10/14] rust: add idiomatic bindings to define Device subclasses Paolo Bonzini
2024-07-01 14:58 ` [PATCH 11/14] rust: replace std::ffi::c_char with libc::c_char Paolo Bonzini
2024-07-01 14:58 ` [PATCH 12/14] rust: replace c"" literals with cstr crate Paolo Bonzini
2024-07-01 14:58 ` [PATCH 13/14] rust: introduce alternative to offset_of! Paolo Bonzini
2024-07-01 14:58 ` [PATCH 14/14] rust: use version of toml_edit that does not require new Rust Paolo Bonzini
2024-07-04 19:26 ` [PATCH 00/14] rust: example of bindings code for Rust in QEMU Pierrick Bouvier
2024-07-05 8:06 ` Paolo Bonzini
2024-07-05 18:52 ` Pierrick Bouvier
2024-07-05 21:08 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701145853.1394967-9-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=hreitz@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).