From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DE90C3065A for ; Mon, 1 Jul 2024 15:48:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOJG9-0005gw-Eg; Mon, 01 Jul 2024 11:48:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOJG8-0005gf-34 for qemu-devel@nongnu.org; Mon, 01 Jul 2024 11:48:04 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOJG4-0005od-TE for qemu-devel@nongnu.org; Mon, 01 Jul 2024 11:48:03 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WCVlg4f2Rz6K71W; Mon, 1 Jul 2024 23:46:55 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 5F69C140CB1; Mon, 1 Jul 2024 23:47:53 +0800 (CST) Received: from localhost (10.203.174.77) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 1 Jul 2024 16:47:52 +0100 Date: Mon, 1 Jul 2024 16:47:51 +0100 To: Igor Mammedov CC: , Markus Armbruster , , , , , Richard Henderson , , Dave Jiang , Huang Ying , Paolo Bonzini , , , Michael Roth , Ani Sinha Subject: Re: [PATCH v3 08/11] hw/acpi: Generic Port Affinity Structure support Message-ID: <20240701164751.000000a9@Huawei.com> In-Reply-To: <20240701105219.09f2b1fd@imammedo.users.ipa.redhat.com> References: <20240620160324.109058-1-Jonathan.Cameron@huawei.com> <20240620160324.109058-9-Jonathan.Cameron@huawei.com> <20240701105219.09f2b1fd@imammedo.users.ipa.redhat.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.174.77] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500005.china.huawei.com (7.191.163.240) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, 1 Jul 2024 10:52:19 +0200 Igor Mammedov wrote: > On Thu, 20 Jun 2024 17:03:16 +0100 > Jonathan Cameron wrote: > > > These are very similar to the recently added Generic Initiators > > but instead of representing an initiator of memory traffic they > > represent an edge point beyond which may lie either targets or > > initiators. Here we add these ports such that they may > > be targets of hmat_lb records to describe the latency and > > bandwidth from host side initiators to the port. A discoverable > > mechanism such as UEFI CDAT read from CXL devices and switches > > is used to discover the remainder of the path, and the OS can build > > up full latency and bandwidth numbers as need for work and data > > placement decisions. > > > > Acked-by: Markus Armbruster > > Signed-off-by: Jonathan Cameron > > --- > > v3: Move to hw/acpi/pci.c > > Rename the funciton to actually registers both types > > of generic nodes to reflect it isn't GI only. > > Note that the qom part is unchanged and other changes are mostly > > code movement so I've kept Markus' Ack. > > --- > > qapi/qom.json | 34 ++++ > > include/hw/acpi/acpi_generic_initiator.h | 35 ++++ > > include/hw/acpi/aml-build.h | 4 + > > include/hw/acpi/pci.h | 3 +- > > include/hw/pci/pci_bridge.h | 1 + > > hw/acpi/acpi_generic_initiator.c | 216 +++++++++++++++++++++++ > > hw/acpi/aml-build.c | 40 +++++ > > hw/acpi/pci.c | 110 +++++++++++- > > hw/arm/virt-acpi-build.c | 2 +- > > hw/i386/acpi-build.c | 2 +- > > hw/pci-bridge/pci_expander_bridge.c | 1 - > > 11 files changed, 443 insertions(+), 5 deletions(-) > > this is quite large patch, is it possible to split into > a set of smaller patches? Oops. It's bigger that it should due to a messed up rebase. The acpi_generic_initator.c/.h shouldn't exist! With those gone will be much more manageable.