qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, mst@redhat.com, jasowang@redhat.com,
	qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: [PATCH v4 0/2] virtio-pci: Fix the use of an uninitialized irqfd
Date: Tue,  2 Jul 2024 09:59:35 +0800	[thread overview]
Message-ID: <20240702020033.139261-1-lulu@redhat.com> (raw)

The crash was reported in MAC OS and NixOS, here is the link for this bug
https://gitlab.com/qemu-project/qemu/-/issues/2334
https://gitlab.com/qemu-project/qemu/-/issues/2321

changelog v4 -> v3
 - Address the comments in V3
 - sperate the return check in kvm_virtio_pci_vector_use_one()
   in different patch
changelog v3 -> v2
 - Move the vector_irqfd check to virtio_pci_get_notifier().
   This function can also be used while vdev->status is not VIRTIO_CONFIG_S_DRIVER_OK.
   In that case, the vector_irqfd could be NULL, so also add the status check here.
 - Add the return value check for kvm_virtio_pci_vector_use_one().
   Since the return value of function virtio_pci_set_vector() is void,
   just add the error message here.

Cindy Lu (2):
  virtio-pci: Fix the use of an uninitialized irqfd
  virtio-pci: Add check the return of kvm_virtio_pci_vector_use_one

 hw/virtio/virtio-pci.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-- 
2.45.0



             reply	other threads:[~2024-07-02  2:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02  1:59 Cindy Lu [this message]
2024-07-02  1:59 ` [PATCH v4 1/2] virtio-pci: Fix the use of an uninitialized irqfd Cindy Lu
2024-07-02  7:09   ` Jason Wang
2024-07-16  6:25     ` Cindy Lu
2024-07-02  1:59 ` [PATCH v4 2/2] virtio-pci: Add check the return of kvm_virtio_pci_vector_use_one Cindy Lu
2024-07-02  7:10   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240702020033.139261-1-lulu@redhat.com \
    --to=lulu@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).