From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Cédric Le Goater" <clg@redhat.com>,
Jamin_lin <jamin_lin@aspeedtech.com>
Subject: [PULL 3/6] aspeed/sdmc: Check RAM size value at realize time
Date: Tue, 2 Jul 2024 10:00:39 +0200 [thread overview]
Message-ID: <20240702080042.464220-4-clg@redhat.com> (raw)
In-Reply-To: <20240702080042.464220-1-clg@redhat.com>
The RAM size of the SDMC device is validated for the SoC and set when
the Aspeed machines are initialized and then later used by several
SoC implementations. However, the SDMC model never checks that the RAM
size has been actually set before being used. Do that at realize.
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Jamin_lin < jamin_lin@aspeedtech.com>
---
hw/misc/aspeed_sdmc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
index 93e2e29ead87..44da085e10cb 100644
--- a/hw/misc/aspeed_sdmc.c
+++ b/hw/misc/aspeed_sdmc.c
@@ -271,6 +271,12 @@ static void aspeed_sdmc_realize(DeviceState *dev, Error **errp)
AspeedSDMCClass *asc = ASPEED_SDMC_GET_CLASS(s);
assert(asc->max_ram_size < 4 * GiB || asc->is_bus64bit);
+
+ if (!s->ram_size) {
+ error_setg(errp, "RAM size is not set");
+ return;
+ }
+
s->max_ram_size = asc->max_ram_size;
memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_sdmc_ops, s,
--
2.45.2
next prev parent reply other threads:[~2024-07-02 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 8:00 [PULL 0/6] aspeed queue Cédric Le Goater
2024-07-02 8:00 ` [PULL 1/6] hw/gpio/aspeed: Add reg_table_count to AspeedGPIOClass Cédric Le Goater
2024-07-02 8:00 ` [PULL 2/6] aspeed: Deprecate the tacoma-bmc machine Cédric Le Goater
2024-07-02 8:00 ` Cédric Le Goater [this message]
2024-07-02 8:00 ` [PULL 4/6] aspeed/soc: Fix possible divide by zero Cédric Le Goater
2024-07-02 8:00 ` [PULL 5/6] aspeed/sdmc: Remove extra R_MAIN_STATUS case Cédric Le Goater
2024-07-02 8:00 ` [PULL 6/6] hw/net:ftgmac100: fix coding style Cédric Le Goater
2024-07-02 22:47 ` [PULL 0/6] aspeed queue Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702080042.464220-4-clg@redhat.com \
--to=clg@redhat.com \
--cc=jamin_lin@aspeedtech.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).